Thread: problem with calculator

hey guys i got a problem with this program.I m supposed to make a calculator using stacks but it seems that i m stack. i can t get the right recognition for () and {} []
any tips?
its not necessary to use all these symbols.just a simple () will do .here s the program

package stackscalc;
 
import java.util.Scanner;
import java.util.Stack;
import java.util.EmptyStackException;
 
 
class Arithmetic
{
int length;
Stack stk;
String exp,
postfix;
 
Arithmetic(String s)
{
    stk = new Stack();
    exp = s;
    postfix = "";
    length = exp.length();
 
}
boolean isBalance()
{
    boolean fail = false;
    int index = 0;
 
    try
    {
        while (index < length)
        {
            char ch = exp.charAt(index);
 
            switch(ch)
            {
                case ')':
                    stk.pop();
                break;
 
                case '(':
                    stk.push(new Character(ch));
                break;
 
                default:
                break;
            }
                index++;
        }
    }
    catch(EmptyStackException e)
    {
        fail = true;
    }
        return stk.empty() && !fail;
}
void postfixExpression()
{
    String token = "";
    Scanner scan = new Scanner(exp);
    stk.clear();
 
    while(scan.hasNext())
    {
        token = scan.next();
        char current = token.charAt(0);
 
        if (isNumber(token))
        {
            postfix = postfix + token + " ";
        }
        else if(isParentheses(current))
        {
            if(current == '(')
            {
                stk.push(current);
            }
            else
            {
                Character ch = (Character)stk.peek();
                char nextToken = ch.charValue();
 
                while(nextToken != '(')
                {
                    postfix = postfix + stk.pop() + " ";
 
                    ch = (Character)stk.peek();
 
                    nextToken = ch.charValue();
                }
                    stk.pop();
            }
        }
        else
        {
            if(stk.empty())
            {
                stk.push(current);
            }
            else
            {
                Character ch = (Character)stk.peek();
                char top = ch.charValue();
 
                if(hasHigherPrecedence(top, current))
                {
                    stk.push(current);
                }
                else
                {
                    ch = (Character)stk.pop();
 
                    top = ch.charValue();
 
                    stk.push(current);
 
                    stk.push(top);
                }
            }
        }
    }
    try
    {
        Character ch = (Character)stk.peek();
        char nextToken = ch.charValue();
 
        while(isOperator(nextToken))
        {
            postfix = postfix + stk.pop() + " ";
            ch = (Character)stk.peek();
            nextToken = ch.charValue();
        }
    }catch(EmptyStackException e){}
}
boolean isNumber(String s)
{
    try
    {
        int Num = Integer.parseInt(s);
    }
    catch(NumberFormatException e)
    {
        return false;
    }
        return true;
}
void evaluateRPN()
{
    Scanner scan = new Scanner(postfix);
    String token = "";
    stk.clear();
 
    while(scan.hasNext())
    {
        try
        {
        token = scan.next();
        if (isNumber(token))
        {
            stk.push(token);
        }
        else
        {
            char current = token.charAt(0);
            double t1 = Double.parseDouble(stk.pop().toString());
            double t2 = Double.parseDouble(stk.pop().toString());
            double t3 = 0;
 
            switch(current)
            {
                case'+':
                {
                    t3 = t2 + t1;
                    stk.push(t3);
                    break;
                }
                case'-':
                {
                    t3 = t2 - t1;
                    stk.push(t3);
                    break;
                }
                case'*':
                {
                    t3 = t2 * t1;
                    stk.push(t3);
                    break;
                }
                case'/':
                {
                    t3 = t2 / t1;
                    stk.push(t3);
                    break;
                }
                default:
                {
                    System.out.println("Reverse Polish Notation was unable to be preformed.");
                }
            }
      }
 
        }
 
        catch(EmptyStackException e){}
    }
}
String getResult()
{
    return stk.toString();
}
 
int stackSize()
{
    return stk.size();
}
 
boolean isParentheses(char current)
{
    if((current == '(') || (current == ')'))
    {
        return true;
    }
    else
    {
        return false;
    }
}
 
boolean isOperator(char ch)
{
    if((ch == '-'))
    {
        return true;
    }
    else if((ch == '+'))
    {
        return true;
    }
    else if((ch == '*'))
    {
        return true;
    }
    else if((ch == '/'))
    {
        return true;
    }
    else
    {
 
    }
        return false;
}
 
boolean hasHigherPrecedence(char top, char current)
{
    boolean HigherPre = false;
 
    switch(current)
    {
    case '*':
        HigherPre = true;
    break;
 
    case '/':
        HigherPre = true;
    break;
 
    case '+':
 
        if((top == '*') || (top == '/') || (top == '-'))
        {
             HigherPre = false;
        }
        else
        {
             HigherPre = true;
        }
 
    break;
 
    case'-':
        if((top == '*') || (top == '/') || (top == '-'))
        {
            HigherPre = false;
        }
        else
        {
            HigherPre = true;
        }
    break;
 
   default:
            System.out.println("Higher Precedence Unsuccessful was unable to be preformed.");
   break;
    }
 
return HigherPre;
}
 
String getPostfix()
{
    return postfix;
}
}

Welcome! Please read this topic to learn how to post code correctly and other useful info for new members.

oh sorry its just that i have to give this assignment in 10 days and i m kinda nervous!i fixed though thank you!
any suggestions guys?it gives me error and i don t know what i did wrong

Provide a sample run. Either copy and paste the result from your own console or type out something like:

Enter this:

Got this:

Should be this:

Whichever approach you choose, be sure to describe or show what the desired answer should be.

yes guys i m sorry you are right.i have a class and our instructor after like 30-40 hours of java wanted us to make a calculator using 2 stacks and i struggle to make it.i m newbie to java.he doesn t want swing just the code.i ll try a bit more and get back to you with more results.i tried the search button but i didn t find any tutorial on how to make it

What are you struggling with? If you're getting errors, post them. If your outputs are not correct, show a sample run and describe how the results are not correct. There's no struggle there, just do it.

i added this part
public static void main (String[] args)
{
Arithemtic calculator = new Arithmetic();
calculator.isBalance();
}
but it says class, interface, or enum expected
this is the main program do i need to add anything else to it so it runs?

After 30-40 hours of instruction, you should know how to add methods to a class, especially the main() method. It looks like you haven't been paying attention. Refer to your notes, your textbook, other examples.

yeah my bad i did it right this time and it shows me
constructor Arithmetic in class stackscalc.Arithmetic cannot be applied to given types;
required: java.lang.String
found: no arguments
reason: actual and formal argument lists differ in length

The error message is clear. The Arithmetic() constructor requires a String argument, the main() method you wrote calls Arithmetic() with no argument. Again, this error is one you should have seen and solved several times by now.

The problem you said you were having in your first post is making less and less sense. You haven't gotten that far, and you're having trouble getting code that will compile and run. Keep working those errors, come back when you get stuck.

ok guys so i changed the code and i compiled and didn t find any mistakes.but when i run it it shows me this ( i try to run it in an online compiler site )
Compiling the source code....
$javac Calculator.java 2>&1
Note: Calculator.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

Executing the program....
$java -Xmx128M -Xms16M Calculator
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 0
at Calculator.main(Calculator.java:84)

import java.util.StringTokenizer;
import java.util.Stack;
 
public class Calculator {
 
       static int precedence(char op) {
              switch(op) {
              case '+' :
              case '-' : 
                       return 5;
              case '*' :
              case '/' :
                       return 10;
              default :
                       throw new IllegalArgumentException("invalid operator");
               }
         }
       public static String infixToPostfix(String infix) {
              StringTokenizer tokenizer = new StringTokenizer (infix);
              String postfix = "";
              Stack opStack = new Stack ();
 
              while (tokenizer.hasMoreTokens()) {
                     String token = tokenizer.nextToken();
                     char c = token.charAt(0);
                     if (Character.isDigit(c)){
                            postfix +=(token + " ");
                     }
                     else {
                             while (!opStack.empty()){
                                    char top = ((Character)opStack.peek()).charValue();
                                    if (precedence(top) >= precedence(c)) {
                                            postfix += (top + " ");
                                            opStack.pop();
                                     }
                                     else {
                                            break;
                                           }
                                     }
                                     opStack.push(new Character (c));
                          }
                      }
 
               while (!opStack.empty()) {
                      char top = ((Character)opStack.pop()).charValue();
                      postfix += (top + " ");
                }
                return postfix;
        }
 
     public static int evalPostfix(String postfix) {
              StringTokenizer tokenizer = new StringTokenizer(postfix);
              Stack valStack = new Stack();
 
              while(tokenizer.hasMoreTokens()) {
                     String token = tokenizer.nextToken();
                     char c = token.charAt(0);
                     if (Character.isDigit(c)) {
                            valStack.push(new Integer(token));
                      }
                      else {
                              int rightVal = ((Integer)valStack.pop()).intValue();
                              int leftVal = ((Integer)valStack.pop()).intValue();
                              int rslt;
 
                              switch(c) {
                              case '+' : rslt = leftVal + rightVal;break;
                              case '-' : rslt = leftVal - rightVal;break;
                              case '*' : rslt = leftVal * rightVal;break;
                              case '/' : rslt = leftVal + rightVal;break;
                              default:
                                     throw new IllegalArgumentException("invalid postfix expression");
                                }
                               valStack.push(new Integer(rslt));
                            }
                     }
                 int rslt = ((Integer)valStack.pop()).intValue();
                 if (!valStack.empty()){
                          throw new IllegalArgumentException("invalid postfix expression");
                  }
                      return rslt;
          }
      public static void main(String[] args)  {
             String infix = args[0];
             String postfix = infixToPostfix(infix); 
             System.out.println("postfix"+postfix);
             int value = evalPostfix(postfix);
             System.out.println("value: " + value);
         }
}

i copied paste it wrong from my wordpad!sorry but i m very tired i ve trying this thing for hours.now i think i pasted right!

i added these at the start
import java.util.StringTokenizer;
import java.util.Stack;
forgot to paste them.now it compiles

ah yeah i understand what u meant!thanx!sorry but i m really dizzy and english is not my main language!

All fixed then?

yes now i have another question if you don t mind!i have a code for an infix post fix and evaluation as a calculator
here is the code.it compiles its ok

 // Stack for numbers: 'values'
        Stack<Integer> values = new Stack<Integer>();
 
        // Stack for Operators: 'ops'
        Stack<Character> ops = new Stack<Character>();
 
        for (int i = 0; i < tokens.length; i++)
        {
             // Current token is a whitespace, skip it
            if (tokens[i] == ' ')
                continue;
 
            // Current token is a number, push it to stack for numbers
            if (tokens[i] >= '0' && tokens[i] <= '9')
            {
                StringBuffer sbuf = new StringBuffer();
                // There may be more than one digits in number
                while (i < tokens.length && tokens[i] >= '0' && tokens[i] <= '9')
                    sbuf.append(tokens[i++]);
                values.push(Integer.parseInt(sbuf.toString()));
            }
 
            // Current token is an opening brace, push it to 'ops'
            else if (tokens[i] == '(')
                ops.push(tokens[i]);
 
            // Closing brace encountered, solve entire brace
            else if (tokens[i] == ')')
            {
                while (ops.peek() != '(')
                  values.push(applyOp(ops.pop(), values.pop(), values.pop()));
                ops.pop();
            }
 
            // Current token is an operator.
            else if (tokens[i] == '+' || tokens[i] == '-' ||
                     tokens[i] == '*' || tokens[i] == '/')
            {
                // While top of 'ops' has same or greater precedence to current
                // token, which is an operator. Apply operator on top of 'ops'
                // to top two elements in values stack
                while (!ops.empty() && hasPrecedence(tokens[i], ops.peek()))
                  values.push(applyOp(ops.pop(), values.pop(), values.pop()));
 
                // Push current token to 'ops'.
                ops.push(tokens[i]);
            }
        }
 
        // Entire expression has been parsed at this point, apply remaining
        // ops to remaining values
        while (!ops.empty())
            values.push(applyOp(ops.pop(), values.pop(), values.pop()));
 
        // Top of 'values' contains result, return it
        return values.pop();
    }
 
    // Returns true if 'op2' has higher or same precedence as 'op1',
    // otherwise returns false.
    public static boolean hasPrecedence(char op1, char op2)
    {
        if (op2 == '(' || op2 == ')')
            return false;
        if ((op1 == '*' || op1 == '/') && (op2 == '+' || op2 == '-'))
            return false;
        else
            return true;
    }
 
    // A utility method to apply an operator 'op' on operands 'a' 
    // and 'b'. Return the result.
    public static int applyOp(char op, int b, int a)
    {
        switch (op)
        {
        case '+':
            return a + b;
        case '-':
            return a - b;
        case '*':
            return a * b;
        case '/':
            if (b == 0)
                throw new
                UnsupportedOperationException("Cannot divide by zero");
            return a / b;
        }
        return 0;
    }
 
    // Driver method to test above methods
    public static void main(String[] args)
    {
        System.out.println(EvaluateString.evaluate("10 + 2 * 6"));
        System.out.println(EvaluateString.evaluate("100 * 2 + 12"));
        System.out.println(EvaluateString.evaluate("100 * ( 2 + 12 )"));
        System.out.println(EvaluateString.evaluate("100 * ( 2 + 12 ) / 14"));
    }
}

now how can i make it to ask the user to put a string to evaluate?as an input i mean
i must add input scanner etc then ask the user to input the string and then i name it like for example a
and i just add a.EvaluateString? or a.evaluate?

scanner class is more preferable.no need for joptionpane
as for the string it will be something like something like
system.out.println("give numbers");
String input = scan.nextLine();
EvaluateString.evaluate(input);
is that correct?

i tried to compiled it again and now it says provided class name is invalid.how did this happen?are online compilers trustworthy?