Thread: javadisplay images

Can you fix the formatting of the code? The indentations are not right. There are missing }s

The posted code is a mess. There are a lot of definitions missing.

Originally Posted by Norm

Can you fix the formatting of the code? The indentations are not right. There are missing }s

The posted code is a mess. There are a lot of definitions missing.

here is the code
he code so doesnt that mean that the indentation are correct?

Can you edit the code and format it properly?
Nested statements should be indented
}s should NOT be hidden at the end of statements. Put them on their own line.

There is no errors in the code so doesnt that mean that the indentation are correct?

No, the compiler will accept the whole program on one line.

is this better

No.Too many nested statements start in the first column making it hard to read and understand the logic in the code.
The }s should not be one above the other (in the same column)

See post#51 for an example of proper formatting.

Originally Posted by Norm

No.Too many nested statements start in the first column making it hard to read and understand the logic in the code.
The }s should not be one above the other (in the same column)

See post#51 for an example of proper formatting.

[CODE]
now and you can help me with my problem i got please

Its a little better, but there are still too many statements starting in the first column.
And there are too many statements that are indented that should NOT be indented:

ImageIcon icon = new ImageIcon(img);
 
                JPanel gridPanel = new JPanel(new GridLayout(6, 0, 6, 6));

Those two statements should start in the same column.

Here is a hidden } that makes the code hard to read and understand

                frame.setVisible(true);}

At the end there is }}. }s should be on their own line and NOT in the same column

i have edited it and hope i have understood and corrected what you asked for

One problem I see inside the while loop is there are method calls being made that should only be made one time, not every time an image is created:
setVisible() - only needs to be done ONE time after the GUI has been built
adding to frame at BorderLayout.NORTH - only ONE component will be there, all the other add()s are useless
pack() - only once after everything has been added

The methods should be called when they are needed to do something.
1)When does the GUI need to be packed and shown?
2)When does a filled panel need to be added to the frame?

3)When should the image be created from the bytes just read from the database?
4)When should the new image be added to a panel with a button?
5)When should the panel with the image and the button be added to the panel with the gridlayout?

Take the questions one at a time and decide when they should be executed. Make a list of pseudo code statements to show when each should be executed.

This project may be too advanced for your current knowledge. Maybe you should start with something simpler.
Look at the tutorial about how to build a GUI: Trail: Creating a GUI With JFC/Swing (The Java™ Tutorials)

IS THIS WHAT YOU MEAN?

No, that does not look like a list of steps in pseudo code.
The code is missing several steps.

What does the for loop that loops 2 times do? Why is it there?

Are there supposed to be buttons with the images?
I don't see them in the posted code. I thought that showing them with the images was a BIG problem.

What is a loop that loops once?

problem i have with them is that i cannot get them to go on the images

See post#70.
Put them in a panel and add that panel to the panel with the gridlayout. See steps 4 & 5 in post#92

A suggestion to learn how to make a GUI with image over button:
Take the code from andbin's post#51 and modify it to build panels with images over buttons using the technique shown in post#70.
The results could look like this:
ImageOverButton.png
When that works, you should be able to apply the techniques to the program you are trying to build.

I have looked through the program written by adbin and i have come up with this, but i still cannot understand of where to put the button becuse at the moment it just comes beside it. so i have left it out the code. please help

it just comes beside it

look at post#70 for how to put the image above the button. There isn't any Database used in the code from post#51. Using a DB just makes it harder for this testing. Use a single image that is read from a file.

What is the reason for this code:

     for (int i = 0; i < 1; i++)

You do NOT need a for statement that only loops one time.