Thread: Rock Paper Sissor

Well, this code is kind of messy. But I think the only problem in this code is the int bot =(int)(Math.random()*3); . Did I do it right? Btw, if there is a way better way to make a Rock Paper Sissor code, can you give me a hint on how I could better code this?

import java.util.Scanner;
 
public class Application2 {
 
 
public static void main(String[] args) 
{
 System.out.println("Let's play a game of Rock Paper Sissor!");
 Scanner scanner = new Scanner (System.in);
 System.out.println("Rock Paper Sissor: ");
 String rps=scanner.nextLine();
 int bot = (int) (Math.random()*3);   //Get a number from 1-3. 
 if (rps == "Rock")
 {
	 if (bot==1) //if number from Math.random is 1.
	 {
		 System.out.println ("Bot: Rock. TIE!");
	 }
	 if (bot==2)
	 {
		 System.out.println ("Bot: Paper. You Lose!");
	 }
	 if (bot==3)
	 {
		 System.out.println ("Bot: Sissor. You Win!");
	 }
 }
 if (rps == "Paper")
 {
	 if (bot==1)
	 {
		 System.out.println ("Bot: Rock. You Win!");
	 }
	 if (bot == 2)
	 {
		 System.out.println ("Bot: Paper. TIE!");
	 }
	 if (bot == 3)
	 {
		 System.out.println ("Bot: Sissor. You Lose!");
	 }
 if (rps == "Sissor")
 {
	 if (bot==1)
	 {
		 System.out.println ("Bot: Rock. You Lose!");
	 }
	 if (bot==2)
	 {
		 System.out.println ("Bot: Paper. You Win!");
	 }
	 if (bot==3)
	 {
		 System.out.println ("Bot: Sissor. TIE!");
	 }
 }
 }
 
 
}
}

Originally Posted by Norm

One problem I see is the use of == to compare Strings. You should use the equals() method.

Another problem is the series of if statements where if one of them is true, then none of the others can be true. For that kind of logic, the code should use a chain of if/else if statements. Or a switch statement could be used.

Followed what you said. Here is my new code:

import java.util.Scanner;
 
 
public class Application2 {
 
 
public static void main(String[] args) 
{
 System.out.println("Let's play a game of Rock Paper Sissor!");
 Scanner scanner = new Scanner (System.in);
 System.out.println("Rock Paper Sissor: ");
 String rps=scanner.nextLine();
 int bot = (int) (Math.random()*3);
 if (rps.equals("Rock"))
 {
	 if (bot==1)
	 {
		 System.out.println ("Bot: Rock. TIE!");
	 }
	 else if (bot==2)
	 {
		 System.out.println ("Bot: Paper. You Lose!");
	 }
	 else if (bot==3)
	 {
		 System.out.println ("Bot: Sissor. You Win!");
	 }
 }
 else if (rps.equals("Paper"))
 {
	 if (bot==1)
	 {
		 System.out.println ("Bot: Rock. You Win!");
	 }
	 else if (bot == 2)
	 {
		 System.out.println ("Bot: Paper. TIE!");
	 }
	 else if (bot == 3)
	 {
		 System.out.println ("Bot: Sissor. You Lose!");
	 }
 }
 else if (rps.equals("Sissor"))
 {
	 if (bot==1)
	 {
		 System.out.println ("Bot: Rock. You Lose!");
	 }
	 else if (bot==2)
	 {
		 System.out.println ("Bot: Paper. You Win!");
	 }
	 else if (bot==3)
	 {
		 System.out.println ("Bot: Sissor. TIE!");
	 }
 }
 }
}

Sometimes it would work, sometimes it wouldn't. It would sometimes terminate without anything after I inputted something.
Here is a list of output:

Let's play a game of Rock Paper Sissor!
Rock Paper Sissor:
Rock
Bot: Paper. You Lose!

Let's play a game of Rock Paper Sissor!
Rock Paper Sissor:
Rock
Bot: Rock. TIE!

Let's play a game of Rock Paper Sissor!
Rock Paper Sissor:
Paper

Let's play a game of Rock Paper Sissor!
Rock Paper Sissor:
Sissor

public class Application2 {
 
 
public static void main(String[] args) 
{
 System.out.println("Let's play a game of Rock Paper Sissor!");
 Scanner scanner = new Scanner (System.in);
 System.out.println("Rock Paper Sissor: ");
 String rps=scanner.nextLine();
 int bot = (int) (Math.random()*3);
 if (rps.equals("Rock"))
 {
	 if (bot==1)
	 {
		 System.out.println ("Bot: Rock. TIE!");
	 }
	 else if (bot==2)
	 {
		 System.out.println ("Bot: Paper. You Lose!");
	 }
	 else if (bot==3)
	 {
		 System.out.println ("Bot: Sissor. You Win!");
	 }
	 else
		 System.out.println("error");
 }
 else if (rps.equals("Paper"))
 {
	 if (bot==1)
	 {
		 System.out.println ("Bot: Rock. You Win!");
	 }
	 else if (bot == 2)
	 {
		 System.out.println ("Bot: Paper. TIE!");
	 }
	 else if (bot == 3)
	 {
		 System.out.println ("Bot: Sissor. You Lose!");
	 }
	 else
		 System.out.println("error");
 }
 else if (rps.equals("Sissor"))
 {
	 if (bot==1)
	 {
		 System.out.println ("Bot: Rock. You Lose!");
	 }
	 else if (bot==2)
	 {
		 System.out.println ("Bot: Paper. You Win!");
	 }
	 else if (bot==3)
	 {
		 System.out.println ("Bot: Sissor. TIE!");
	 }
	 else
		 System.out.println("error");
 }
 else
	 System.out.println("error");
 }
 
 
}

Okay, did what you said again. Sometimes I would get "error", that means the Math.random isn't doing 1-3 (inclusive). I think it would sometimes go 0, giving me the error output. How do I fix Math.random so it wouldn't hit 0?

Okay, I got it to work, but I don't understand why it worked:

This is my new Math.random.

int bot = (int) (1+Math.random()*3);

I understand that it would add 1 when Math.random outputs a 0, so the 0 turns to a 1. But in that logic, wouldn't it add 1 to every Math.random? Like, when Math.random gives out a 3, wouldn't the +1 turn it to a 4, giving an error output?

Is there something I am not understanding here? :/

(int)(Math.random() * (max - min) + min).

This is the formula for having value in the range min-max. The minimum number here is min and the max number is max-1.

I hope this helps.