Thread: How do I get rid of the "this."

Ok I have a class in OOP and instructor marked me off for have

 this.employeeId  this.HourlyRate  this.firstName this.lastName

Anyways here is my code, I tried to fix it, but every time the whole thing collapses and get errors, any help would be greatly appreciated

 
 
/*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */
 
package coursework;
 
public class Employee { 
 
	private String firstName; 
	private String lastName; 
	private int employeeId; 
	private double hourlyRate; 
	private Timecard timeCard;
 
	public Employee(String firstNameInput, String lastNameInput, int idInput, double rateInput, int[] daysIn) {
		setFirstName(firstNameInput); 
		setLastName(lastNameInput); 
		setEmployeeID(idInput); 
		setHourlyRate(rateInput); 
		setTimeCard(new Timecard(daysIn));
	} 
 
	public void printEmpDetails() 
	{ 
		System.out.println("Name: " + firstName + " " + lastName); 
		System.out.println("Emp. Id: " + employeeId); 
		System.out.println("Hourly Rate: $" + hourlyRate); 
		System.out.println(); 
	} 
 
	private void setFirstName (String firstName) { 
		// Here we are setting our class variable firstName to the passed in variable "name" 
		// But only if it has a length greater than 0 and less than or equal to 20 
 
		int nameLength = firstName.length(); 
 
		if (nameLength < 1) { 
			System.out.println("First Name length is too small"); 
			System.out.println(firstName + ": " + firstName.length());
		} else if (nameLength > 20) { 
			System.out.println("First Name length is too long"); 
			System.out.println(firstName + ": " + firstName.length());
		} else { 
			this.firstName = firstName; 
		} 
	} 
 
	private void setLastName (String lastName) { 
		// Here we are setting our class variable firstName to the passed in variable "name" 
		// But only if it has a length greater than 0 and less than or equal to 20 
 
		int nameLength = lastName.length(); 
 
		if (nameLength < 1) { 
			System.out.println("Last Name length is too small"); 
			System.out.println(firstName + ": " + lastName.length());
		} else if (nameLength > 20) { 
			System.out.println("Last Name length is too long"); 
			System.out.println(firstName + ": " + lastName.length());
		} else { 
			this.lastName = lastName; 
		} 
	} 
 
	private void setEmployeeID (int employeeId) { 
		// Here we are setting our class variable firstName to the passed in variable "name" 
		// But only if it has a length greater than 0 and less than or equal to 20 
 
		if (employeeId > 9999) { 
			System.out.println("Number length error: this should be less than 9999: " + employeeId); 
		} else if (employeeId < 1000) { 
			System.out.println("Number length error: this should be more than 1000: " + employeeId); 
		} else { 
			this.employeeId = employeeId; 
		} 
	} 
 
	private void setHourlyRate (double hourlyRate) { 
		// Here we are setting our class variable firstName to the passed in variable "name" 
		// But only if it has a length greater than 0 and less than or equal to 20 
 
		if(hourlyRate < 0)
		{
			System.out.println("Incorrect value, number must be greater than zero: " + hourlyRate);
		}
		else{
			this.hourlyRate = hourlyRate; 
		} 
	} 
 
	private void setTimeCard(Timecard newtimeCard) {
 
		if (newtimeCard == null) {
			System.out.print("time card cannot be null");
			System.exit(-1);
		}
		timeCard = newtimeCard;
	}
 
	public Timecard getTimeCard() {
		return timeCard;
	}
 
	public String getFirstName() { 
		// Here we are getting our class variable firstName 
		return firstName; 
	} 
 
	public String getLastName() { 
		// Here we are getting our class variable lastName 
		return lastName; 
	} 
 
 
	public int getEmployeeId() { 
		// Here we are getting our class variable firstName 
		return employeeId; 
	} 
 
	public double getHourlyRate() { 
		// Here we are getting our class variable firstName 
		return hourlyRate; 
	} 
}

Originally Posted by zng690

Ok I have a class in OOP and instructor marked me off for have

 this.employeeId  this.HourlyRate  this.firstName this.lastName

What is you question?? Please be precise whether you want to use the above code in your program or what to do with that??.

Thanks,

Originally Posted by Ganeprog

What is you question?? Please be precise whether you want to use the above code in your program or what to do with that??.

Thanks,

Hi, thanks for the reply, I am looking to keep the employeeId, firstName lastName and such, I just need to get rid of the "this." how do I modify the code to get rid of the "this." and keep the rest

k k fine. You just change the declared variable name or argument name. If you use same name you should differentiate using this keyword. k now use different name for the variables. For your reference,

private void setFirstName (String fName) { 
		// Here we are setting our class variable firstName to the passed in variable "name" 
		// But only if it has a length greater than 0 and less than or equal to 20 
 
		int nameLength = fName.length(); 
 
		if (nameLength < 1) { 
			System.out.println("First Name length is too small"); 
			System.out.println(firstName + ": " + fName.length());
		} else if (nameLength > 20) { 
			System.out.println("First Name length is too long"); 
			System.out.println(firstName + ": " + fName.length());
		} else { 
			firstName = fName; 
		} 
	}

Here i just changed the argument name. Now you don't want to use "this" keyword.

Try it....

Thanks,

When you use the arguments in a method with the same name as the variables of the class/method, then to differentiate between those variables we use "this" keyword, which refers to the current class . So to get rid of them you can change the name of the variables as suggested by Ganeprog

The use of 'this' is often entirely appropriate and consistent with standard coding practices, even sometimes required in order for the code to interface properly with other technologies, JSP/JavaBeans for instance. So, eliminating 'this' simply for the sake of eliminating 'this' may not be a good idea.

If you have a specific need to remove 'this' and then find you have errors you can't correct, then please post the specific cases, the justification for removing the 'this' in each case, and the errors you receive when taking those actions. With that detail, we can give you better answers.

thank you for the advice, the instructor took a few points off my grade on the last assignment, he was anamant about not using "this."

you should not leave it. Get to the core, where you were lagging so that next time you do not face much problems with "this"