Thread: Few errors on my code.

import java.util.Scanner;
 
class Player {
	private String name;
	private String gender;
	private String hcolor;
	private String ecolor;
	private String size;
	private String height;
	private String place;
 
	public void setname(String name)
	{
		this.name = name;
	}
	public void setgender (String gender)
	{
		this.gender = gender;
	}
	public void sethcolor (String hcolor)
	{
		this.hcolor=hcolor;
	}
	public void setecolor (String ecolor)
	{
		this.ecolor=ecolor;
	}
	public void setsize (String size)
	{
		this.size = size;
	}
	public void setheight (String height)
	{
		this.height=height;
	}
	public void setplace (String place)
	{
		this.place=place; 
	}
	public String getname()
	{
		return name;
	}
	public String getgender()
	{
		return gender;
	}
	public String hcolor()
	{
		return hcolor;
	}
	public String getecolor()
	{
		return ecolor;
	}
	public String getsize()
	{
		return size;
	}
	public String getheight()
	{
		return height;
	}
	public String getplace()
	{
		return place;
	}
 
 
public class Roleplaygame {
 
	public static void main(String[] args) {
		Player player1 = new Player();
		Scanner scanner = new Scanner (System.in);
		System.out.print("Name: ");
		String name = scanner.nextLine();
		player1.setname(name);
		System.out.print("Gender: ");
		String gender = scanner.next();
        System.out.print("Hair Color: ");
        String hcolor = scanner.next();
        System.out.print("Eye Color: ");
        String ecolor = scanner.next();
        System.out.print("Fat or Skinny: ");
        String size = scanner.next();
        System.out.print("Tall or Short: ");
        String height = scanner.next();
        System.out.print("Name of the town you are going to: ");
        String place = scanner.next();
        System.out.println ("...");
        System.out.println ("...");
        System.out.println ("Welcome to " + player1.getplace());
        pmenu(place);
 
	}
	public void pmenu(String place)
	{
		System.out.println("Welcome to " + place);
		System.out.println("What would you like to do?");
		System.out.println("1. Inventory");
		System.out.println("Talk to NPC: Bob");
		System.out.println("Store");
	}
 
}
}

Error:

The method main cannot be declared static; static methods can only be declared in a static or top level type

on

public static void main(String[] args)

and

Multiple markers at this line
- Occurrence of 'pmenu'
- Cannot make a static reference to the non-static method pmenu(String) from the type
Player.Roleplaygame

on

pmenu(place);

I see nothing wrong with my code. This is the start of my RPG game code project.

If you're using Eclipse, expand the Source menu and select Format to format (and indent) your code. The little mistake should be quite obvious once you've done so. You'd see:

	public String getplace() {
		return place;
	}
 
	public class Roleplaygame {
 
		public static void main(String[] args) {

This is the nested, inner class that Norm referred to.

The 2 }s are right at the bottom of your code listing, which when properly indented, becomes:

			System.out.println("Store");
		}
 
	}
}

What you might want is to remove one of the 2 }s, and add one } right before public class Roleplaygame { so that you have matching curly braces the Player and Roleplaygame classes, taking RolePlaygame out of being a nested, inner class.

Apart from that, the pmenu(place) call at the bottom of the main method (which is a static method) is not valid because the pmenu method is not static. This is what it meant by Cannot make a static reference to the non-static method pmenu(String) from the type Player.Roleplaygame. One way to rectify this is to make pmenu a static method, i.e., public static void pmenu(String place).

Hth!

Okay, I fixed the problem. However, I added a new method for the Town Menu. I am getting errors

 import java.util.Scanner;
 
 
 
class Player {
	private String name;
	private String gender;
	private String hcolor;
	private String ecolor;
	private String size;
	private String height;
	private String place;
 
	public void setname(String name)
	{
		this.name = name;
	}
	public void setgender (String gender)
	{
		this.gender = gender;
	}
	public void sethcolor (String hcolor)
	{
		this.hcolor=hcolor;
	}
	public void setecolor (String ecolor)
	{
		this.ecolor=ecolor;
	}
	public void setsize (String size)
	{
		this.size = size;
	}
	public void setheight (String height)
	{
		this.height=height;
	}
	public void setplace (String place)
	{
		this.place=place; 
	}
	public String getname()
	{
		return name;
	}
	public String getgender()
	{
		return gender;
	}
	public String gethcolor()
	{
		return hcolor;
	}
	public String getecolor()
	{
		return ecolor;
	}
	public String getsize()
	{
		return size;
	}
	public String getheight()
	{
		return height;
	}
	public String getplace()
	{
		return place;
	}
	public String geteverything()
	{
		System.out.println("Name: " + getname());
		System.out.println("Gender: " + getgender());
		System.out.println("Hair Color: " + gethcolor());
		System.out.println("Eye Color: " + getecolor());
		System.out.println("Size: " + getsize());
		System.out.println("Height: " + getheight());
		pmenu();
	}
 
}
 
 
public class Roleplaygame {
 
	public static void main(String[] args) {
		Player player1 = new Player();
		Scanner scanner = new Scanner (System.in);
		System.out.print("Name: ");
		String name = scanner.nextLine();
		player1.setname(name);
		System.out.print("Gender: ");
		String gender = scanner.next();
        System.out.print("Hair Color: ");
        String hcolor = scanner.next();
        System.out.print("Eye Color: ");
        String ecolor = scanner.next();
        System.out.print("Fat or Skinny: ");
        String size = scanner.next();
        System.out.print("Tall or Short: ");
        String height = scanner.next();
        System.out.print("Name of the town you are going to: ");
        String place = scanner.next();
        System.out.println ("...");
        System.out.println ("...");
        System.out.println ("Welcome to " + player1.getplace());
        pmenu(place);
 
	}
	public static void pmenu(String place)
	{
		Scanner scanner2  = new Scanner (System.in);
		System.out.println("--------------------------");
		System.out.println("Welcome to " + place);
		System.out.println("1. Status");
		System.out.println("2. Inventory");
		System.out.println("3. Talk to NPC: Bob");
		System.out.println("4. Store");
		System.out.println("What would you like to do?");
		int pinput = scanner2.nextInt();
		if (pinput==1)
		{
			player1.geteverything();
		}
 
	}	
}

Errors:

The method pmenu() is undefined for the type Player

on

pmenu();

on public String geteverything();
and

player1 cannot be resolved

on

player1.geteverything();

How could I fix this? Create a new class? Thanks again.

No spelling mistakes... Not sure what is wrong? Is it because of the placement of the code?

Yeah, I put that after observing my code. But it did not fix anything.

Wow, that makes so much sense HAHA (EDIT: NVM. Look at bottom!). There was another solution that I found to this code too: (Turning everything into statics)

import java.util.Scanner;
 
class Player {
	private static String name;
	private static String gender;
	private static String hcolor;
	private static String ecolor;
	private static String size;
	private static String height;
	private static String place;
 
	public void setname(String name)
	{
		this.name = name;
	}
	public void setgender (String gender)
	{
		this.gender = gender;
	}
	public void sethcolor (String hcolor)
	{
		this.hcolor=hcolor;
	}
	public void setecolor (String ecolor)
	{
		this.ecolor=ecolor;
	}
	public void setsize (String size)
	{
		this.size = size;
	}
	public void setheight (String height)
	{
		this.height=height;
	}
	public void setplace (String place)
	{
		this.place=place; 
	}
	public String getname()
	{
		return name;
	}
	public String getgender()
	{
		return gender;
	}
	public String gethcolor()
	{
		return hcolor;
	}
	public String getecolor()
	{
		return ecolor;
	}
	public String getsize()
	{
		return size;
	}
	public String getheight()
	{
		return height;
	}
	public String getplace()
	{
		return place;
	}
	public static void geteverything()
	{
		System.out.println("Name: " + name);
		System.out.println("Gender: " + gender);
		System.out.println("Location: " + place);
		System.out.println("Hair Color: " + hcolor);
		System.out.println("Eye Color: " + ecolor);
		System.out.println("Size: " + size);
		System.out.println("Height: " + height);
	}
 
}
 
 
public class Roleplaygame {
 
	public static void main(String[] args) {
		Player player1 = new Player();
		Scanner scanner = new Scanner (System.in);
		System.out.print("Name: ");
		String name = scanner.nextLine();
		player1.setname(name);
		System.out.print("Gender: ");
		String gender = scanner.next();
		player1.setgender(gender);
        System.out.print("Hair Color: ");
        String hcolor = scanner.next();
        player1.sethcolor(hcolor);
        System.out.print("Eye Color: ");
        String ecolor = scanner.next();
        player1.setecolor(ecolor);
        System.out.print("Fat or Skinny: ");
        String size = scanner.next();
        player1.setsize(size);
        System.out.print("Tall or Short: ");
        String height = scanner.next();
        player1.setheight(height);
        System.out.print("Name of the town you are going to: ");
        String place = scanner.next();
        player1.setplace(place);
        System.out.println ("...");
        System.out.println ("...");
        System.out.println ("Welcome to " + player1.getplace());
        pmenu(place);
 
	}
	public static void pmenu(String place)
	{
		Scanner scanner2  = new Scanner (System.in);
		System.out.println("--------------------------");
		System.out.println("Welcome to " + place);
		System.out.println("1. Status");
		System.out.println("2. Inventory");
		System.out.println("3. Talk to NPC: Bob");
		System.out.println("4. Store");
		System.out.println("What would you like to do?");
		int pinput = scanner2.nextInt();
		if (pinput==1)
		{
			Player.geteverything();
			pmenu(place);
		}
 
	}	
}

This is so very very fascinating!

--- Update ---

Wait, nevermind. The more I look at the code on Post 4, the more I do not understand why it doesn't work... Aside from the small mistakes here and there. I don't see why the Roleplaygame can't locate the pmenu method

I don't see why the Roleplaygame can't locate the pmenu method

On what evidence is that statement made? Post the error.

"Turning everything to statics" is not an appropriate OOP solution. It may serve the Java programmer who has not evolved past the "one class with all code in the main() method" design, but I think you are trying to move to the next level. Understanding the differences between static, non-static, and instance methods and variables is key to making that step successfully, so it's good that you're studying this code for understanding, asking great questions. I recommend that you don't give up until you do understand.

The reason I asked my initial question is because I don't think it's accurate. Review the evidence that caused you to ask that question, post it if you can, and we can discuss it further.

Good luck!

Originally Posted by Mugambbo

Why I believe the Roleplaygame class couldn't locate the pmenu method was because the pmenu method was called even before the method was defined. And as java follows what is called the 'Stack Trace', your app was meant to start executing from top to bottom. I hope this helps.

It doesn't help, because your guess as to the cause and your explanation of your reasoning are not based on Java, its compiler, or the JVM. While some basic IDEs may enforce "source code order is important" rules because they don't know better, it's not a Java requirement.

Please research your theories before posting them. Not only will you learn from the experience, but impressionable students will be spared the task of sorting fact from fiction and the confusion that will likely cause.

Originally Posted by GregBrannon

On what evidence is that statement made? Post the error.

"Turning everything to statics" is not an appropriate OOP solution. It may serve the Java programmer who has not evolved past the "one class with all code in the main() method" design, but I think you are trying to move to the next level. Understanding the differences between static, non-static, and instance methods and variables is key to making that step successfully, so it's good that you're studying this code for understanding, asking great questions. I recommend that you don't give up until you do understand.

The reason I asked my initial question is because I don't think it's accurate. Review the evidence that caused you to ask that question, post it if you can, and we can discuss it further.

Good luck!

Well I fixed the trivial mistakes from post number 4. I ended up with a single error:

 import java.util.Scanner;
 
class Player {
	private String name;
	private String gender;
	private String hcolor;
	private String ecolor;
	private String size;
	private String height;
	private String place;
 
	public void setname(String name)
	{
		this.name = name;
	}
	public void setgender (String gender)
	{
		this.gender = gender;
	}
	public void sethcolor (String hcolor)
	{
		this.hcolor=hcolor;
	}
	public void setecolor (String ecolor)
	{
		this.ecolor=ecolor;
	}
	public void setsize (String size)
	{
		this.size = size;
	}
	public void setheight (String height)
	{
		this.height=height;
	}
	public void setplace (String place)
	{
		this.place=place; 
	}
	public String getname()
	{
		return name;
	}
	public String getgender()
	{
		return gender;
	}
	public String gethcolor()
	{
		return hcolor;
	}
	public String getecolor()
	{
		return ecolor;
	}
	public String getsize()
	{
		return size;
	}
	public String getheight()
	{
		return height;
	}
	public String getplace()
	{
		return place;
	}
	public void geteverything()
	{
		System.out.println("Name: " + getname());
		System.out.println("Gender: " + getgender());
		System.out.println("Hair Color: " + gethcolor());
		System.out.println("Eye Color: " + getecolor());
		System.out.println("Size: " + getsize());
		System.out.println("Height: " + getheight());
		pmenu(place);
	}
 
}
 
 
public class Roleplaygame2 {
 
	public static void main(String[] args) {
		Player player1 = new Player();
		Scanner scanner = new Scanner (System.in);
		System.out.print("Name: ");
		String name = scanner.nextLine();
		player1.setname(name);
		System.out.print("Gender: ");
		String gender = scanner.next();
		player1.setname(gender);
        System.out.print("Hair Color: ");
        String hcolor = scanner.next();
        player1.sethcolor(hcolor);
        System.out.print("Eye Color: ");
        String ecolor = scanner.next();
        player1.setecolor(ecolor);
        System.out.print("Fat or Skinny: ");
        String size = scanner.next();
        player1.setsize(size);
        System.out.print("Tall or Short: ");
        String height = scanner.next();
        player1.setheight(height);
        System.out.print("Name of the town you are going to: ");
        String place = scanner.next();
        player1.setplace(place);
        System.out.println ("...");
        System.out.println ("...");
        System.out.println ("Welcome to " + player1.getplace());
        pmenu(place);
 
	}
	public static void pmenu(String place)
	{
		Scanner scanner2  = new Scanner (System.in);
		Player player1= new Player();
		System.out.println("--------------------------");
		System.out.println("Welcome to " + place);
		System.out.println("1. Status");
		System.out.println("2. Inventory");
		System.out.println("3. Talk to NPC: Bob");
		System.out.println("4. Store");
		System.out.println("What would you like to do?");
		int pinput = scanner2.nextInt();
		if (pinput==1)
		{
			player1.geteverything();
		}
 
	}	
}

The error:

The method pmenu(String) is undefined for the type Player

on

pmenu(place);

in

public void geteverything()

I tried replacing (place) to (getplace()) but it did not work. Still do not understand why roleplaygame can't locate the pmenu. :/

Originally Posted by Norm

Where in the class: Player is the method: pmenu(String) defined?
I see a method with the same name defined in another class: Roleplaygame2

I changed the pmenu to

Roleplaygame2.pmenu(place);

But that just gave me another error:

Multiple markers at this line
- The type Player is already
defined
- Occurrence of 'Player'

Looking at the code, Player type wasn't already defined...

Yes, of course!

import java.util.Scanner;
 
class Player {
	private String name;
	private String gender;
	private String hcolor;
	private String ecolor;
	private String size;
	private String height;
	private String place;
 
	public void setname(String name)
	{
		this.name = name;
	}
	public void setgender (String gender)
	{
		this.gender = gender;
	}
	public void sethcolor (String hcolor)
	{
		this.hcolor=hcolor;
	}
	public void setecolor (String ecolor)
	{
		this.ecolor=ecolor;
	}
	public void setsize (String size)
	{
		this.size = size;
	}
	public void setheight (String height)
	{
		this.height=height;
	}
	public void setplace (String place)
	{
		this.place=place; 
	}
	public String getname()
	{
		return name;
	}
	public String getgender()
	{
		return gender;
	}
	public String gethcolor()
	{
		return hcolor;
	}
	public String getecolor()
	{
		return ecolor;
	}
	public String getsize()
	{
		return size;
	}
	public String getheight()
	{
		return height;
	}
	public String getplace()
	{
		return place;
	}
	public void geteverything()
	{
		System.out.println("Name: " + getname());
		System.out.println("Gender: " + getgender());
		System.out.println("Hair Color: " + gethcolor());
		System.out.println("Eye Color: " + getecolor());
		System.out.println("Size: " + getsize());
		System.out.println("Height: " + getheight());
		Roleplaygame2.pmenu(place);
	}
 
}
 
 
public class Roleplaygame2 {
 
	public static void main(String[] args) {
		Player player1 = new Player();
		Scanner scanner = new Scanner (System.in);
		System.out.print("Name: ");
		String name = scanner.nextLine();
		player1.setname(name);
		System.out.print("Gender: ");
		String gender = scanner.next();
		player1.setname(gender);
        System.out.print("Hair Color: ");
        String hcolor = scanner.next();
        player1.sethcolor(hcolor);
        System.out.print("Eye Color: ");
        String ecolor = scanner.next();
        player1.setecolor(ecolor);
        System.out.print("Fat or Skinny: ");
        String size = scanner.next();
        player1.setsize(size);
        System.out.print("Tall or Short: ");
        String height = scanner.next();
        player1.setheight(height);
        System.out.print("Name of the town you are going to: ");
        String place = scanner.next();
        player1.setplace(place);
        System.out.println ("...");
        System.out.println ("...");
        System.out.println ("Welcome to " + player1.getplace());
        pmenu(place);
 
	}
	public static void pmenu(String place)
	{
		Scanner scanner2  = new Scanner (System.in);
		Player player1= new Player();
		System.out.println("--------------------------");
		System.out.println("Welcome to " + place);
		System.out.println("1. Status");
		System.out.println("2. Inventory");
		System.out.println("3. Talk to NPC: Bob");
		System.out.println("4. Store");
		System.out.println("What would you like to do?");
		int pinput = scanner2.nextInt();
		if (pinput==1)
		{
			player1.geteverything();
		}
 
	}

Error:

Multiple markers at this line
- The type Player is already
defined

on

class Player

Maybe it has something to do with:

Player player1= new Player();

on

public static void pmenu(String place)

?
I feel like it should not be repeated, but putting the player player1 code fixes an error.

The code does run on javac, however...When I go to the Status (Pmenu method) in my code, all the stuff are NULL. like
Name= Null
Gender = Null
Hair Color= Null .....

Compiler error is on Line 2 on Class Player.

I think it has something to do with the double Player player1=new Player() code on both the main class and the pmenu method.

I did in an earlier post:

Multiple markers at this line
- The type Player is already
defined
- Occurrence of 'Player'

That's all it says on the Compiler (Eclipse)

The code runs, but it says there's an

Error existing the project. Proceed with launch?

Javac does not recognize the Error. Perhaps it's just an Eclipse thing? I ran javac on console. No error from that. The code just runs.

--- Update ---

Okay, I managed to fix the NULL problem regarding the Status option in pmenu. Here is my code now:
The error on class Player persist however.
EDIT: NEVERMIND! The Class Player error was because I did not close the Roleplaygame code xD!

However, can you look at my code and see if there is any logic error? Or something that I should not do?

import java.util.Scanner;
 
class Player {
	private String name;
	private String gender;
	private String hcolor;
	private String ecolor;
	private String size;
	private String height;
	private String place;
 
	public void setname(String name)
	{
		this.name = name;
	}
	public void setgender (String gender)
	{
		this.gender = gender;
	}
	public void sethcolor (String hcolor)
	{
		this.hcolor=hcolor;
	}
	public void setecolor (String ecolor)
	{
		this.ecolor=ecolor;
	}
	public void setsize (String size)
	{
		this.size = size;
	}
	public void setheight (String height)
	{
		this.height=height;
	}
	public void setplace (String place)
	{
		this.place=place; 
	}
	public String getname()
	{
		return name;
	}
	public String getgender()
	{
		return gender;
	}
	public String gethcolor()
	{
		return hcolor;
	}
	public String getecolor()
	{
		return ecolor;
	}
	public String getsize()
	{
		return size;
	}
	public String getheight()
	{
		return height;
	}
	public String getplace()
	{
		return place;
	}
	public void geteverything()
	{
		System.out.println("Name: " + getname());
		System.out.println("Gender: " + getgender());
		System.out.println("Hair Color: " + gethcolor());
		System.out.println("Eye Color: " + getecolor());
		System.out.println("Size: " + getsize());
		System.out.println("Height: " + getheight());
	}
 
}
 
 
public class Roleplaygame2 {
 
	public static void main(String[] args) {
		Player player1 = new Player();
		Scanner scanner = new Scanner (System.in);
		System.out.print("Name: ");
		String name = scanner.nextLine();
		player1.setname(name);
		System.out.print("Gender: ");
		String gender = scanner.next();
		player1.setgender(gender);
        System.out.print("Hair Color: ");
        String hcolor = scanner.next();
        player1.sethcolor(hcolor);
        System.out.print("Eye Color: ");
        String ecolor = scanner.next();
        player1.setecolor(ecolor);
        System.out.print("Fat or Skinny: ");
        String size = scanner.next();
        player1.setsize(size);
        System.out.print("Tall or Short: ");
        String height = scanner.next();
        player1.setheight(height);
        System.out.print("Name of the town you are going to: ");
        String place = scanner.next();
        player1.setplace(place);
        System.out.println ("...");
        System.out.println ("...");
        System.out.println ("Welcome to " + player1.getplace());
        pmenu(player1);
 
	}
 
	public static void pmenu(Player player1)
	{
		Scanner scanner2  = new Scanner (System.in);
 
		System.out.println("--------------------------");
		System.out.println("Welcome to " + player1.getplace());
		System.out.println("1. Status");
		System.out.println("2. Inventory");
		System.out.println("3. Talk to NPC: Bob");
		System.out.println("4. Store");
		System.out.println("What would you like to do?");
		int pinput = scanner2.nextInt();
		if (pinput==1)
		{
			player1.geteverything();
			pmenu(player1);
		}
 
	}	
}