Thread: (Binary Tree) Family tree - help with my addChild method

I suspect your if statement bodies are not what you're thinking. Enclose the entire body of each if statement, and see if that helps. Like this:

if ( condition )
{
    // statement 1
 
    // statement 2
 
    // etc . . .
}

Hi, thanks for your reply.
I'm still not any further forward i think I've just been staring at it too long

Post your updated code and describe the new results. Show an actual run, if possible, and describe how the actual outcome varies from what you expect or desire.

Focus on this block of code:

        if (next.sibling!=null)
                next=next.sibling;
                next.sibling=member;        
                if (current.name.compareToIgnoreCase(next.name) == 0)
                    match = true;
                    System.out.println("Name already exists");

The indentation used here is most likely misleading of the intention of the if blocks. The above, when braces are used consistently, is equivalent to

        if (next.sibling!=null) {
            next=next.sibling;
        }
        next.sibling=member;
        if (current.name.compareToIgnoreCase(next.name) == 0) {
            match = true;
        }
        System.out.println("Name already exists");

Is this the logic that is intended here? E.g., next.sibling=member; is run regardless whether (next.sibling!=null) evaluates to true or false?

Thanks for your reply.
Yes, i believe so - it's just so i can have multiple siblings, rather than limit the structure to two kids (child & one sibling)