Thread: Help with Java Program!

Enter package type (A,B, or C): D
Enter number of hours: 2 <--THIS SHOULD NOT SHOW UP, BUT IT STILL DOES
Invalid package type

The code will be executed in the order that it is in. The question: Enter number of hours:
is asked BEFORE the package type is tested.

Enter package type (A,B, or C): A
Enter number of hours: -1
Invalid input. Hours cannot be negative.
Total due: $-12.05 <--THIS SHOULD NOT SHOW UP, BUT IT STILL DOES

If the input is invalid, put out a message and SKIP printing out the Total. An else statement can be used to surround the logic that prints the total.


BTW you should always use {}s after if statements to enclose the block of code in the if.

goes directly to the else statement

I don't see an else statement in the code where you are talking about.

Originally Posted by Norm

I don't see an else statement in the code where you are talking about.

Whoops, my bad. It's under "Default." Towards the end of the program.

For Switch Statements, "Default" acts like an "Else" incase the conditions being tested are all false, right?

       case 'c':
       case 'C':
           monthlyFee = 19.95;
           if (hoursUsed < 744)
           {
             totalFee = monthlyFee;
             System.out.println("Total due:  $" + totalFee);
             break;
           }
           else
           {
             System.out.println("Invalid input. Hours cannot exceed 744.");
             break;
           }
       default:
             System.out.println("Invalid package type");
    }     
  } 
}

For Switch Statements, "Default" acts like an "Else" incase the conditions being tested are all false, right?

Yes.
But isn't the switch statement AFTER where the "Invalid input. Hours cannot be negative." statement is printed?

Something like this?
get user response
if not one of : A, B, C >> print an error message
ELSE get the number of hours and process the valid response

Would this work?

Try it and see what happens.

Can you post the new code that shows the problem?
and the console from when you execute it.

import java.util.Scanner;
 
public class internetPackage
{
  public static void main(String[] args)
  {
    String input;
    char servicePackage;
    int hoursUsed, regularHours, extraHours;
    double monthlyFee, totalFee, extraHoursFee;
 
    // Create a Scanner object for keyboard input.
    Scanner keyboard = new Scanner(System.in);
 
    // Prompt user to choose Internet Service Package.
    System.out.print("Internet Service Provider Monthly Bill\n");
 
    System.out.print("\nEnter package type (A, B, or C):  ");
    input = keyboard.nextLine();
    servicePackage = input.charAt(0);
 
    // Prompt user to enter number of hours.
    System.out.print("Enter number of hours:  ");
    hoursUsed = keyboard.nextInt();
 
    if (servicePackage != 'A' && servicePackage != 'a' && servicePackage != 'B' && servicePackage != 'b' && servicePackage != 'C' && servicePackage != 'c')
    {
      System.out.println("Invalid service package");
    }
    else 
    {
      switch (servicePackage)
      {
         case 'a':
         case 'A':
             monthlyFee = 9.95;
             regularHours = 10;
             if (hoursUsed < 0)
             {
               System.out.println("Invalid input. Hours cannot be negative.");
               break;
             }
             else  if (hoursUsed < regularHours && hoursUsed >=  0)
             {
               totalFee = monthlyFee;
               System.out.println("Total due:  $" + totalFee);
               break;
             }
             else
             {
               extraHours = hoursUsed - regularHours;
               extraHoursFee = extraHours * 2.00;
               totalFee = monthlyFee + extraHoursFee;
               System.out.println("Total due:  $" + totalFee);
               break;
             }
         case 'b':
         case 'B':
             monthlyFee = 13.95;
             regularHours = 20;
             if (hoursUsed < 0)
            { 
               System.out.println("Invalid input. Hours cannot be negative.");
               break;
             }
           else if (hoursUsed < regularHours)
             {
               totalFee = monthlyFee;
               System.out.println("Total due:  $" + totalFee);
               break;
             }
             else
             {
               extraHours = hoursUsed - regularHours;
               extraHoursFee = extraHours * 1.00;
               totalFee = monthlyFee + extraHoursFee;
               System.out.println("Total due:  $" + totalFee);
               break;
             }
         case 'c':
         case 'C':
             monthlyFee = 19.95;
             if (hoursUsed < 0)
             {
               System.out.println("Invalid input. Hours cannot be negative.");
               break;
             }
             else if (hoursUsed < 744)
             {
               totalFee = monthlyFee;
               System.out.println("Total due:  $" + totalFee);
               break;
             }
             else
             {
               System.out.println("Invalid input. Hours cannot exceed 744.");
               break;
             }
         default:
               System.out.println("Invalid package type");
 
      }
      }     
    } 
  }

OUTPUTS:

Internet Service Provider Monthly Bill

Enter package type (A, B, or C): A
Enter number of hours: 3
Total due: $9.95


Internet Service Provider Monthly Bill

Enter package type (A, B, or C): A
Enter number of hours: -1
Invalid input. Hours cannot be negative.


Internet Service Provider Monthly Bill

Enter package type (A, B, or C): A
Enter number of hours: 20
Total due: $29.95


Internet Service Provider Monthly Bill

Enter package type (A, B, or C): D
Enter number of hours: 3
Invalid service package

First 3 output are right, but the 3rd one is still incorrect.

The question about the hours is asked BEFORE the test of package type.
In post#8 I suggested that the test for package type be made BEFORE the hours are requested.

Originally Posted by Norm

The question about the hours is asked BEFORE the test of package type.
In post#8 I suggested that the test for package type be made BEFORE the hours are requested.

It is, right? The program does ask for the service package first, then the number of hours used..Or is the program written in the wrong order in terms of execution of the statements?

public class internetPackage
{
  public static void main(String[] args)
  {
    String input;
    char servicePackage;
    int hoursUsed, regularHours, extraHours;
    double monthlyFee, totalFee, extraHoursFee;
 
    // Create a Scanner object for keyboard input.
    Scanner keyboard = new Scanner(System.in);
 
    // Prompt user to choose Internet Service Package.
    System.out.print("Internet Service Provider Monthly Bill\n");
 
    System.out.print("\nEnter package type (A, B, or C):  ");
    input = keyboard.nextLine();
    servicePackage = input.charAt(0);
 
    // Prompt user to enter number of hours.
    System.out.print("Enter number of hours:  ");
    hoursUsed = keyboard.nextInt();

The way the code is written:
1) If the user enters a letter other than A,B or C and the first line of code will execute: if (servicePackage != 'A' && servicePackage != 'a' and so on).
2) In this case, the user enters 'D.' So, that condition is would be true since D is not equal to A, a, B, b, C, and c. So, the statement "Invalid service package" would display.
3) If the user enters 'A," then the condition would be false because A is actually equal to A or a.
4) Then it prompts to the switch statements regarding the number of hours used.

Does that sound right? I appreciate the help you're providing me, by the way.

--- Update ---

OMG, JUST FIGURED IT OUT! Didn't understand your suggestion, but had it working, anyways. Thanks for your suggestions, though.

I thought that you did NOT want the question: "Enter number of hours: " asked BEFORE the test for valid package type was made.
The posted code always asks the question without any test of package type before asking.

Your list of 4 steps doesn't mention the question: "Enter number of hours: "

Have you solved the problem now?

If not, please explain.