Thread: Find Highest rated movie

import java.io.*;
import java.util.*;
import java.util.StringTokenizer;
 
 
class read
{
 
	public static void main(String[]args)
	{
      populateFilmVector();
 	 bestfilm();
 }
 
 
      static void populateFilmVector(){
     	String movie;
     	  Vector filmList = new Vector();
       try
       {
	     File data       = new File("input.txt");
	     FileReader fr = new FileReader(data);
	     BufferedReader in = new BufferedReader(fr);
 
	     movie = in.readLine();//read first line
		 while(movie!=null)
		 {
		    StringTokenizer tokens = new StringTokenizer(movie,",");
			String title = tokens.nextToken();
			String lead = tokens.nextToken();
            String runTime = tokens.nextToken();
			String rating = tokens.nextToken();
			String id = tokens.nextToken();
 
			filmTest f = new filmTest(title,lead,runTime,Double.parseDouble(rating),id);
			filmList.add((Object)f);
		 	movie = in.readLine();
 
		 }
		 in.close();
 
		}
		catch(IOException e)
		{
			System.out.print("Non-Existant File");
		}
for(int i=0;i<filmList.size();i++)
 
		{
 
			filmTest f = (filmTest)filmList.get(i);
 
				f.displayDetails();
		}
}
 
static void bestfilm()
{
 
 
}
 
 
}

//example using Vectors
import java.util.*;
class filmTest
{
	String title;
	String lead;
	String runTime;
	double rating;
	String id;
 
 
	public filmTest(String n,String l,String r,double s,String i)
	{
		 title=n;
		 lead=l;
		 runTime=r;
		 rating=s;
	     id=i;
//bestfilm(rating);
   }
 
 
public void displayDetails()
	{
		System.out.println("\nFilm title :" + title);
		System.out.println("Lead role :" + lead);
		System.out.println("Run time :" + runTime);
		System.out.println("Rating :" + rating);
		System.out.println("id :" + id);
}
  /* public double bestfilm(double rating)
   {
	  double max=5.0;
	                if ( rating == max)
	                   {
	                       System.out.println("GJHJK");
	                   }
 
for ( int i = 1; i < rating; i++) {
    if ( rating > rating)
    {
      max = rating;
 
	}
 
  }
 
return max;}
 
{
 
}*/
 
}//end class

they are my two java files i want to search thorugh film items and find the one with highest rating have been looking at it for ages with no look would appreciate any help thanks with how to approach or do it thanks

--- Update ---

Film title ain & Gain
Lead role wayne Jhonson
Run time :123
Rating :4.5
id :23415

Film title :2br/1ba
Lead role :Spencer Grammer
Run time :113
Rating :3.2
id :57324

Film title :Training Day
Lead role enzel Washington
Run time :136
Rating :5.0
id :23244

Film title :Lone Surivoe
Lead role :Mark Wahlberg
Run time :141
Rating :4.8
id :45355

Film title :Grown ups 2
Lead role :Adam Sandeler
Run time :98
Rating :4.2
id :13564
Press any key to continue . . .

that is my out put i want this to be out put along with which ever one has the highest rating

ye

could you give me some idea how to do that im looking at this for ages and not getting anywhere

 for (int i = 0;i<filmList.size();i++)
 	{
 
 		filmList(5) = filmList(i);
 
	}

thats what iv done so far just wandering am i going in the right direction or is that wrong

i have it wrong what i want it to do is look at each element and see if its greater than the last to find my highest rating i am getting an error for my loop at the miniute

//************** Error messaage ********************//


C:\Users\Desktop\test\read.java:66: error: cannot find symbol
filmList(5) = filmList(i);
^
symbol: method filmList(int)
location: class read
C:\Users\Desktop\test\read.java:66: error: cannot find symbol
filmList(5) = filmList(i);
^
symbol: method filmList(int)
location: class read

2 errors

Tool completed with exit code 1

cant get my head around it

thanks for the help anyway

Write a method called bestFilm() that searches through the FilmVector and returns the best film based on the ratings. The method should return the Film object

thats exactally what im trying to do when i try to pass the peramiters needed to the other method i get the error that the item cant be found

 
import java.io.*;
import java.util.*;
import java.util.StringTokenizer;
 
class read
{
 
	public static void main(String[]args)
	{
      populateFilmVector();
 	 //bestfilm();
 }
 
 
      static void populateFilmVector(){
     	String movie;
     	  Vector filmList = new Vector();
       try
       {
	     File data       = new File("input.txt");
	     FileReader fr = new FileReader(data);
	     BufferedReader in = new BufferedReader(fr);
 
	     movie = in.readLine();//read first line
		 while(movie!=null)
		 {
		    StringTokenizer tokens = new StringTokenizer(movie,",");
			String title = tokens.nextToken();
			String lead = tokens.nextToken();
            String runTime = tokens.nextToken();
			String rating = tokens.nextToken();
			String id = tokens.nextToken();
 
			filmTest f = new filmTest(title,lead,runTime,Double.parseDouble(rating),id);
			filmList.add((Object)f);
		 	movie = in.readLine();
 
		 }
		 in.close();
 
		}
		catch(IOException e)
		{
			System.out.print("Non-Existant File");
		}
for(int i=0;i<filmList.size();i++)
 
		{
 
			filmTest f = (filmTest)filmList.get(i);
System.out.println(i);
				f.displayDetails();
 
		}
bestfilm(filmlist);
 
}
static void bestfilm(filmlist)
{
for(int i=0;i<filmList.size();i++)
 
		{
 
			filmTest f = (filmTest)filmList.get(rating);
System.out.println(i);
				f.displayDetails();
 
	}
}
 
 
 
 
 
 
}

//*********************ERROR MESSAGE**************************\\

C:\Users\Andrew\Desktop\test\read.java:58: error: <identifier> expected
static void bestfilm(filmlist)
^
1 error

Tool completed with exit code 1

 
import java.io.*;
import java.util.*;
import java.util.StringTokenizer;
 
class read
{
 
	public static void main(String[]args)
	{
      populateFilmVector();
 	 //bestfilm();
 	}
 
      static void populateFilmVector(){
     	String movie;
     	  Vector filmList = new Vector();
       try
       {
	     File data       = new File("input.txt");
	     FileReader fr = new FileReader(data);
	     BufferedReader in = new BufferedReader(fr);
 
	     movie = in.readLine();//read first line
		 while(movie!=null)
		 {
		    StringTokenizer tokens = new StringTokenizer(movie,",");
			String title = tokens.nextToken();
			String lead = tokens.nextToken();
            String runTime = tokens.nextToken();
			String rating = tokens.nextToken();
			String id = tokens.nextToken();
 
			filmTest f = new filmTest(title,lead,runTime,Double.parseDouble(rating),id);
			filmList.add((Object)f);
		 	movie = in.readLine();
		 }
		 in.close();
 		}
		catch(IOException e)
		{
			System.out.print("Non-Existant File");
		}
for(int i=0;i<filmList.size();i++)
		{
				filmTest f = (filmTest)filmList.get(i);
				System.out.println(i);
				f.displayDetails();
		}
bestfilm(filmlist);
}
 
static void bestfilm(List filmlist)
		{
			for(int i=0;i<filmList.size();i++)
				{
					filmTest f = (filmTest)filmList.get(rating);
					System.out.println(i);
					f.displayDetails();
				}
		}
}

i fixed the layou of the {'s still getting error still dont know ho i would do

Write a method called bestFilm() that searches through the FilmVector and returns the best film based on the ratings. The method should return the Film object


would it work if i passed the object f to the bestfilm method ?

Originally Posted by Norm

It's still not right. For example there are }s in the first column in the middle of the code.
The only place a } should be in the first column is at the end of a class's definition.

That error only occurs when I attempt to pass down the list to the method I counted an even
Number of }'s

Is it even possible to find the highest rated film based on rating with the code I have ?
Benn trying it for a while no and getting no where

//example using Vectors
import java.util.*;
class filmTest
{
	String title;
	String lead;
	String runTime;
	double rating;
	String id;
 
 
	public filmTest(String n,String l,String r,double s,String i)
	{
		 title=n;
		 lead=l;
		 runTime=r;
		 rating=s;
	     id=i;
 
   }
 
 
public void displayDetails()
	{
		System.out.println("\nFilm title :" + title);
		System.out.println("Lead role :" + lead);
		System.out.println("Run time :" + runTime + " Mins");
		System.out.println("Rating :" + rating);
		System.out.println("id :" + id);
}
public void bestfilm()
{
 
}
 
 
 
 
 
 
 
 
}//end class

import java.io.*;
import java.util.*;
import java.util.StringTokenizer;
 
class read
{
 
	public static void main(String[]args)
	{
      populateFilmVector();
 	 //bestfilm();
 }
 
 
      static void populateFilmVector(){
     	String movie;
     	  Vector filmList = new Vector();
       try
       {
	     File data       = new File("input.txt");
	     FileReader fr = new FileReader(data);
	     BufferedReader in = new BufferedReader(fr);
 
	     movie = in.readLine();//read first line
		 while(movie!=null)
		 {
		    StringTokenizer tokens = new StringTokenizer(movie,",");
			String title = tokens.nextToken();
			String lead = tokens.nextToken();
            String runTime = tokens.nextToken();
			String rating = tokens.nextToken();
			String id = tokens.nextToken();
 
			filmTest f = new filmTest(title,lead,runTime,Double.parseDouble(rating),id);
			filmList.add((Object)f);
		 	movie = in.readLine();
 
 
		 }
		 in.close();
 
		}
		catch(IOException e)
		{
			System.out.print("Non-Existant File");
		}
for(int i=0;i<filmList.size();i++)
 
		{
				filmTest f = (filmTest)filmList.get(i);
				System.out.println(i);
				f.displayDetails();
		}
 
bestfilm(filmlist);
 
}
 
	static void bestfilm(List filmlist)
		{
			for(int i=0;i<filmList.size();i++)
				{
					filmTest f = (filmTest)filmList.get(rating);
					System.out.println(i);
					f.displayDetails();
				}
		}
}

//*****************************ERROR MESSAGE**********************************\\

C:\Users\Desktop\test\read.java:55: error: cannot find symbol
bestfilm(filmlist);
^
symbol: variable filmlist
location: class read
C:\Users\Desktop\test\read.java:61: error: cannot find symbol
for(int i=0;i<filmList.size();i++)
^
symbol: variable filmList
location: class read
C:\Users\Desktop\test\read.java:63: error: cannot find symbol
filmTest f = (filmTest)filmList.get(rating);
^
symbol: variable rating
location: class read
C:\Users\Desktop\test\read.java:63: error: cannot find symbol
filmTest f = (filmTest)filmList.get(rating);
^
symbol: variable filmList
location: class read
Note: C:\Users\Desktop\test\read.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
4 errors

Tool completed with exit code 1

************************************************** ************
mY FIST BIT OF CODE "FILMtEST COMPILES alright its the second bit of code i put up that has the issue.

what item from the code should i pass to the method bestfilm() in order to
Write a method called bestFilm() that searches through the FilmVector and returns the best film based on the ratings. The method should return the Film object ?.
is this possilbe with my code ?

import java.io.*;
import java.util.*;
import java.util.StringTokenizer;
 
class read
{
 
	public static void main(String[]args)
	{
      populateFilmVector();
 	 //bestfilm();
 }
 
 
      static void populateFilmVector(){
     	String movie;
     	  Vector filmList = new Vector();
       try
       {
	     File data       = new File("input.txt");
	     FileReader fr = new FileReader(data);
	     BufferedReader in = new BufferedReader(fr);
 
	     movie = in.readLine();//read first line
		 while(movie!=null)
		 {
		    StringTokenizer tokens = new StringTokenizer(movie,",");
			String title = tokens.nextToken();
			String lead = tokens.nextToken();
            String runTime = tokens.nextToken();
			String rating = tokens.nextToken();
			String id = tokens.nextToken();
 
			filmTest f = new filmTest(title,lead,runTime,Double.parseDouble(rating),id);
			filmList.add((Object)f);
bestfilm(filmList);
		 	movie = in.readLine();
 
 
		 }
		 in.close();
 
		}
		catch(IOException e)
		{
			System.out.print("Non-Existant File");
		}
for(int i=0;i<filmList.size();i++)
 
		{
				filmTest f = (filmTest)filmList.get(i);
				System.out.println(i);
				f.displayDetails();
		}
 
 
 
}
 
	static void bestfilm(Vector filmList)
{
 
     for(int i=0;i<filmList.size();i++)
 
	 		{
 
 
			}
 
}
}

i have it compiling with the vector passed down
is a for loop the best way to search through the FilmVector and return the best film based on the ratings.?

i have a for loop started just wanst to sure what to write next

import java.io.*;
import java.util.*;
import java.util.StringTokenizer;
 
class read
{
	public static void main(String[]args)
	{
      populateFilmVector();
    }
 
static void populateFilmVector(){
 	String movie;
	Vector filmList = new Vector();
       	try
       		{
	   		  File data       = new File("input.txt");
	   		  FileReader fr = new FileReader(data);
	   		  BufferedReader in = new BufferedReader(fr);
 
	   		  movie = in.readLine();//read first line
		 while(movie!=null)
			 {
			    StringTokenizer tokens = new StringTokenizer(movie,",");
				String title = tokens.nextToken();
				String lead = tokens.nextToken();
       		     String runTime = tokens.nextToken();
				String rating = tokens.nextToken();
				String id = tokens.nextToken();
 
				filmTest f = new filmTest(title,lead,runTime,Double.parseDouble(rating),id);
				filmList.add((Object)f);
bestfilm(filmList);
			 	movie = in.readLine();
 
			 }
		 in.close();
 
		}
		catch(IOException e)
		{
			System.out.print("Non-Existant File");
		}
	for(int i=0;i<filmList.size();i++)
 
		{
				filmTest f = (filmTest)filmList.get(i);
				System.out.println(i);
				f.displayDetails();
		}
}//end method
 
 
static void bestfilm(Vector filmList)//best film method
	{
	     for(int i=0;i<filmList.size();i++)//search through vector
	 		{
                                //whatever to be done in for loop
 
			}
	}//end method
}//end class

The next step i am working on is comparing the rating of each of the films

the best fiml method should compare the rating for each film and display the film with the best rating

"method called bestFilm() that searches through the FilmVector and returns the best film based on the ratings."

//example using Vectors
import java.util.*;
class filmTest
{
	String title;
	String lead;
	String runTime;
	double rating;
	String id;
 
 
	public filmTest(String n,String l,String r,double s,String i)
	{
		 title=n;
		 lead=l;
		 runTime=r;
		 rating=s;
	     id=i;
bestfilm(s);
   }
 
 
public void displayDetails()
	{
		System.out.println("\nFilm title :" + title);
		System.out.println("Lead role :" + lead);
		System.out.println("Run time :" + runTime + " Mins");
		System.out.println("Rating :" + rating);
		System.out.println("id :" + id);
}
public double bestfilm(double s)
{
	if(s >= s)
	{
		/*	System.out.println("Best film based on rating is ");
			System.out.println("-----------------------------------------");
			System.out.println("\nFilm title :" + title);
			System.out.println("Lead role :" + lead);
			System.out.println("Run time :" + runTime + " Mins");
			System.out.println("Rating :" + rating);
			System.out.println("id :" + id);
			System.out.println("-----------------------------------------");*/
	}
	return s;
 
//end class

import java.io.*;
import java.util.*;
import java.util.StringTokenizer;
 
class read
{
	public static void main(String[]args)
	{
      populateFilmVector();
    }
 
static void populateFilmVector(){
 	String movie;
	Vector filmList = new Vector();
       	try
       		{
	   		  File data       = new File("input.txt");
	   		  FileReader fr = new FileReader(data);
	   		  BufferedReader in = new BufferedReader(fr);
 
	   		  movie = in.readLine();//read first line
		 while(movie!=null)
			 {
			    StringTokenizer tokens = new StringTokenizer(movie,",");
				String title = tokens.nextToken();
				String lead = tokens.nextToken();
       		    String runTime = tokens.nextToken();
				String rating = tokens.nextToken();
				String id = tokens.nextToken();
 
				filmTest f = new filmTest(title,lead,runTime,Double.parseDouble(rating),id);
				filmList.add((Object)f);
bestfilm(filmList);
			 	movie = in.readLine();
 
			 }
		 in.close();
 
		}
		catch(IOException e)
		{
			System.out.print("Non-Existant File");
		}
	for(int i=0;i<filmList.size();i++)
 
		{
				filmTest f = (filmTest)filmList.get(i);
				System.out.println(i);
				f.displayDetails();
		}
}//end method
 
 
static void bestfilm(Vector filmList)//best film method
	{
	     for(int i=0;i<filmList.size();i++)//search through vector
	 		{
 
 
			}
 
	}//end method
}//end class

in the first bit of code ther im getting some where i think if i compare "s" to 5.0 it prints out the film with the 5.0 rating

but is the a way to compare the "s" to the variable before it

for example i want to do

    if(s >= s)
       {
          print "s" which would relate to the highest rated film
        }