Thread: Trying to make a Risk game, but I got stuck on the Hand class.

Originally Posted by Norm

Where are the items that are being counted to see if there are three of a kind? Should there be three variables that the code tests the contents of to see if they match?

There is another class (class Player) which draws the cards and holds them. all it does is (riskCards.draw(Card)). So it holds the cards drawn.

Originally Posted by Norm

What does that have to do with coding enum usage?
Post#24 shows a way to use enums.
Rewrite the code in post#23 to use that technique and show what you are trying to do.
Add some comments to document what the code is trying to do.

With the current coding, an arrayList is being created, all I am trying to say with this is if the same enum(Infantry, Artillery, or Calvalry) appear three times in this ArrayList, then the statement is true

Originally Posted by Norm

That sounds like you need a loop to go through the contents of the ArrayList and count the number of times each item appears in the list.

Well managed to get it to iterate through the list to get

Just can't seem to figure out how to test if multiples of say ARTILLERY appears in the hand

  public boolean canTurnInCards(){
 
    for(int i = 0; i < deck.size(); i++){
      deck.get(i);
    }
  }

Originally Posted by Norm

Please post the current version of the code that shows what problem you are having.

package RiskProject;

public class Card{
  //set for the Type of Countries
  public enum Country{ALASKA, ALBERTA, CENTRAL_AMERICA, EASTERN_UNITED_STATES, GREENLAND, NORTHWEST_TERRITORY,
  ONTARIO, QUEBEC, WESTERN_UNITED_STATES, ARGENTINA, BRAZIL, VENEZUELA, GREAT_BRITAIN, ICELAND, NORTHERN_EUROPE,
  SCANDINAVIA, SOUTHER_EUROPE, UKRAINE, WESTERN_EUROPE, CONGO, EAST_AFRICA, EGYPT, MADAGASCAR, NORTH_AFRICA,
  SOUTH_AFRICA, AFGHANISTAN, CHINA, INDIA, IRKUTSK, JAPAN, KAMCHATKA, MIDDLE_EAST, MONGOLIA, SIAM, SIBERIA, URAL,
  YAKUTSK, EASTERN_AUSTRALIA, INDONESIA, LOTR, NEW_GUINEA, WESTERN_AUSTRALIA};
  //set for the Type of cards
  public enum Arms{INFANTRY, ARTILLERY, CALVALRY};
 
  private final Country country;
  private final Arms arms;
 
  public Card(Country country, Arms arms){
 
    this.country = country;
    this.arms = arms;
 
  }
 
  public @Override String toString(){
    return country + "," + arms;
  }
 
  public Arms getArms(){
 
    return arms;
 
  }
 
  public Country getCountry(){
 
    return country;
 
  }
 
}

package RiskProject;
 
import java.util.ArrayList;
import java.util.Collections;
 
public class Deck{
 
 private ArrayList<Card> deck;
 
 Card.Country[] countries = Card.Country.values();
 Card.Arms[] arm = Card.Arms.values(); 
 
 public Deck(){
   deck = new ArrayList<Card>();  
   }
 
 
 
 public Card draw(){
 
   return deck.remove(0);
 
 }
 
 public void add(){
 
   for(Card.Arms arms : arm){
     for(Card.Country country : countries){
       deck.add(new Card(country, arms));
     }
   }
 }
 
 public void shuffle(){
 
   Collections.shuffle(deck);
 
 }
 
 
 
}

package RiskProject;
 
import java.util.ArrayList;
 
public class Hand{
 
  private final ArrayList<Card> deck;
  public int MAXCARDS = 4;
  Card.Arms[] arm = Card.Arms.values();
 
  public Hand(){
    deck = new ArrayList<Card>();
  }
 
  public Card add(Card card){
 
    deck.add(card);
    return card;
 
  }
 
  public Card removeCardsFromHand(int index1, int index2, int index3){
 
    deck.remove(index1);
    deck.remove(index2);
    deck.remove(index3);
    return deck.get(index1);
  }
 
  public boolean canTurnInCards(){
 
    for(int i = 0; i < deck.size(); i++){
      deck.get(i);
    }
  }
 
  public boolean mustTurnInCards(){
    if(deck.size() > MAXCARDS)
      return true;
    else
      return false;
 
  }
 
  public ArrayList<Card> getHand(){
    return deck;
  }
 
}