Trying to make a Risk game, but I got stuck on the Hand class.

**geeksutopia** · April 23rd, 2014, 11:08 PM

package RiskProject;
 
public class Card{
  //set for the Type of Countries
  public enum Country{ALASKA, ALBERTA, CENTRAL_AMERICA, EASTERN_UNITED_STATES, GREENLAND, NORTHWEST_TERRITORY,
  ONTARIO, QUEBEC, WESTERN_UNITED_STATES, ARGENTINA, BRAZIL, VENEZUELA, GREAT_BRITAIN, ICELAND, NORTHERN_EUROPE,
  SCANDINAVIA, SOUTHER_EUROPE, UKRAINE, WESTERN_EUROPE, CONGO, EAST_AFRICA, EGYPT, MADAGASCAR, NORTH_AFRICA,
  SOUTH_AFRICA, AFGHANISTAN, CHINA, INDIA, IRKUTSK, JAPAN, KAMCHATKA, MIDDLE_EAST, MONGOLIA, SIAM, SIBERIA, URAL,
  YAKUTSK, EASTERN_AUSTRALIA, INDONESIA, LOTR, NEW_GUINEA, WESTERN_AUSTRALIA};
  //set for the Type of cards
  public enum Arms{INFANTRY, ARTILLERY, CALVALRY};
 
  private final Country country;
  private final Arms arms;
 
  public Card(Country country, Arms arms){
 
    this.country = country;
    this.arms = arms;
 
  }
 
  public @Override String toString(){
    return country + "," + arms;
  }
 
  public Arms getArms(){
 
    return arms;
 
  }
 
  public Country getCountry(){
 
    return country;
 
  }
 
}

package RiskProject;
 
import java.util.ArrayList;
import java.util.Collections;
 
public class Deck{
 
 public ArrayList<Card> deck;
 
 Card.Country[] countries = Card.Country.values();
 Card.Arms[] arm = Card.Arms.values(); 
 
 public Deck(){
   deck = new ArrayList<Card>();  
   }
 
 
 
 public Card draw(){
 
   return deck.remove(0);
 
 }
 
 public void add(){
 
   for(Card.Arms arms : arm){
     for(Card.Country country : countries){
       deck.add(new Card(country, arms));
     }
   }
 }
 
 public void shuffle(){
 
   Collections.shuffle(deck);
 
 }
 
 
 
}

package RiskProject;
 
import java.util.ArrayList;
 
public class Hand{
 
  private final ArrayList<Card> deck;
 
  public Hand(){
    deck = new ArrayList<Card>();
  }
 
  public Card add(Card card){
 
    deck.add(card);
    return card;
 
  }
 
  public Card removeCardsFromHand(int index1, int index2, int index3){
 
    deck.remove(index1, index2, index3);//The method remove(int) in the type java.util.ArrayList<RiskProject.Card> is not applicable for the arguments(int, int, int)
    return deck;
 
  }
 
  public boolean canTurnInCards(){
 
  }
 
  public boolean mustTurnInCards(){
 
  }
 
  public ArrayList<Card> getHand(){
 
  }
 
}

**GregBrannon** · April 24th, 2014, 05:09 AM

Please describe why you're stuck and ask a specific question. Post errors, undesired results, etc.

**geeksutopia** · April 24th, 2014, 08:57 AM

Originally Posted by GregBrannon

Please describe why you're stuck and ask a specific question. Post errors, undesired results, etc.

The error is posted in the Hand class, I am stuck on the the remove cards from hand method. Just can't seem to figure out what to do here

**Norm** · April 24th, 2014, 09:11 AM

The method remove(int) in the type java.util.ArrayList<RiskProject.Card> is not applicable for the arguments(int, int, int)

The ArrayList class's remove() method is defined to take one int as its argument. The code is trying to call that method with 3 int values.
Can the code be changed to call the remove() method with a single int as arg? Perhaps call it three times, once with each int.

**geeksutopia** · April 24th, 2014, 10:00 AM

Originally Posted by Norm

The ArrayList class's remove() method is defined to take one int as its argument. The code is trying to call that method with 3 int values.
Can the code be changed to call the remove() method with a single int as arg? Perhaps call it three times, once with each int.

Just implemented that and it compiles. Now the return statement is giving me problems.

public Card removeCardsFromHand(int index1, int index2, int index3){
              deck.remove(index1);
              deck.remove(index2);
              deck.remove(index3);
              return deck;//Type mismatch cannot convert from java.util.ArrayList<RiskProject.Card> to RiskProject.Card
}

**Norm** · April 24th, 2014, 10:09 AM

public Card removeCardsFromHand(

The method says that it is going to return an instance of the Card class.
Is that what it is supposed to return?

The code is trying to return an ArrayList. The method does not create any objects, so it should not be returning anything. It updates an existing object: deck that is globally available to any other methods in the class.

What should happen to the 3 Card objects that were removed from the deck?

**geeksutopia** · April 24th, 2014, 10:17 AM

Originally Posted by Norm

public Card removeCardsFromHand(

The method says that it is going to return an instance of the Card class.
Is that what it is supposed to return?

The code is trying to return an ArrayList. The method does not create any objects, so it should not be returning anything. It updates an existing object: deck that is globally available to any other methods in the class.

What should happen to the 3 Card objects that were removed from the deck?

It's supposed to return an instance of the Card class, sort of what is in your hand now, The three cards that get removed are gone completely.

**Norm** · April 24th, 2014, 10:26 AM

It's supposed to return an instance of the Card class, sort of what is in your hand now

If there are more than one card in the hand after removing 3 cards from deck, which card is it supposed to return?

**geeksutopia** · April 24th, 2014, 10:33 AM

Originally Posted by Norm

public Card removeCardsFromHand(

The method says that it is going to return an instance of the Card class.
Is that what it is supposed to return?

The code is trying to return an ArrayList. The method does not create any objects, so it should not be returning anything. It updates an existing object: deck that is globally available to any other methods in the class.

What should happen to the 3 Card objects that were removed from the deck?

found out the answer to the return statement which is "return deck.get(index1);" which compiles correctly.

Working on the canTurnInCards statement which I am using

Card.Arms[]arm = Card.Arms.values();

And seeing how that this:

public boolean canTurnInCards(){
  if(INFANTRY == 3){
      return true;
  }
}

It says that the use of CALVALRY cannot be resolved to a variable
Same with INFANTRY or ARTILLERY

**Norm** · April 24th, 2014, 10:46 AM

Try adding on the name of the enum.

**geeksutopia** · April 24th, 2014, 11:02 AM

Originally Posted by Norm

Try adding on the name of the enum.

The name of the enum is Arms, which I instantiated with

Card.Arms[] arm = Card.Arms.values();

And tried putting it into practice in the boolean using

if(arm.values(INFANTRY) == 3){
  return true;
}

**Norm** · April 24th, 2014, 11:27 AM

Did you try: Arms.INFANTRY

**geeksutopia** · April 24th, 2014, 12:05 PM

Originally Posted by Norm

Did you try: Arms.INFANTRY

Tried it, and nothing. Got an Arms cannot be resolved to a variable

**Norm** · April 24th, 2014, 12:22 PM

Can you post a small, simple, complete program that shows the problem?
Something that will compile when the problem is fixed.

**geeksutopia** · April 24th, 2014, 12:27 PM

Originally Posted by Norm

Can you post a small, simple, complete program that shows the problem?
Something that will compile when the problem is fixed.

package RiskProject;
 
import java.util.ArrayList;
 
public class Hand{
 
  private final ArrayList<Card> deck;
  public int MAXCARDS = 4;
  Card.Arms[] arm = Card.Arms.values();
 
  public Hand(){
    deck = new ArrayList<Card>();
  }
 
  public Card add(Card card){
 
    deck.add(card);
    return card;
 
  }
 
  public Card removeCardsFromHand(int index1, int index2, int index3){
 
    deck.remove(index1);
    deck.remove(index2);
    deck.remove(index3);
    return deck.get(index1);
  }
 
  public boolean canTurnInCards(){
 
    if(Arms.INFANTRY == 3){
      return true;
    }
    else if(ARTILLERY == 3){
      return true;
    }
    else if(CALVALRY == 3){
      return true;
    }
    else if(ARTILLERY == 1 && Infantry == 1 && CALVALRY == 1){
      return true;
    }
 
  }
 
  public boolean mustTurnInCards(){
    if(deck.size() > MAXCARDS)
      return true;
    else
      return false;
 
  }
 
  public ArrayList<Card> getHand(){
    return deck;
  }
 
}

This mixed in with the other two classes in the post should compile

**Norm** · April 24th, 2014, 12:33 PM

Sorry, I'd prefer ONE file for testing, not two or three or whatever is needed.
It shouldn't take over 20 lines of code.

Also post the full text of the compiler's error message when you try to compile it.

**geeksutopia** · April 24th, 2014, 12:43 PM

Originally Posted by Norm

Sorry, I'd prefer ONE file for testing, not two or three or whatever is needed.
It shouldn't take over 20 lines of code.

Also post the full text of the compiler's error message when you try to compile it.

6 errors found:
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\Hand. java [line: 32]
Error: Arms cannot be resolved to a variable
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\Hand. java [line: 35]
Error: ARTILLERY cannot be resolved to a variable
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\Hand. java [line: 38]
Error: CALVALRY cannot be resolved to a variable
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\Hand. java [line: 41]
Error: ARTILLERY cannot be resolved to a variable
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\Hand. java [line: 41]
Error: Infantry cannot be resolved to a variable
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\Hand. java [line: 41]
Error: CALVALRY cannot be resolved to a variable

This is the error I get when I try to compile, the only file that is wrong is the Hand class, the other two run perfectly

**Norm** · April 24th, 2014, 12:57 PM

Where is the code that generates those error messages?

Can you post a small, simple, complete program that shows the problem?
Something that will compile when the problem is fixed.

**geeksutopia** · April 24th, 2014, 01:10 PM

Originally Posted by Norm

Where is the code that generates those error messages?

Can you post a small, simple, complete program that shows the problem?
Something that will compile when the problem is fixed.

package RiskProject;
 
import java.util.ArrayList;
 
public class HandTest{
 
 
 
  Card.Arms[] arm = Card.Arms.values();
 
  public HandTest(){
 
  }
 
  public boolean canTurnInCards(){
 
    if(arm.INFANTRY == 3){
      return true;
    }
  }
}

This should compile when fixed. The error for it is

INFANTRY cannot be resolved or is not a field.

**Norm** · April 24th, 2014, 01:17 PM

That code doesn't compile. These are its errors:

Running: D:\Java\jdk1.7.0_45\bin\javac.exe -cp . -Xlint HandTest.java

HandTest.java:8: error: package Card does not exist
Card.Arms[] arm = Card.Arms.values();
^
HandTest.java:8: error: package Card does not exist
Card.Arms[] arm = Card.Arms.values();
^
2 errors

2 error(s)

**geeksutopia** · April 24th, 2014, 01:25 PM

Originally Posted by Norm

That code doesn't compile. These are its errors:

The reason for those errors is cause the class Card and the class HandTest are in the same package.

**Norm** · April 24th, 2014, 01:27 PM

I don't have any packages for testing forum code. That's why I'd like all the code in one file for testing.

    if(arm.INFANTRY == 3){

arm is an array and does not have a field named: INFANTRY
To access the contents of an array use array notation: []
arm[0] would be the first element in the array.

I have no idea what that if statement could be testing for.
With most enum usage you don't compare the enum's value to an int. That would conflict with the purpose of using enums: Use names as values for a type. For example: INFANTRY is a value for type Arms

**geeksutopia** · April 24th, 2014, 01:44 PM

Originally Posted by Norm

I don't have any packages for testing forum code. That's why I'd like all the code in one file for testing.

    if(arm.INFANTRY == 3){

arm is an array and does not have a field named: INFANTRY
To access the contents of an array use array notation: []
arm[0] would be the first element in the array.

I have no idea what that if statement could be testing for.
With most enum usage you don't compare the enum's value to an int. That would conflict with the purpose of using enums: Use names as values for a type. For example: INFANTRY is a value for type Arms

 
 
import java.util.ArrayList;
 
public class HandTest{
 
  public enum Arms{INFANTRY, ARTILLERY, CALVALRY};
 
  private final Arms arms;
 
  public HandTest(Arms arms){
    this.arms = arms;
  }
  public @Override String toString(){
    return "Card" + arms;
  }
  public Arms getArms(){
    return arms;
  }
 
  public boolean canTurnInCards(){
    if(arms.INFANTRY == 3){
      return true;
    }
    else if(arms.ARTILLERY == 3){
      return true;
    }
    else if(arms.CALVALRY == 3){
      return true;
    }
    else if(arms.INFANTRY == 1 && arms.ARTILLERY == 1 && arms.CALVALRY == 1){
      return true;
    }
    else
      return false;
  }
}
}

12 errors and 6 warnings found:
--------------
*** Errors ***
--------------
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\Hand. java [line: 32]
Error: Arms cannot be resolved to a variable
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\Hand. java [line: 35]
Error: ARTILLERY cannot be resolved to a variable
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\Hand. java [line: 38]
Error: CALVALRY cannot be resolved to a variable
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\Hand. java [line: 41]
Error: ARTILLERY cannot be resolved to a variable
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\Hand. java [line: 41]
Error: Infantry cannot be resolved to a variable
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\Hand. java [line: 41]
Error: CALVALRY cannot be resolved to a variable
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\HandT est.java [line: 22]
Error: Incompatible operand types HandTest.Arms and int
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\HandT est.java [line: 25]
Error: Incompatible operand types HandTest.Arms and int
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\HandT est.java [line: 28]
Error: Incompatible operand types HandTest.Arms and int
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\HandT est.java [line: 31]
Error: Incompatible operand types HandTest.Arms and int
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\HandT est.java [line: 31]
Error: Incompatible operand types HandTest.Arms and int
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\HandT est.java [line: 31]
Error: Incompatible operand types HandTest.Arms and int
--------------
** Warnings **
--------------
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\HandT est.java [line: 22]
Warning: The static field HandTest.Arms.INFANTRY should be accessed in a static way
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\HandT est.java [line: 25]
Warning: The static field HandTest.Arms.ARTILLERY should be accessed in a static way
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\HandT est.java [line: 28]
Warning: The static field HandTest.Arms.CALVALRY should be accessed in a static way
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\HandT est.java [line: 31]
Warning: The static field HandTest.Arms.INFANTRY should be accessed in a static way
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\HandT est.java [line: 31]
Warning: The static field HandTest.Arms.ARTILLERY should be accessed in a static way
File: C:\Users\Carlos Satres\Documents\SystemandDesign\RiskProject\HandT est.java [line: 31]
Warning: The static field HandTest.Arms.CALVALRY should be accessed in a static way

What I am trying to do is that if there are multiples of the same arms (like three cards of the same type) I can trade them in

**Norm** · April 24th, 2014, 01:53 PM

The enum is spelled: with A not a- Arms not arms.

Why does the code try to compare an enum to an int?

This code compiles:

    if(Arms.INFANTRY == arms){

**geeksutopia** · April 24th, 2014, 02:07 PM

Originally Posted by Norm

The enum is spelled: with A not a- Arms not arms.

Why does the code try to compare an enum to an int?

This code compiles:

    if(Arms.INFANTRY == arms){

but wait shouldn't it be if there are three of a kind, the statement is true.

Thread: Trying to make a Risk game, but I got stuck on the Hand class.

LinkBack

Thread Tools

Display

Trying to make a Risk game, but I got stuck on the Hand class.

Related threads:

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Re: Trying to make a Risk game, but I got stuck on the Hand class.

Similar Threads

I've created a slideshow using ViewPager, need to make a 3 small changes but stuck

need to make basic class and implementation class (base class without void main)

I'm stuck on my Camelot game

I need a hand in editing this game

typing game stuck up

Tags for this Thread