Not getting the right outputs.

**DarkestLord** · May 15th, 2014, 02:10 PM

I'm making an armor class. I also made a test for it to ensure it works, but something seems to be wrong. I'm not getting the expect outputs when I ask it to give me a println of the variables.

This is the armor class:

import java.util.Random;
public class Armor
{
//fields
 
CharacterRace charRace;
String armorName;
public int cost;
public int armorBonus;
public int armorCheckPenalty;
public int arcaneSpellFailChance;
public int speedFast;
public int speedSlow;
public int weight;
 
//initialize
public Armor(String armorName, int cost, int armorBonus, int armorCheckPenalty, int arcaneSpellFailChance, int speedFast, int speedSlow, int weight){
this.armorName=armorName;
cost=cost;
armorBonus=armorBonus;
armorCheckPenalty=armorCheckPenalty;
arcaneSpellFailChance=arcaneSpellFailChance;
speedFast=speedFast;
speedSlow=speedSlow;
weight=weight;
}
public int getSpeed(CharacterRace charRace)
{
int total=0;
if(charRace==CharacterRace.HUMAN){
total=speedFast;
}else if(charRace==CharacterRace.ELF){
total=speedFast;
}else if(charRace==CharacterRace.HALFELF){
total=speedFast;
}else if(charRace==CharacterRace.HALFORC){
total=speedFast;
}else if(charRace==CharacterRace.DWARVE){
total=speedSlow;
}else if(charRace==CharacterRace.GNOME){
total=speedSlow;
}else if(charRace==CharacterRace.HALFLING){
total=speedSlow;
}
return total;
}
public boolean arcaneSpellFailed()
{
Random rand= new Random ();
int spellnumber=rand.nextInt(100)+1;
boolean spellsuccess=true;
if(spellnumber<arcaneSpellFailChance){
spellsuccess=false;
}
return spellsuccess;
}
 
//methods
}

This is the armor test:

public class ArmorTester
{
public static void main(String[] args)
{
Armor myLeather = new Armor( "Leather", 10, 2, 0, 10, 30, 20, 15);
Armor myChainmail = new Armor( "Chainmail", 150, 6, 5, 30, 20, 15, 40);
Armor myPlate = new Armor( "Full Plate", 1500, 9, 6, 35, 20, 15, 50);
System.out.println(myLeather.getSpeed(CharacterRace.HUMAN));
System.out.println(myChainmail.getSpeed(CharacterRace.HALFORC));
System.out.println(myPlate.getSpeed(CharacterRace.GNOME));
System.out.println( myLeather.arcaneSpellFailed());
System.out.println( myChainmail.arcaneSpellFailed());
System.out.println( myPlate.arcaneSpellFailed());
}
}

And this is the CharacterRace class enum:

public enum CharacterRace
{
    HUMAN, ELF, HALFELF, HALFORC, DWARVE, GNOME, HALFLING
}//end enum

And lastly, this is what the armor test prints out:

0
0
0
true
true
true

I never get false (I should sometimes) and those 0s should be

30
30
15

What's wrong with my code?

**Norm** · May 15th, 2014, 03:06 PM

The println()s should include an ID String so you can find which println() printed which line of output:
System.out.println("theVar= "+ theVar);

BTW The posted code has lost its formatting. Nested statements are not indented which makes the code hard to read.

**DarkestLord** · May 15th, 2014, 03:30 PM

I'm assuming you mean change the test, so as to understand what variables are being shown. I got this as my output

Leather Speed: 0
Chainmail Speed: 0
Full Plate Speed: 0
Leather arcane spell succuss: true
Chainmail arcane spell succuss: true
Full Plate arcane spell succuss: true

Still shouldn't be the case.

**Norm** · May 15th, 2014, 03:37 PM

The posted code has lost its formatting. Nested statements are not indented which makes the code hard to read.
Can you fix the formatting of the code?

Try debugging the code by adding some println statements that print out the values of the variables used in the if statements and passed to the method.

Also add an else at the end of the if/else if chain that prints out a message saying that none of the preceding if statements were true.

**aussiemcgr** · May 15th, 2014, 03:42 PM

Your mistake is that your constructor's parameter names are the same as your class variable names. Java looks at variables with the closest scope. So when you say:

cost = cost;

You are assigning the parameter variable to itself. You are NOT modifying the class variable. To modify the class variable, use the "this" keyword:

this.cost = cost;

Also, fun fact: since you are using Enums in your getSpeed() method, you can actually clean it up quite nicely using something called a switch statement.
Here is a comparison of your code:

public int getSpeed(CharacterRace charRace)
{
	int total=0;
	if(charRace==CharacterRace.HUMAN){
		total=speedFast;
	}else if(charRace==CharacterRace.ELF){
		total=speedFast;
	}else if(charRace==CharacterRace.HALFELF){
		total=speedFast;
	}else if(charRace==CharacterRace.HALFORC){
		total=speedFast;
	}else if(charRace==CharacterRace.DWARVE){
		total=speedSlow;
	}else if(charRace==CharacterRace.GNOME){
		total=speedSlow;
	}else if(charRace==CharacterRace.HALFLING){
		total=speedSlow;
	}
	return total;
}

verse a switch statement which produces the same result:

public int getSpeed(CharacterRace charRace) {
	int total = 0;
	switch(charRace) {
		case HUMAN:
		case ELF:
		case HALFELF:
		case HALFORC:
			total = speedFast;
			break;
		case DWARVE:
		case GNOME:
		case HALFLING:
			total = speedSlow;
			break;
	}
	return total;
}

The main advantage to the switch statement is that it allows you to compress all of those if/else clauses into a quick and easy-to-read list of condition statements.

Thread: Not getting the right outputs.

LinkBack

Thread Tools

Display

Not getting the right outputs.

Related threads:

Re: Not getting the right outputs.

Re: Not getting the right outputs.

Re: Not getting the right outputs.

Re: Not getting the right outputs.

Similar Threads

MuliThreading Unable to get outputs but many NPES.....

Help, text reader outputs high count value!

Why do I get 0 in the outputs?

Code only outputs 1's

LinkedList outputs ONLY last element