Thread: TicTactoe program on BlueJ

I'm currently writing this TicTacToe program on BlueJ.....and for some reason the while loop in the main method runs infinitely

import java.util.Scanner;
 
public class TicTacToe
{
 
    public static void main()
    {
        Board game = new Board();
        Scanner getPosition = new Scanner(System.in);
        Scanner getPlayer = new Scanner(System.in);
 
 
        while(game.getSentinel() < 1){
            System.out.println("Enter Position:");
            int pos = getPosition.nextInt();
 
            System.out.println("Enter Player:");
            String player = getPlayer.nextLine();
 
            game.assignMove(player, pos);
            game.checkForWin();
 
            System.out.println(game.getValue(pos));
            System.out.println(game.printWinner()+ " wins");
 
 
 
        }
 
 
    }
 
}

public class Board //implements BoardUI
{
 
    private String[][] board = new String[3][3];
    private String winner = "No player";
    private int sentinel = 0;
 
 
 
    public Board()
    {
 
    }
 
    public String getValue(int position)
    {
         if(position ==1){
           return board[0][0];
        }
        if(position ==2){
           return board[0][1];
        }
        if(position ==3){
          return board[0][2];
        }
        if(position ==4){
           return board[1][0];
        }
        if(position ==5){
           return board[1][1];
        }
        if(position ==6){
          return board[1][2];
        }
        if(position ==7){
           return board[2][0];
        }
        if(position ==8){
           return board[2][1];
        }
        if(position ==9){
           return board[2][2];
        }
        else{
             return "";
        }
    }
 
    public int getSentinel()
    {
       return sentinel;
    }
    public void assignMove(String value, int position)
    {
        if(position ==1){
           board[0][0] = value;
        }
        if(position ==2){
           board[0][1] = value;
        }
        if(position ==3){
           board[0][2] = value;
        }
        if(position ==4){
           board[1][0] = value;
        }
        if(position ==5){
           board[1][1] = value;
        }
        if(position ==6){
           board[1][2] = value;
        }
        if(position ==7){
           board[2][0] = value;
        }
        if(position ==8){
           board[2][1] = value;
        }
        if(position ==9){
           board[2][2] = value;
        }
 
    }
 
    public String printWinner()
    {
       return winner;
    }
 
    public void checkForWin()
    {
        if
        ( 
        ((board[0][0]=="x") &&(board[0][1]=="x") && (board[0][2]=="x")) ||
        ((board[1][0]=="x") &&(board[1][1]=="x") && (board[1][2]=="x")) ||     
        ((board[2][0]=="x") &&(board[2][1]=="x") && (board[2][2]=="x")) ||
 
        ((board[0][0]=="x") &&(board[1][0]=="x") && (board[2][0]=="x")) ||
        ((board[1][0]=="x") &&(board[1][1]=="x") && (board[2][1]=="x")) ||
        ((board[0][2]=="x") &&(board[1][2]=="x") && (board[2][2]=="x")) ||
 
        ((board[0][0]=="x") &&(board[1][1]=="x") && (board[2][2]=="x")) ||
        ((board[0][2]=="x") &&(board[1][1]=="x") && (board[2][0]=="x")) 
 
        )
        {
         winner = "Player 1";   
         sentinel= 1;
        }
 
       if
        ( 
        ((board[0][0]=="o") &&(board[0][1]=="o") && (board[0][2]=="o")) ||
        ((board[1][0]=="o") &&(board[1][1]=="o") && (board[1][2]=="o")) ||     
        ((board[2][0]=="o") &&(board[2][1]=="o") && (board[2][2]=="o")) ||
 
        ((board[0][0]=="o") &&(board[1][0]=="o") && (board[2][0]=="o")) ||
        ((board[1][0]=="o") &&(board[1][1]=="o") && (board[2][1]=="o")) ||
        ((board[0][2]=="o") &&(board[1][2]=="o") && (board[2][2]=="o")) ||
 
        ((board[0][0]=="o") &&(board[1][1]=="o") && (board[2][2]=="o")) ||
        ((board[0][2]=="o") &&(board[1][1]=="o") && (board[2][0]=="o")) 
 
        )
        {
         winner = "Player 2";
         sentinel= 1;
        }
 
 
    }
}

the code works fine when I ran tests with this segment of code in the main method

       game.assignMove("o",1);
        game.assignMove("o",4);
        game.assignMove("o",7);
 
        System.out.println(game.getValue(0,0));
        System.out.println(game.getValue(1,0));
        System.out.println(game.getValue(2,0));
        game.checkForWin();
        System.out.println(game.printWinner());
        System.out.println(game.getSentinel());

NOTE:
the positions on the board
1|2|3|
------
4|5|6|
------
7|8|9|

You can ignore the advice given or take it. If you don't understand what someone is trying to tell you, then please ask for clarification.

Originally Posted by GregBrannon

You can ignore the advice given or take it. If you don't understand what someone is trying to tell you, then please ask for clarification.

okay.

--- Update ---

Originally Posted by copeg

A quick glance at your code: use the equals() method of the String class to check for String equality. Suggested reading: http://www.javaprogrammingforums.com...html#post18725

I used the equals() method, then I had some nullpointer error which i fixed in the constructor. Thanks

public class Board implements BoardUI
{
 
    private String[][] board = new String[3][3];
    private String winner = "No player";
    private int sentinel = 0;
 
 
 
    public Board()
    {
        board[0][0] = "";
        board[0][1] ="";
        board[0][2] = "";
        board[1][0] = "";
        board[1][1] = "";
        board[1][2] = "";
        board[2][0] = "";
        board[2][1] = "";
        board[2][2] = "";
    }
 
    public String getValue(int position)
    {
         if(position ==1){
           return board[0][0];
        }
        if(position ==2){
           return board[0][1];
        }
        if(position ==3){
          return board[0][2];
        }
        if(position ==4){
           return board[1][0];
        }
        if(position ==5){
           return board[1][1];
        }
        if(position ==6){
          return board[1][2];
        }
        if(position ==7){
           return board[2][0];
        }
        if(position ==8){
           return board[2][1];
        }
        if(position ==9){
           return board[2][2];
        }
        else{
             return "";
        }
    }
 
    public int getSentinel()
    {
       return sentinel;
    }
    public void assignMove(String value, int position)
    {
        if(position ==1){
           board[0][0] = value;
        }
        if(position ==2){
           board[0][1] = value;
        }
        if(position ==3){
           board[0][2] = value;
        }
        if(position ==4){
           board[1][0] = value;
        }
        if(position ==5){
           board[1][1] = value;
        }
        if(position ==6){
           board[1][2] = value;
        }
        if(position ==7){
           board[2][0] = value;
        }
        if(position ==8){
           board[2][1] = value;
        }
        if(position ==9){
           board[2][2] = value;
        }
 
    }
 
    public String printWinner()
    {
       return winner;
    }
 
    public void checkForWin()
    {
        if
        ( 
        ((board[0][0].equals("x")) &&(board[0][1].equals("x")) && (board[0][2].equals("x"))) ||
        ((board[1][0].equals("x")) &&(board[1][1].equals("x")) && (board[1][2].equals("x"))) ||     
        ((board[2][0].equals("x")) &&(board[2][1].equals("x")) && (board[2][2].equals("x"))) ||
 
        ((board[0][0].equals("x")) &&(board[1][0].equals("x")) && (board[2][0].equals("x"))) ||
        ((board[1][0].equals("x")) &&(board[1][1].equals("x")) && (board[2][1].equals("x"))) ||
        ((board[0][2]=="x") &&(board[1][2]=="x") && (board[2][2]=="x")) ||
 
        ((board[0][0].equals("x")) &&(board[1][1].equals("x")) && (board[2][2].equals("x"))) ||
        ((board[0][2].equals("x")) &&(board[1][1].equals("x")) && (board[2][0].equals("x"))) 
 
        )
        {
         winner = "Player 1";   
         sentinel= 1;
        }
 
       if
        ( 
        ((board[0][0].equals("o")) &&(board[0][1].equals("o")) && (board[0][2].equals("o"))) ||
        ((board[1][0].equals("o")) &&(board[1][1].equals("o")) && (board[1][2].equals("o"))) ||     
        ((board[2][0].equals("o")) &&(board[2][1].equals("o")) && (board[2][2].equals("o"))) ||
 
        ((board[0][0].equals("o")) &&(board[1][0].equals("o")) && (board[2][0].equals("o"))) ||
        ((board[1][0].equals("o")) &&(board[1][1].equals("o")) && (board[2][1].equals("o"))) ||
        ((board[0][2].equals("o")) &&(board[1][2].equals("o")) && (board[2][2].equals("o"))) ||
 
        ((board[0][0].equals("o")) &&(board[1][1].equals("o")) && (board[2][2].equals("o"))) ||
        ((board[0][2].equals("o")) &&(board[1][1].equals("o")) && (board[2][0].equals("o"))) 
 
        )
        {
         winner = "Player 2";
         sentinel= 1;
        }
 
 
    }
}