Thread: Broken loop - number guessing game.

I know I'm not the first to post this, but I've spent hours scouring other people's code, and I can't figure out what's wrong with mine. It says 'you win' even when I guess an incorrect number. And then the 'win' message keeps repeating. I'm thinking I need a way to generate a new input? And then maybe take the 'win' message out of the loop, but that breaks it too. Help?

Screen Shot 2014-06-03 at 8.03.55 AM.jpg

Oh since that screen shot wants to be tiny, here's the text:

/**
* Emily Caraballo's Guess a Number Game, v1.0
*/

import javax.swing.JOptionPane;
import java.util.Random;

public class GuessNumber
{
public static void main(String[] args)
{
Random rand = new Random();
int randomNo = rand.nextInt(100) + 1; // Random Number Generated
int guess; // Number user Guesses
int attempts = 0; // Number of guesses

guess = Integer.parseInt(JOptionPane.showInputDialog(null, "Enter a number 1-100"));
attempts++;

while (guess !=randomNo) {

if (guess < randomNo)
{
JOptionPane.showInputDialog(null, "Too low sucker! Guess a higher number.");
}

else if (guess < randomNo)
{
JOptionPane.showInputDialog(null, "Woah! Guess a lower number.");
}

else if (guess <1 || guess >100)
{
JOptionPane.showInputDialog(null, "Really? Did You read the instructions? " +
"That number is not between 1-100, guess again.");
}


JOptionPane.showMessageDialog(null, "You win!");
JOptionPane.showMessageDialog(null, "The number was " + randomNo);
JOptionPane.showMessageDialog(null, "You guessed in " + attempts + " tries.");
}

} // end main
} // end class GuessNumber

Welcome to the Forum! Please read this topic to learn how to post code correctly and other useful tips for newcomers.

Please post your code correctly per the above link.

Thanks Greg & Norm, this looks much better.

/** 
 * Emily Caraballo's Guess a Number Game, v1.0
 */
 
import javax.swing.JOptionPane;
import java.util.Random;
 
public class GuessNumber
{
public static void main(String[] args)
   {
      Random rand = new Random(); 
      int randomNo = rand.nextInt(100) + 1;  // Random Number Generated
      int guess;                             // Number user Guesses
      int attempts = 0;                      // Number of guesses
 
      guess = Integer.parseInt(JOptionPane.showInputDialog(null, "Enter a number 1-100"));
      attempts++;
 
     while (guess !=randomNo)
	 	{
 
         if (guess < randomNo)
         {
            JOptionPane.showInputDialog(null, "Too low sucker! Guess a higher number.");
         }
 
         else if (guess < randomNo)
         {
            JOptionPane.showInputDialog(null, "Woah! Guess a lower number.");
         }
 
         else if (guess <1 || guess >100)
         {
            JOptionPane.showInputDialog(null, "Really? Did You read the instructions? " +
            "That number is not between 1-100, guess again.");
         }   
 
 
      JOptionPane.showMessageDialog(null, "You win!");
      JOptionPane.showMessageDialog(null, "The number was " + randomNo);
      JOptionPane.showMessageDialog(null, "You guessed in " + attempts + " tries.");
      }     
 
   } // end main
} // end class GuessNumber

Moving it outside the loop, and including new input. Now, program doesn't allow input at all, and generates 4 errors.
Thanks for your patience!!

 
/** 
 * Emily Caraballo's Guess a Number Game, v1.0
 */
 
import javax.swing.JOptionPane;
import java.util.Random;
 
public class GuessNumber
{
public static void main(String[] args)
   {
      Random rand = new Random(); 
      int randomNo = rand.nextInt(100) + 1;  // Random Number Generated
      int guess;                             // Number user Guesses
      int attempts = 0;                      // Number of guesses
 
      guess = Integer.parseInt(JOptionPane.showInputDialog(null, "Enter a number 1-100"));
      attempts++;
 
     while (guess !=randomNo)
	 	{
 
         if (guess < randomNo)
         {
            guess = Integer.parseInt(JOptionPane.showInputDialog(null, "Too low sucker! Guess a higher number.""));
         }
 
         else if (guess < randomNo)
         {
            JOptionPane.showMessageDialog(null, "Woah! Guess a lower number.");
         }
 
         else if (guess <1 || guess >100)
         {
            JOptionPane.showMessageDialog(null, "Really? Did You read the instructions? " +
            "That number is not between 1-100, guess again.");
         }   
 
      }
 
      JOptionPane.showMessageDialog(null, "You win!");
      JOptionPane.showMessageDialog(null, "The number was " + randomNo);
      JOptionPane.showMessageDialog(null, "You guessed in " + attempts + " tries.");
 
 
   } // end main
} // end class GuessNumber

 ----jGRASP exec: javac -g GuessNumber.java
GuessNumber.java:25: error: unclosed string literal
            guess = Integer.parseInt(JOptionPane.showInputDialog(null, "Too low sucker! Guess a higher number.""));
                                                                                                               ^
GuessNumber.java:25: error: ';' expected
            guess = Integer.parseInt(JOptionPane.showInputDialog(null, "Too low sucker! Guess a higher number.""));
                                                                                                                   ^
GuessNumber.java:28: error: 'else' without 'if'
         else if (guess < randomNo)
         ^
GuessNumber.java:47: error: reached end of file while parsing
} // end class GuessNumber
 ^
4 errors
 
 ----jGRASP wedge: exit code for process is 1.
 ----jGRASP: operation complete.

You can also take a look at the syntax highlighting in the code tags in your own post.
You might see that there is quite a bit of blue color in the lower part of the while-loop. Maybe this might help you a little.

<3
You're my hero today. You give me hope that java is crackable. THANK YOU!!!