Thread: Program works, just not how i thought/wanted it would/to work.

so i have a class that creates a file:

java.io.*;
import java.lang.*;
import java.util.*;
 
public class CreateFile {
 
		private Formatter x;
 
		public void openFile(){
			try{
				x=new Formatter("NikolaiLavroff.txt");
			}
		catch(Exception e){
			System.out.println("You have an error");
		}
		}
 
		public void addRecords(){
			x.format("%s%s%s", "15\t", "N\t", "L\n");
			x.format("%s%s%s", "18\t", "F\t", "L\n");
			x.format("%s%s%s", "53\t", "K\t", "T\n"); 
			x.format("%s%s%s", "53\t", "J\t", "L\n");  //there were names in place of letters but ive changed them.
		}
 
		public void closeFile(){
			x.close();
		}
 
}

What i wanted to see in the file was:

15 N L
18 F L
53 K T
53 J L


and i that is what i saw.

I have another class to read the file:

import java.io.*;
import java.lang.*;
import java.util.*;
 
public class ReadFile {
 
	private Scanner x;
 
	public void openFile(){
		try{
			x=new Scanner(new File("NikolaiLavroff.txt"));
		}
		catch(Exception e){
			System.out.println("Could not find file");
		}
	}
	public void readFile(){
		while(x.hasNext()){
			String a =x.next();
			String b =x.next();
			String c =x.next();
 
		System.out.printf("%s%s%s", a,b,c);
		}
	}
	public void closeFile(){
		x.close();
	}
}

and then my main:

 
import java.io.File;
import java.util.*;
import javax.swing.JFrame;
 
class Apples{
 
    public static void main (String args[]){
 
    	ReadFile r=new ReadFile();
    	r.openFile();
    	r.readFile();
    	r.closeFile();
    }
  }

now what i was expecting to get in the program was

15 N L
18 F L
53 K T
53 J L

but instead i got all of the above (^^^) in one line and no spaces between them. I think the problem lies in the way i added the data (added records) in my createfile class because i didnt know how to make the data start on a new lign without using '\n'. I think it is simple problem as i am a java rookie

yes, but, i copied all of the code from a tutorial except, in the tutorial it shows how to add one record (in my CreateFile class) but then he just says he added more records, not showing how, but then i copied the exact same code in the tutorial for the ReadFile class but there was a different result in the tutorial so im wondering what i have to change in the 'CreateFile' class so that i get the wanted result.

I'm nowhere close being able to give you the solution, but do think that the core issue here is copying code and expecting it to work without you, the programmer, understanding how it operates.

My suggestion is that you, instead, use that same tutorial and try to make your own code from scratch. Do not put anything into your code without fully understanding what it does.

This way you will identify where your understanding is inadequate and can read up on that exact thing. Chances are that you will learn much more - and will be able to solve the issue expressed here yourself.

If someone else helps you to fix the code you simply copied and changed, you will get the result you wanted, but the result you want should really be learning and understanding, not?

Apologies if this post isn't very helpful, although it is trying to be.

Nothing is wrong with the method you proposed, i was just wondering how i could make 'x.format' go on a new line without having to do '\n'.

The programs current output is as i said, all the data in one line.

--- Update ---

Originally Posted by Baldyr

I'm nowhere close being able to give you the solution, but do think that the core issue here is copying code and expecting it to work without you, the programmer, understanding how it operates.

My suggestion is that you, instead, use that same tutorial and try to make your own code from scratch. Do not put anything into your code without fully understanding what it does.

This way you will identify where your understanding is inadequate and can read up on that exact thing. Chances are that you will learn much more - and will be able to solve the issue expressed here yourself.

If someone else helps you to fix the code you simply copied and changed, you will get the result you wanted, but the result you want should really be learning and understanding, not?

Apologies if this post isn't very helpful, although it is trying to be.

i guess so. The problem is, the explaining comes after the code in these tutorials so its not that easy to do what you're saying. Also when you talk about reading up on an 'exact thing', i need the exact terminology in most cases to look that thing up, which i doubt i'll have in most cases.

Originally Posted by Norm

What is wrong with using the "\n" character?

nothing in particular its just that, as i've said, in the tutorial i saw, another method is used, and ive specified, in what ive written, all the information that explains my problem.

Originally Posted by Norm

You can write it anyway you want, but if you want the Strings on different lines, there needs to be a new line character between the lines. Your choice.


Maybe the author or editor made a mistake.

It shows the program working...