Thread: help with array

my assignment is to code a program to simulate the rolling of 2 dice. I have most of it set but when I run it and have it print out how many times each number (2-12) was rolled, it displays the numbers 1 off. for instance it will display the number of 4s rolled next to the 5s.

here it is

import java.util.Scanner;                                         //allows info to be inputted//
import java.util.Random;                                          //opens random number generator//
 
public class RollTheDiceWithArray13
 
 
 
{
 
      public static void main(String[] args)
      {
      Scanner stdIn = new Scanner(System.in);                     //telling program that information will be gathered from what the user inputs//
      System.out.println("Welcome to the CS1400 Dice Simulator"); //Welcome user//
      int numberRolls;                                            //Preparing to receive int//
      int numberAsterisk = 0;
      System.out.print("How many times would you like to play?"); //Asking for the int//
 
 
      numberRolls = stdIn.nextInt();                              //storing the int//
 
         int[] tally = new int[13];                               // array for count of rolled dice
 
         for(int i=0; i<numberRolls; i++)                         //setting up conditions to repeat actions//
         {int dieOne = new Random().nextInt(6) + 1;               //setting up variable for first die//
         int dieTwo = new Random().nextInt(6) + 1;                //setting up variable for second die//
         int diceTotal = dieOne+dieTwo;                           //setting up variable for sum of the dice//
         System.out.println("score on the roll " + diceTotal);    //printing results(mainly for my benefit to see if the program was working)//
 
         tally[diceTotal]++;                                      //Keeping rolling stotal of score on dice.//
 
 
         }
 
         for (int i = 2; 1 < tally.length; i++)
 
         System.out.println((i+1) + ": " + tally[i]);             //printed tally counts//
 
 
 
 
 
 
 
 
 
 
      }
 
 
 
}

here is the error
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 13
at RollTheDiceWithArray13.main(RollTheDiceWithArray13 .java:36)

Look at these 2 lines and think very carefully:

int diceTotal = dieOne+dieTwo;
tally[diceTotal]++;

What values can diceTotal have? What is possible and impossible?
How many elements are you supposed to store in your array? What would be the first and what would be the last valid index?

what's possible is 2-12 impossible would 1, and anything >12
11 elements stored in the array 2-12
first would be 0 and last would be 11

If the first one is 0 and the last one is 11 you got 12 elements, but you want to store 11 elements.
So the first position is 0 and the last position is 10. (thats an array of size 11)

If you are given an integer of value somewhere between 2 and 12 and you want to generate a unique index between the range of 0 to 10, what do you do?

cry?
i set the array to 11
but then i get this error
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 11

Because you are still trying to access invalid array indices.

You use the variable diceTotal as an index into the array, but you arlready said it yourself:

what's possible is 2-12

But if 10 is the last entry in your array and diceTotal has a value of 11 or 12 (you said it, its possible) then of course you get an exception.

You have to change the way you access the array. First step is to calculate the correct index.
So the question is:
If you are given an integer of value somewhere between 2 and 12 and you want to generate a unique index between the range of 0 to 10, what do you do?

Got that part working, thanks. Now I'm trying to print percentages, but I can't get it to go through the second for loop. j starts at 0, and numberAsterisk is a percentage, so shouldn't it print something? When I debug, it doesn't even go through that part.

import java.util.Scanner;                                         //allows info to be inputted//
import java.util.Random;                                          //opens random number generator//
 
public class RollTheDiceWithArray13
 
 
 
{
 
      public static void main(String[] args)
      {
      Scanner stdIn = new Scanner(System.in);                     //telling program that information will be gathered from what the user inputs//
      System.out.println("Welcome to the CS1400 Dice Simulator"); //Welcome user//
      int numberRolls;                                            //Preparing to receive int//
      int numberAsterisk = 0;                                     //setting up variable for number of asterisk
      System.out.print("How many times would you like to play?"); //Asking for the int//
 
 
      numberRolls = stdIn.nextInt();                              //storing the int//
 
         int[] tally = new int[13];                               // array for count of rolled dice
 
         for(int i=0; i<numberRolls; i++)                         //setting up conditions to repeat actions//
         {int dieOne = new Random().nextInt(6) + 1;               //setting up variable for first die//
         int dieTwo = new Random().nextInt(6) + 1;                //setting up variable for second die//
         int diceTotal = dieOne+dieTwo;                           //setting up variable for sum of the dice//
         //System.out.println("score on the roll " + diceTotal);  //printing results(mainly for my benefit to see if the program was working)//
 
         tally[diceTotal]++;                                      //Keeping rolling stotal of score on dice.//
 
 
         }
 
         for (int i = 2; i < tally.length; i++)
         {
         numberAsterisk = (int) ((tally[i] / numberRolls) * 100);
 
 
            for (int j = 1; j < numberAsterisk; j++)
            {
 
            System.out.print((i) + ": " + "*");             //printed percentages//
 
            }  
         }    
 
      }
 
}

all 0s. is there a problem with this line?
numberAsterisk = (int) ((tally[i] / numberRolls) * 100);

Shouldn't that take the element at position i in the array, divide by number of rolls, then multiply by 100 to get a percentage?

Not sure what you mean about brackets. It doesn't have them as is, or it shouldn't have them?