Help Needed In the Code: Occurrence of Digits in a Number

**Megz** · August 29th, 2014, 07:05 AM

Hey!
So I got the following assignment- Make a program which takes input from the user (6-digit number) and check how many times each digit gets repeated in the number. Java GUI was used (Netbeans 6.5.1).

This is my code. I took the input via a JTextField named tf and displayed the output on JTextArea ta.

PS- arrays not used as we haven't studied them yet
- Sorry if there are any problems with indentations/documentation.

int num= Integer.parseInt(tf.getText());
        int no=num;
        if(num<100000)
            ta.setText("Invalid Input. Please Enter 6 digit number");
 
        int n1= num%10;
        num=num/10;     //stores last digit
 
        int n2= num%10;
        num=num/10;
 
        int n3= num%10;
        num=num/10;
 
        int n4= num%10;
        num=num/10;
 
        int n5= num%10;
        num=num/10;
 
        int n6= num%10;
        num=num/10;
 
 
        //Having stored all the digits in separate variables, we will now run loops to check the number's frequency 
 
 
        int i1 = 0,i2 = 0,i3 = 0,i4 = 0,i5 = 0,i6=0;
 
        while(no>0)
        {
          int rem= no%10;
 
          if (rem==n1)
              i1++;
          else
              if (rem==n2)
               i2++;
              else
                  if (rem==n3)
                  i3++;
                  else
                        if (rem==n4)
                         i4++;
                        else
                             if (rem==n5)
                                i5++;
                             else
                                  if (rem==n6)
                                    i6++;
          no=no/10;
        }
 
        //Printing the output below
 
        ta.append(n1+" "+"occured"+" "+i1+" "+"times"+"\n"+n2+" "+"occured"+" "+i2+" "+"times"+"\n");
        ta.append(n3+" "+"occured"+" "+i3+" "+"times"+"\n"+n4+" "+"occured"+" "+i4+" "+"times"+"\n");
        ta.append(n5+" "+"occured"+" "+i5+" "+"times"+"\n"+n6+" "+"occured"+" "+i6+" "+"times");

The problem is that in case of numbers like 666666, the output is -
6 occured 6 times
6 occured 0 times
6 occured 0 times
6 occured 0 times
6 occured 0 times
6 occured 0 times

How do I omit the last 5 lines? This problem occurs whenever I input a digit with any recurring digit.
What changes/additions should I make?

**aussiemcgr** · August 29th, 2014, 07:42 AM

Out of curiosity, why don't you keep the input as a String and simply parse the String?

For example, here is sample code which would parse a number (stored as a String) for a specific digit:

String input = 57426
int toFind = 4;
System.out.println(indexOf(input,toFind)+"");
 
public int indexOf(String input,int toFind) {
	// Loop the length of the String
	for(int i=0;i<input.length;i++) {
		// Get the digit by pulling the character from the index and converting it
		int digit = Character.getNumericValue(input.charAt(i));
		// Compare the number you are searching for with the digit
		if(toFind==digit) {
			// Return the index if it is found
			return i;
		}
	}
	return -1;
}

And this code would output: 2

**GregBrannon** · August 29th, 2014, 07:45 AM

Welcome to the forum! Thanks for taking the time to learn how to post code correctly. If you haven't already, please read this topic to learn other useful info for new members.

Use in if() statement to exclude the output of undesired results.

**Megz** · August 30th, 2014, 10:51 AM

Originally Posted by GregBrannon

Welcome to the forum! Thanks for taking the time to learn how to post code correctly. If you haven't already, please read this topic to learn other useful info for new members.

Use in if() statement to exclude the output of undesired results.

Could you be a bit more specific about it with reference to the code?
Thanks!

**Norm** · August 30th, 2014, 11:36 AM

How do I omit the last 5 lines?

What needs to be compared so the code does not print those lines?

**Megz** · August 31st, 2014, 08:50 AM

Originally Posted by Norm

What needs to be compared so the code does not print those lines?

The value of counter variables i1,i2,etc I guess

**Norm** · August 31st, 2014, 08:55 AM

The value of counter variables i1,i2,etc I guess

Are you sure?

A problem with understanding the code is the way the variables are named.
What do the variables that begin with n hold? And those that begin with i?

Variable names should describe what the variable holds. The variables in this program hold the value of the digit and the count of the uses of that digit. i1 and n1 don't say that.

**Megz** · September 1st, 2014, 06:25 AM

Originally Posted by Norm

Are you sure?

A problem with understanding the code is the way the variables are named.
What do the variables that begin with n hold? And those that begin with i?

variables i1,i2,etc. are the counter variables which check how many times the loop has run so as to get the number of times the digit get repeated.
n1-n6 represent the individual digits stored separately. For example for 123456,
n1=6
n2=5
n3=4
n4=3
n5=2
n6=1

So sorry about the confusing names... I couldn't figure out what to name them

**Norm** · September 1st, 2014, 07:17 AM

How about: theDigit1, theDigit2, etc
and countOfDigit1, countOfDigit2, etc

Back to post#5 about this question: How do I omit the last 5 lines?
What is there about those lines that the code can detect to not print them?

**Megz** · September 1st, 2014, 08:49 AM

Originally Posted by Norm

What is there about those lines that the code can detect to not print them?

I guess we could check if the value of any of the counter variables is zero and then not rpint it...the part that is ci=onfusing me is how to do it without making the code inefficient

**Norm** · September 1st, 2014, 08:57 AM

how to do it without making the code inefficient

Not sure what you think would be inefficient.
Get the code to work first. Then if there is a problem change it.

The main inefficiency problem with the code is all the variables instead of using arrays.

**Megz** · September 2nd, 2014, 08:47 AM

Originally Posted by Norm

The main inefficiency problem with the code is all the variables instead of using arrays.

So sorry about that...It is my first year learning Java GUI programming and we haven't touched the topic of arrays yet!

**Cornix** · September 2nd, 2014, 10:43 AM

Then you shouldnt even think about such things as efficiency or inefficiency. Even some more advanced programmers dont understand much about it.

Thread: Help Needed In the Code: Occurrence of Digits in a Number

LinkBack

Thread Tools

Display

Help Needed In the Code: Occurrence of Digits in a Number

Related threads:

Re: Help Needed In the Code: Occurrence of Digits in a Number

Re: Help Needed In the Code: Occurrence of Digits in a Number

Re: Help Needed In the Code: Occurrence of Digits in a Number

Re: Help Needed In the Code: Occurrence of Digits in a Number

Re: Help Needed In the Code: Occurrence of Digits in a Number

Re: Help Needed In the Code: Occurrence of Digits in a Number

Re: Help Needed In the Code: Occurrence of Digits in a Number

Re: Help Needed In the Code: Occurrence of Digits in a Number

Re: Help Needed In the Code: Occurrence of Digits in a Number

Re: Help Needed In the Code: Occurrence of Digits in a Number

Re: Help Needed In the Code: Occurrence of Digits in a Number

Re: Help Needed In the Code: Occurrence of Digits in a Number

Similar Threads

URGENT HELP NEEDED IN AN HOUR:Printing first number in input

HELP Please- Putting Digits within a number in ascending order

Create a java program to determine what integers of two, three, and four digits are equal to the sum of the cubes of their digits?

[SOLVED] Extracting whole number digits from a float

application that determines and prints the number of odd, even, and zero digits

Tags for this Thread