Thread: Average score assignment

Why are you using this inner class construction:

TestScores scores = classProgram.new TestScores(test1, test2, test3);

Why not eliminate the class TestScores and fall back to TestScoresAverage as the only class?

Originally Posted by Norm

Try using the javac command to check for errors. Be sure to use the -Xlint option also. It will show bad code also.

post moved to own thread.

One problem with the code is it has lost its formatting/indentations for nested statements.

Ok, Thank you.

--- Update ---

Originally Posted by GregBrannon

Why are you using this inner class construction:

TestScores scores = classProgram.new TestScores(test1, test2, test3);

Why not eliminate the class TestScores and fall back to TestScoresAverage as the only class?

Because I'm bulldogging my way through the code. Taking my Java course online and I have very little comp experience since I've been making my living as a mechanic for the last 16 years (currently). I'm lucky I know how to use Microsoft Word.... Excel = forget it

forget it

No, that's not appropriate. Sometimes instructors ask for or require weird things to have that "teachable moment" . . . I was just trying to figure out where your weird thing was coming from.

Don't give up on you or us, come back with additional questions if you need help.

Originally Posted by GregBrannon

No, that's not appropriate.

Since I'm not a regular computer guy, I think my attempt at sarcasm failed. I do quiet a bit of GIS in school and I export my attribute tables into an .Xlxs when I have a lot of data that needs to be sorted quickly then imported back into my .shp. I should have just said my excel skills are limited.

So far, when I've been stuck trying to figure out a problem, I've been pretty successful using the search function to read through other posts. If I get stuck and need help, I'll be sure to ask. Thank you

Sarcasm just doesn't work well in this format, and programmers tend to be literal.

Figuring it out yourself will likely result in better learning, anyway, but don't hesitate to ask for help if you need to.

Completing my point about the inner class design, rather than using the inner class, I suggest moving it outside like this (two existing lines were commented out and a replacement line was added, all commented):

import java.util.Scanner;
// Name: Joe 
// Date: ........
// Desc: Test Score Averages
 
public class TestScoresAverage
{
    public static void main(String[] args) 
    {
        double test1;
        double test2;
        double test3;
 
        // Create a scanner for keyboard score input.
 
        Scanner keyboard = new Scanner(System.in);
 
        System.out.print("Enter test score: ");
        test1 = keyboard.nextDouble();
        System.out.print("Enter test score: ");
        test2 = keyboard.nextDouble();
        System.out.print("Enter test score: ");
        test3 = keyboard.nextDouble();
 
        // Close Scanner
 
        keyboard.close();
 
        // moving TestScores from inside TestScoresAverage changes the
        // following two lines to the third:
        // TestScoresAverage classProgram = new TestScoresAverage();
        // TestScores scores = classProgram.new TestScores(test1, test2, test3);
 
        TestScores scores = new TestScores(test1, test2, test3);
 
        // Output Display Average Score
 
        System.out.println("The average test score: "
                + scores.getAverageScore());
    }
}
 
// this class was moved from being an inner class to the top level. note that
// only one top-level class in the same file can be 'public'
class TestScores 
//create 
{
    private double score1;
    private double score2;
    private double score3;
 
    public TestScores(double score1, double score2, double score3) 
    {
        this.score1 = score1;
        this.score2 = score2;
        this.score3 = score3;
    }
    public void setScore1(double score) 
    {
        score1 = score;
    }
    public void setScore2(double score) 
    {
        score2 = score;
    }
    public void setScore3(double score) 
    {
        score3 = score;
    }
    public double getScore1() 
    {
        return score1;
    }
    public double getScore2() 
    {
        return score2;
    }
    public double getScore3() 
    {
        return score3;
    }
    public double getAverageScore() 
    {
        return (score1 + score2 + score3) / 3;
    }
}