Thread: Help! Whats wrong with my code?

Firstly, the 'main' method declaration is wrong. It has to be public static void main. You missed void

--- Update ---

else should not have condition, else (z < x && z < y)
{return z;
}

It should be just else { }

Thank you! I now only have one error and its with the else if this is what its saying...

----jGRASP exec: javac -g SmallestAndAverageCh5.java
SmallestAndAverageCh5.java:26: error: 'else' without 'if'
else if (y < x && y < z)
^
1 error

----jGRASP wedge: exit code for process is 1.
----jGRASP: operation complete.

_______

Originally Posted by divdat

Firstly, the 'main' method declaration is wrong. It has to be public static void main. You missed void

--- Update ---

else should not have condition, else (z < x && z < y)
{return z;
}

It should be just else { }

I think I am doing something wrong because I keep getting the same error message for my else if statement

 
public static double smallest(double x, double y, double z) 
{
if (x < y && x < z)
{
return x;
 
else if (y < x && y < z)
{return y;
}
 
else
{return z;
}
 
}

the compiler is saying i have a problem with my else if (y < x && y < z) statement

That might be because the 'if' is not having an ending '}'

thank you!
i know have this

 
import java.util.Scanner;
public class SmallestAndAverageCh5
{
 
   public static double smallest(double x, double y, double z) 
{
   if (x < y && x < z)
   {
      return x;
   }
 
   else if (y < x && y < z)
   {
      return y;
   }
 
   else
   {
      return z;
   }
 
}
 
 
public static double average(double x, double y, double z)
{
   double average = (x + y + z)/3;
   return average;
}
 
 
   public static void main(String[] args)
   {
      Scanner in = new Scanner(System.in);
      System.out.print("Please enter three different numbers between 1 and 10:");
      double x = in.nextDouble();
      double y = in.nextDouble();
      double z = in.nextDouble();
 
      double smResult = smallest;
      double avgResult = average;
      System.out.print("The smallest value you entered is " + smResult);
      System.out.print("The average value of the numvers you entered is " + avgResult);
 
   } 
 
 
}

but now it is saying that it cannot this.... are my methods just done completely wrong?

----jGRASP exec: javac -g SmallestAndAverageCh5.java
SmallestAndAverageCh5.java:40: error: cannot find symbol
double smResult = smallest;
^
symbol: variable smallest
location: class SmallestAndAverageCh5
SmallestAndAverageCh5.java:41: error: cannot find symbol
double avgResult = average;
^
symbol: variable average
location: class SmallestAndAverageCh5
2 errors

----jGRASP wedge: exit code for process is 1.
----jGRASP: operation complete.

Your method calls are wrong, they must be
double smResult = smallest(x,y,z);
double avgResult = average(x,y,z);