Thread: Need help with my code (Unreachable code error)

Hi, I recently started programming with java and I was doing a code where two random numbers from 1-10 would be chosen and then a random operator would be chosen as well, the user would have to input the answer to the question and the program is suppose to check if its correct or not.

import java.util.Random;
import java.util.Scanner;

/**
 * Johan Biesert
 * Project Chapter 4
 * Part 1
 * October 30 2018
 */
 
public class Part_2 {
 
	public static void main(String[] args) {
 
 
		//variables
 
			int First;
			int Second;
			int random1;
			int operator;
			int calc;
			int ans;
 
			First = (int) (( 10 - 1 + 1) *Math.random() + 1);
			Second = (int) (( 10 - 1 + 1) *Math.random() + 1);
			random1 = (int) (( 4 - 1 + 1) *Math.random() + 1);
 
			operator = ' ';
			switch (operator) { 
			case 1: operator = '+'; break;
			case 2: operator = '-'; break;
			case 3: operator = '*'; break;
			case 4: operator = '/'; break;
 
			if (random1 == 1)	   {     [B]Error starts here[/B]
				operator = 1; }
			else if (random1 == 2) {
				operator = 2; }
			else if (random1 == 3) {
				operator = 3; }
			else if (random1 == 4) {
				operator = 4;
 
			System.out.println("solve the following");
 
			System.out.println(First + operator + Second);
			calc = (First + operator + Second);
 
 
			Scanner input = new Scanner(System.in);
			ans = input.nextInt();
			input.close();
 
			if (ans == calc) {
				System.out.println("correct");
			} else {
				System.out.println("incorrect");
				}
 
 
 
 
 
 
 
				}
 
			}
		}
	}

You have your {} placed incorrectly. You need one right after the switch statement. And delete on at the end of your code.
But you have some other problems. That is not how you calculate calc. You need to do it in the switch statement for each operator.

And a couple of other items.

10-1+1 = 10
4-1+1 = 4
etc.

So get rid of those in your random statements and just use the whole number.

Finally, look at this code.

if (random1 == 1)	{
operator = 1;
} else if (random1 == 2) {
operator = 2;
} else if (random1 == 3) {
operator = 3;
} else if (random1 == 4) {
operator = 4;
}

Why not just get rid of random1 and assign the value to operator directly?

Regards,
Jim

Please edit your post and wrap your code with code tags:

[code]
**YOUR CODE GOES HERE**
[/code]

to get highlighting and preserve formatting.