Thread: getting my timer to run multiple times

Hello everyone,

I am writing code to get my semi that I drew with graphics across the screen. This code works; however, it only runs the movement function once. I want it to continue repeating the timer task until the semi has moved completely off the screen. How can I adjust my code to accomplish that?

Thank you in advance for your help!

public class DrivingVehicle extends Application {
 
    int x = 10;
    Semi semi = new Semi();
 
    @Override
    public void start(Stage primaryStage) {
 
        Group root = new Group(semi);
        Timer timer = new Timer();
 
        timer.schedule(task,1500l);
 
        Scene scene = new Scene(root, 500, 400, Color.BLUE);
 
        primaryStage.setTitle("Driving semi");
        primaryStage.setScene(scene);
        primaryStage.show();
    }
 
    public static void main(String[] args) {
        launch(args);
    }
 
    TimerTask task = new TimerTask()
    {
        public void run()
        {
            semi.setTranslateX(x); 
            x+=10;
        }
 
    };
 
}

Originally Posted by jim829

Actually, you have your timer configured for a one shot operation. Check out the API and add a third argument for repeated calls.

Regards,
Jim

Oh got it! Thank you. One more question: How do I get the program to stop running at a certain point? Say, I create an int with a value of 30 and I want it to stop running the timer task once it has run 30 times. How can I do that?

Originally Posted by jim829

Why not put in a counter in your timer task and increment it on each call. You can then either exit directly from their or set some flag which you can check later.

Regards,
Jim

Thanks! I do have that done now. Here's the code for it. However, the idea is to make it look like the semi is driving off the screen. So this method makes the vehicle move too abruptly. Do I need to make a second timer to slow it down or something or how can I do it? I tried putting the loop outside of the timer task and instead putting it around timer.schedule, but it just says the task has already run when it tries to attempt it again. Any suggestions?

Originally Posted by jim829

You didn't include the code but it doesn't matter. There are two basic aspects to making something move. The time between moves and the distance per move. So increasing the time and shortening the distance may make it smoother. You just need to play with it to see what works best.

Regards,
Jim

Sorry. Here's the code. It doesn't allow for adjusting the time between moves as far as I can think of.

public class DrivingVehicle extends Application {
 
    int x = 10;
    Semi semi = new Semi();
 
    @Override
    public void start(Stage primaryStage) {
 
        Group root = new Group(semi);
        Timer timer = new Timer();
 
        timer.schedule(task, 1500l, 20);
 
        Scene scene = new Scene(root, 500, 400, Color.BLUE);
 
        primaryStage.setTitle("Driving semi");
        primaryStage.setScene(scene);
        primaryStage.show();
    }
 
    public static void main(String[] args) {
        launch(args);
    }
 
    TimerTask task = new TimerTask()
    {
        public void run()
        {
            for(int i=0;i<30;i++)
            {
                semi.setTranslateX(x); 
                x+=10;
            }
        }
 
    };
 
}