Thread: Am I doing something wrong?

So I am trying to make a program where I can enter any phrase, and the computer detects the vowels in the phrase, changing them to a #. Can someone help me out because I think I'm pretty sure I am doing it right, but it doesn't come out right? I already have included a Scanner.

System.out.println("Enter a phrase you like");
String phrase = input.nextLine();
int length = phrase.length();
for(int z = 0 ; z < length; z++)
 
 
 
{ //Starts the loop
 
  if(phrase.charAt(z) == 'a' || phrase.charAt(z) == 'A' || phrase.charAt(z) == 'e' || phrase.charAt(z) == 'E' || phrase.charAt(z) == 'i' || phrase.charAt(z) == 'I' || phrase.charAt(z) == 'o' || phrase.charAt(z) == 'O' || phrase.charAt(z) == 'u' || phrase.charAt(z) == 'U'){
System.out.print("#");
  }//ends if statement 1 
 
 
}//ends the Loop
 System.out.print(phrase);

So lets say I wrote: "John Doe is amazing"

It comes out as:
#######John Doe is amazing, meaning it knows the amount of vowels, but it wont replace them

Its supposed to be:
J#hn D## #s #m#z#ng

it doesn't come out right?

What was the phrase that was entered?
What was the expected output?
What was the actual output?

changing them to a #
...
it wont replace them

Where is the code to change a vowel to a #?

Please edit your post and wrap your code with code tags:

[code]
**YOUR CODE GOES HERE**
[/code]

to get highlighting and preserve formatting.

How is the code trying to change vowels to #s? I don't see any code that does that.
What is the purpose of printing out the #s?

it would change the vowels

To change the value of a variable, there needs to be an assignment statement:

  theVariable = theNewValue;

However, The contents of Strings can not be changed.

To create a String with replaced values, the String class has a method that will do the replacement and create a new String with the replaced value.
Look at the String class's API doc to see what methods are available
http://docs.oracle.com/javase/8/docs/api/index.html

Are you suggesting something like:

No, nothing like that. I don't see any way that code tries to use one of the String class's methods to create a new String with the replaced vowel.

The code I am talking about to replace a char in a String would look like this:

  String newString = oldString.aStringMethod(args to the method);

Read the API doc for the String class.

Do you want to post your solution so others can see it?