Thread: Help with my code for this client/server program.

Can you post code that is not double spaced? The extra blank lines makes the code hard to work with.

One problem I see is the empty catch blocks. There should be calls to the printStackTrace method in all catch blocks to show messages when an exception happens.

Try adding some print statements to the code that show where the code is executing and what the values of variables are as they change.

Okay, I posted without the double spaces. I will look into the other things you said right now, thanks for the quick response Norm!

--- Update ---

import java.io.BufferedReader;
import java.io.File;
import java.io.FileReader;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.OutputStream;
import java.io.PrintWriter;
import java.net.ServerSocket;
import java.net.Socket;
public class Server {
public static void main(String[] args) {
try
{
	// creating ServerSocket object
	ServerSocket ss=new ServerSocket(3333);
	System.out.println("Server is waiting for connection...!!!");
	Socket s=ss.accept(); // accepting connection from client
	System.out.println("Connection successful...!!!");
	InputStream is=s.getInputStream(); // creating InputStream object
	BufferedReader br1=new BufferedReader(new InputStreamReader(is));
	System.out.println("BufferedReader 1");
	String fileName=br1.readLine();
	BufferedReader br2=new BufferedReader(new FileReader(fileName));
	System.out.println("BufferedReader 2");
	OutputStream os=s.getOutputStream();
	PrintWriter pw=new PrintWriter(os,true);
	String s1="";
	// reading content from file and sending to client line by line
	while((s1=br2.readLine())!=null) {
		pw.println(s1);
}
	pw.close();
	br1.close();
	br2.close();
	is.close();
	os.close();
}		
	catch (Exception e) {
}
}
}

import java.io.BufferedReader;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.OutputStream;
import java.io.PrintWriter;
import java.net.Socket;
import java.util.Scanner;
public class Client {
public static void main(String[] args) {
try {
 
	// creating Scanner class object to getting input from user
	Scanner sc=new Scanner(System.in);
	// creating Socket object
	Socket s=new Socket("localhost", 3333);
	System.out.print("Enter file name: ");
	String fileName=sc.nextLine(); // getting file name from user
	System.out.println("got filename");
	OutputStream os=s.getOutputStream();
	PrintWriter pw=new PrintWriter(os, true);
	pw.println(fileName);
	InputStream is=s.getInputStream();
	BufferedReader br=new BufferedReader(new InputStreamReader(is));
	String s1="";
	// reading and printing content sent by server
	while((s1=br.readLine())!=null) {
		System.out.println(s1);
}
	s.close();
	sc.close();
	pw.close();
	is.close();
	os.close();
} 
	catch (Exception e) {
}
}
}

I added in some print statements to see where it gets completed, for some reason when I run the project once then it does the connection successful but it does not anymore after that, I am guessing because the socket is not closed. However, it does get to the print statement "got file" but still not printing any contents that I had in the file. My assignment is this: Write a client program and server program. The server uses a socket connection to allow a client to supply a filename and the server will send the file contents to the client or an error message if the file does not exist. The client will display the contents to the screen.

The catch blocks are still empty. That means exception messages are not printed that could tell you about a problem.

I added in some print statements

Can you copy what is printed and paste it here so we can see what the programs are doing?

There needs to be print statements that print out the value of filename and that print out each record that was read from the file and prints a message when the loop exits.