Thread: 2 sets of code, should work same but dont

Hi, I am learning Java by doing the Stanford CS106 class, and in one of the assignments, I need to make a pyramid. All fine with that, but when I tried to clean up my code, it seemed to break it, and I can not figure out why. I dont understand how they do not work the same. If someone can tell me why its not working the same, it would be greatly appreciated. The first code listed is the working one. I should probably say, the first one prints the pyramid correctly, the second code, from what I can see, just displays bricks (rectangles) and an even spacing straight across the screen,

/*
 *Draws a pyramid with a base of 14, and 14 bricks high.
 */
 
import acm.graphics.*;
import acm.program.*;
import java.awt.*;
 
public class Pyramid extends GraphicsProgram {
 
	private static final long serialVersionUID = 1L;
 
	/** Width of each brick in pixels */
	private static final int BRICK_WIDTH = 30;
 
	/** Width of each brick in pixels */
	private static final int BRICK_HEIGHT = 12;
 
	/** Number of bricks in the base of the pyramid */
	private static final int BRICKS_IN_BASE = 14;
 
 
 
	public void run() 
 
	{			
		for (int i = 0; i < BRICKS_IN_BASE; i++)
		{ 
			int startingPointX = (getWidth() / 2) - (BRICKS_IN_BASE * (BRICK_WIDTH / 2));
			int startingPointY = getHeight() - BRICK_HEIGHT;
			startingPointX += ( i * BRICK_WIDTH / 2);
			startingPointY -= (i * BRICK_HEIGHT);
 
			for (int j = 0; j < BRICKS_IN_BASE - i; j++)
			{
				drawBrick(startingPointX, startingPointY);
				startingPointX += BRICK_WIDTH;
			}
 
		}
	}
 
	private void drawBrick(int x, int y)
	{
		GRect brick = new GRect(x, y, BRICK_WIDTH, BRICK_HEIGHT);
		add(brick);
	}
 
}

/*
 *Draws a pyramid with a base of 14, and 14 bricks high.
 */
 
import acm.graphics.*;
import acm.program.*;
import java.awt.*;
 
public class Pyramid extends GraphicsProgram {
 
	private static final long serialVersionUID = 1L;
 
	/** Width of each brick in pixels */
	private static final int BRICK_WIDTH = 30;
 
	/** Width of each brick in pixels */
	private static final int BRICK_HEIGHT = 12;
 
	/** Number of bricks in the base of the pyramid */
	private static final int BRICKS_IN_BASE = 14;
 
 
 
	public void run() 
 
	{			
		int startingPointX = (getWidth() / 2) - (BRICKS_IN_BASE * (BRICK_WIDTH / 2));
		int startingPointY = getHeight() - BRICK_HEIGHT;
 
		int posX = startingPointX;
		int posY = startingPointY;
 
		for (int i = 0; i < BRICKS_IN_BASE; i++)
		{ 
			posX = startingPointX;
			posY = startingPointY;
 
			posX += ( i * BRICK_WIDTH / 2);
			posY -= (i * BRICK_HEIGHT);
 
			for (int j = 0; j < BRICKS_IN_BASE - i; j++)
			{
				drawBrick(posX, posY);
				startingPointX += BRICK_WIDTH;
			}
 
		}
	}
 
	private void drawBrick(int x, int y)
	{
		GRect brick = new GRect(x, y, BRICK_WIDTH, BRICK_HEIGHT);
		add(brick);
	}
 
}

Originally Posted by Norm

Can you copy and paste here the output from the two programs?
Be sure to wrap it code tags to preserve the indentations.

How can the code be compiled and executed for testing?
I see imports of 3rd party packages.

Can you post the minimum values for width and height that will work?

The only output I get is a graphics display. I am sorry I am not sure about the 3rd party packages, ive just recently started this online class, I got all the information from the stanford website on how to import the acm package. I have my eclipse linked to stanford system, or something like that, as you can probably tell, im not quite sure what I am talking about regarding this.

Any positive values would would work for the width and height, i believe.

Originally Posted by Norm

We crossed while posting. See my last post for a way to easily see what the code is doing.

Managed to solve it, done as you suggested, printed out the values and discovered there was something not right with the x/posX, turns out I was using the line startingPointX += BRICK_WIDTH; instead of posX += BRICK_WIDTH; So the value was not increasing like it should have been.

Thank you for the help. Greatly appreciated.