Thread: Drawing in Java

Illegal static declaration in inner class Window.Point

Those classes are declared inside of another class. They need to be declared as static.
I said that earlier in post#9

cant acceses the method fromInput?

Look at post#22 for how to call the fromInput method.

What is in the In class? How are you supposed to use it to find and read the data file?
I see it is used in the fromInput methods.

it doesn't work
AND
it compiles errors

Please explain. Copy and paste the full text of any error messages.

Here is the Point class I am using and that works:

//-----------------------------------
static class Point   {                
	int x;
	int y;
 
	Point(int x, int y) {
		this.x = x;
		this.y = y;
 
 
	}	
   static Point fromInput() {  
       int x = In.readInt();
       int y = In.readInt();
 
	if (In.done()) return new Point(x, y);
        else return null;
   }
   public void drawMe(MyWindow mw) {      //<<<<<<< ADDED
      mw.drawPoint(x,y);  
   }
}

all of that it should work

Probably not. There needs to be changes to all the classes as per the Point class example.

Compare my code with yours in post#16.

Yea yea I got that I need to do it for all classes like you did for Point.Sorry my laptop ran out of batter I'll try it now.

--- Update ---

Window.java:323: error: cannot find symbol
public void drawMe(MyWindow mw) { //<<<<<<< ADDED
^
symbol: class MyWindow
location: class Point
Window.java:405: error: cannot find symbol
w.drawCircle(x, y, r );
^
symbol: variable w
location: class Circle
Window.java:419: error: cannot find symbol
r.draw(w);
^
symbol: method draw(Window)
location: variable r of type Rectangle
Window.java:423: error: cannot find symbol
c.draw(w);
^
symbol: method draw(Window)
location: variable c of type Circle
4 errors

C:\Users\Hp\Desktop\figuren>

What should I change, I only did it for point to test and this came out

EDIT: I saw that the name of MyWindow and mw are diffrent and taht is why it was compiling it like that,i fixed it but now only the Window pops up but no image?

Window.java:323: error: cannot find symbol MyWindow

See the last line in post#2

Window.java:405: error: cannot find symbol
w.drawCircle(x, y, r );
^
symbol: variable w

Where is the variable w declared? The compiler can not find it.

Yes, you will need a loop to continue reading through the input file until the last record has been processed.
A for loop is usually used when you know before the loop starts, how many iterations it will do.
A while loop is used when the end of the loop condition is detected while the loop is running.

Hmmm,I see so actuall using a while would be much better in my case.I'll try a few things and we'll see what happens,Thanks for the advice!

--- Update ---

Okay so i tried it a few ways and it isnt working so hot;

 
public static void main(String[] args){
	In.open("shapes.txt");
	int width = In.readInt();
	int height = In.readInt();
	do {
	Window w = Window.create(width,height);
	char ch = In.readChar();
	switch(ch){
		case 'L':
		Line l = Line.fromInput();
		l.draw(w);
		break;
		case 'R':
		Rectangle r = Rectangle.fromInput();
		r.draw(w);
		break;
		case 'C':
		Circle c = Circle.fromInput();
		c.draw(w);
		break;
	 }
	}while(In.done());
In.close();
}
}

Is my condition wrong, or the "position" of my do while loop

EDIT:

I got the code now to get the picture out, but it is "dislocated" not like it is susposed to be, what could be the cause of that

public static void main(String[] args){
	In.open("shapes.txt");
	int width = In.readInt();
	int height = In.readInt();
	Window w = Window.create(width,height);
	do{
	char ch = In.readChar();
	switch(ch){
		case 'L':
		Line l = Line.fromInput();
		l.draw(w);
		break;
		case 'R':
		Rectangle r = Rectangle.fromInput();
		r.draw(w);
		break;
		case 'C':
		Circle c = Circle.fromInput();
		c.draw(w);
		break;
	 }
	}while(In.done());
In.close();
}
}

it is "dislocated" not like it is susposed to be

What does that mean?
Take some graph paper and use the instructions in the data file to draw the image by hand to see what its contents represents.

Did your manual drawing match what it was supposed to be
or did it match what the program drew?

Did your manual drawing match what it was supposed to be (ie what you got from the professor)
or did it match what the program drew?

Yea,it did match what I got from the professor.

EDIT: I figured it out, the readChar in rectangle and circle were "eating" the first number in numbers like 50 40 etc... So after removing that It works like a charm.
Thanks so much for your help Norm.