Thread: Why is my program not printing the highest and lowest numbers?

Hi! I'm a total beginner and I was wondering if someone can help me with this code.

The test for the largest and smallest numbers should be inside of the do{}while loop, NOT after the loop.

Please post the code that gives the error
and copy and paste here the full text of the error message.


Check that the {}s are properly paired.

messed up the brackets in my code

Yes that is probably the problem.
Not all the }s are inline and below the start of the line with the pairing {
For example:

				} else if (userNumber > largestNumber) {   //<<<<< Here is its pair
					largestNumber = userNumber;
			}     //<<<<<<< This should be beneath the start the line with the pairing {

Move the noted } to the right so it pairs with the {

What is this hanging { doing?

  		{   //<<<<<< What is this for?
				if (userNumber < smallestNumber) {

Remove that {

what do you mean with "to the right"?

By to the right I mean add spaces before the character so that it moves to the right
For example:

   y
             x  << this x is to right of the above y

--- Update ---

where exactly do you mean with "beneath the start line"?

I said:

below the start of the line with the pairing {

   if(test) {
   ^ this is the start of the code on the line with the {
   }  // this should be beneath the start of the line with the pairing {

Can you post the new code?
Also add some comments about what the program is going to do with the input from the user. What steps will it take to find the smallest and the largest values?
The comments should describe what the code is going to do.
I use the comments to check that the code is doing what it is supposed to do.

What should the program do with the number it reads from the user?

What if you did this manually?
Some one gives you values one at a time and you are required to keep the smallest one in one pile and the largest in another.
Start in the middle (assume that you have gotten past the first few numbers). You get a value from the user. What do you do with that value?
What do you look at and what decisions do you make?

Later we'll go back and work on the first values.