Thread: File don't work

I have problem making my file work. Wrong message in console is "Index out of bounds" or "Index 1 out of bounds for length 1". How do I solve it?

 
 
/**
 * Class for reading capitals from file and creating Capital objects from them
 */
class CapitalReader {
 
    /**
     * Returns random Capital object from list of capitals
     * @return random Capital
     */
    public static Capital getRandomCapital() {
 
        ArrayList<Capital> capitals = getCapitalsFromFile();
        Random randomGenerator = new Random();
        int randomIndex = randomGenerator.nextInt(capitals.size());
        return capitals.get(randomIndex);
    }
 
    /**
     * Read file with capitals and create a list containing all Capital objects
     * @return list of capital objects
     */
    private static ArrayList<Capital> getCapitalsFromFile() {
 
        String txtFile = "words.txt";
        BufferedReader br = null;
        String line = "";
        int COUNTRY_COL = 0;
        int CAPITAL_COL = 1;
        ArrayList<Capital> capitals = new ArrayList<Capital>();
 
        try {
 
            br = new BufferedReader(new FileReader(txtFile));
 
            while ((line = br.readLine()) != null) {
                String[] capital = " \\|".split(line);
                capitals.add(new Capital(capital[CAPITAL_COL] , capital[COUNTRY_COL]));
            }
 
        } catch (FileNotFoundException e) {
            System.out.println("File not found CapitalReader");
        } catch (IOException e) {
            e.printStackTrace();
        } finally {
            if (br != null) {
                try {
                    br.close();
                } catch (IOException e) {
                    e.printStackTrace();
                }
            }
        }
        return capitals;
    }
}

Originally Posted by Norm

The only valid index for an array of length 1 is 0. The max index for an array is the array's length - 1.
An array requires 2 elements for the index of 1 to be valid.

Check that the array has at least two elements in it before using an index of 1.

See what is in the capital array by printing its contents using the Arrays toString method:

    System.out.println("capital= "+ java.util.Arrays.toString(capital));

Thank you it did work, also my split argument was wrong so now everything is working good