Thread: Battleship GUI Program

for ( int i = 0; i < arrayOfButtons.length; i++)
            {
               for (  int j = 0; j < arrayOfButtons[i].length; j++)
                  arrayOfButtons[i][j] = new JButton("0");
            }
 
            for (int i = 0; i < arrayOfButtons.length; i++)
            {
               for (   int j = 0; j < arrayOfButtons[i].length; j++)
                  arrayOfButtons[i][j].addActionListener(this);
            }
 
 
            for ( int i = 0; i < arrayOfButtons.length; i++)
            {
               for (   int j = 0; j < arrayOfButtons[i].length; j++)
                  pane.add(arrayOfButtons[i][j]);
            }

Perhaps it's these for loops. Is there any way I could make it into one?

I need to get it to figure out what button was clicked and get the indexes of those and set them to I and J.

Then it'll work.

But how do you do that?

Originally Posted by Norm

How does your program set the values of i and j that you use for indexes?

What does: e.getActionCommand().equals("0") have to do with the problem?

What is the value of e.getActionCommand()? Use println() to display it!!! Then you'll know what the program is doing.

You need to learn how to debug your program. Your assuming that your thoughts are somehow making into your code. Sometimes it works differently than you think. To see what it is doing, use System.out.println() to show values.

I know what it's doing. i and j are initialized to 0, so it only works for 0, 0.

How do I fix that problem? I've also noticed my battleship is moving.

How do I get it so it stops calling place Battleship every time I click a button?

It's only applying for 0,0 as that's what I initialized it to, but I have no idea how to get it to update according to which button I clicked nor do I know how to keep it from calling the method placeBattleship every time I hit a button, thus changing the location of the battleship. I know those are the only two sets of problems that are left. But I'm very tired right now and can't figure it out.

Originally Posted by helloworld922

umm... wow. Have you thought about using loops to create the buttons? That would drastically reduce the amount of code you have.

for(int i = 0; i < 10; i++)
{
     for (int j = 0; j < 10; j++)
     {
          // setup one button in here and store it into an array of buttons.
          buttons[i][j] = new Button(i + " " + j);
     }
}

Ok, nearly got it, but how do I get it from calling the method placeBattleship every time I hit a button, thus the battleship keeps moving.

Also, how to I get it i and j to the right values:

  // Programmer: Paul Adcock          //
 // Project: GUI Project    //
 // Last Modification Date: 6/2/10 //
 /* The project makes an array of up to 100 buttons.  My
	 if statements will keep asking user for a value between 2 and 10 till they do it.  Then I'm
	 going to put the battleship in the array and then going to have actionEvent deal with if it's 
	 not a hit and has a text of 0, I set them default to 0, then it changes the text of that button to an M.
	 If they shoot there again one or more times, it changes it to an A.  If they actually hit the battleship, it changes the text to 
	 an H, shows the number of shots, and then exits.  If they surrender, it asks them if they want to, and if they do, it shows the number of shots
	 and then exits.  If they quit, it asks them if they want to, and if they do, it justs says a goodbye message and exits.  */
 
   import java.awt.*;
   import java.awt.event.*;
   import javax.swing.*;
   import javax.swing.JFrame;
   import javax.swing.JDialog;
   import javax.swing.JPanel;
   import java.awt.Graphics;
   import javax.swing.ImageIcon;
   import java.util.*;
   import java.io.*;
   import java.awt.Component;
   import javax.swing.AbstractButton;
 
 
    public class BattleshipGUI extends JFrame 
    implements ActionListener
   { // beginning of class
    // label
      private JLabel shotsLabel, arraySize;
 
   // area where text is displayed and user would normally enter text but I have made it so the user can't alter the shot count.
      private JTextField shotsTF, arraySizeTF;
 
      JFrame frame;
 
      JButton [][] arrayOfButtons;
      char [][] charArray;
 
	int x, y, i, j;
 
 
   // buttons
      private JButton surrenderB, quitB;
 
      private static final int WIDTH = 500;
      private static final int HEIGHT = 500;
 
 
       public BattleshipGUI()
      { // beginning of constructor
         setTitle("Battleship Game");
         Container pane = getContentPane();
 
 
            	// makes Label for shots
         shotsLabel = new JLabel("Shots: ",
                                  SwingConstants.RIGHT);
         arraySize= new JLabel("Array Size ",
                                  SwingConstants.RIGHT);	
 
        // makes Text Field for shots and makes the text field non-editable
         shotsTF = new JTextField(7);      
         shotsTF.setEditable(false);
 
         arraySizeTF = new JTextField(2);
         arraySizeTF.setEditable(false);
 
      			// makes the buttons and sets their value initially to 0 and makes the method actionPerformed
      			// a method of the class BattleshipGUI.  I don't need individual handlers.
 
         surrenderB = new JButton("Surrender");
         surrenderB.addActionListener(this);
 
         quitB = new JButton("Quit");
         quitB.addActionListener(this);
 
      // n is the size of the grid
         int n = 0;
         String gridSizeStr, outputStr;
         boolean isInRange = false;
      // while loop and boolean allow user to keep entering int values till n is between 2 and 10.  Also, it needs to have 
      // the array of buttons  in a square shape,  and also so I can place the battleship in the array and later use actionListeners to
      // change the text to either a M, an A, or a H.  Hence why all buttons in the array have the same label to begin with.
 
         shotsTF.setText("0");
         boolean isValid = false;
 
         while (isValid == false)
         { // beginning of while
            try
            { // beginning of try
               gridSizeStr = JOptionPane.showInputDialog("Enter the size of the grid:");
               n = Integer.parseInt(gridSizeStr);
 
               if (n < 2)
                  throw new MyTooSmallException();
 
               if (n > 10)
                  throw new MyTooBigException();
 
               isValid = true;
 
            } // end of try
 
                catch ( MyTooSmallException mtse)
               { // beginning of catch
 
                  JOptionPane.showMessageDialog(null, "Enter a value that is not less than" 
                     + " 2 and is no greater than 10. " +"\n " + mtse.toString() );
 
               } // end of catch
 
                catch ( MyTooBigException mtbe)
               { // beginning of catch
 
                  JOptionPane.showMessageDialog(null, "Enter a value that is not less than" 
                     + "2 and is no greater than 10. " +"\n " + mtbe.toString() );
 
               } // end of catch
 
 
                catch (NumberFormatException nfeRef)          
               { // beginning of catch
                  JOptionPane.showMessageDialog(null,
                     "Enter an integer.  Exception "
                     + nfeRef.toString(),
                     "NumberFormatException",
                     JOptionPane.ERROR_MESSAGE);       
               } // end of catch
 
         } // end of while 
 
 
         if (n >=2 && n <= 10)
         { // beginning of if				
 
 
 
            charArray = new char[n][n];
            for (  int x = 0; x < charArray.length; x++)
            {
               for (  int y = 0; y < charArray[x].length; y++)
                  charArray[x][y] = '0'; 
 
            } 
 
             arrayOfButtons = new JButton[n][n];
 
           for ( int i = 0; i < arrayOfButtons.length; i++)
            {
               for (  int j = 0; j < arrayOfButtons[i].length; j++)
                  arrayOfButtons[i][j] = new JButton("0");
            }
 
            for (int i = 0; i < arrayOfButtons.length; i++)
            {
               for (   int j = 0; j < arrayOfButtons[i].length; j++)
                  arrayOfButtons[i][j].addActionListener(this);
            }
 
 
            for ( int i = 0; i < arrayOfButtons.length; i++)
            {
               for (   int j = 0; j < arrayOfButtons[i].length; j++)
                  pane.add(arrayOfButtons[i][j]);
            } 
 
 
 
 
 
 
 
            pane.setLayout(new GridLayout((n+1), (n+1)));
 
 
            pane.add(surrenderB);
            pane.add(quitB);
            pane.add(shotsLabel);
            pane.add(shotsTF);
 
           // the char array is where the actual 1 square battleship is going to be placed.
           // it is a n by n grid and the other array needs to be too to make them parallel.  
           // A value in the arrayOfButtons[i][j] should be the same as charArray[x][y].
 
 
 
 
         } // end of if      
 
 
 
 
      // makes an n by n grid
 
 
         setSize(WIDTH, HEIGHT);
         setVisible(true);
         setDefaultCloseOperation(EXIT_ON_CLOSE);
 
 
      } // end of constructor
 
       public static void main(String[] args)
      { // beginning of main
         BattleshipGUI refVar = new BattleshipGUI();
 
 
 
      } // end of main
 
   	// this method handles the buttons.  
       public void actionPerformed(ActionEvent e)
      { // beginning of method
         String outputStr2, outputStr3, outputStr4, outputStr5, outputStr6;
         String outputStrM, outputStrA, outputStrAA;
         outputStrM = "Miss";
         outputStrA = "Already shot there";
         outputStrAA = "I told you that you already shot there";
 
         outputStr2 = "Are you sure you want to quit? ";
         outputStr3 = "You Quit.";
         outputStr4 = "Ok don't quit then." ;
         outputStr5 = "Thought not.";
         outputStr6 = "You surrendered.";
 
 
       int i, j, x,y;
         x = 0;
         i = 0;
         y = 0;
         j = 0;
 
		/*	for (int r = 0; r < arrayOfButtons.length; r++)
			{
			for (int c = 0; c < arrayOfButtons[r].length; c++)
			if (arrayOfButtons[r][c].isSelected())
			{
			i = r;
			j = c;
			}
			} */
 
 
         int shots =  Integer.parseInt(shotsTF.getText());
 
         placeBattleship(charArray); 
 
         Integer tries;
         Integer tries2;
         Integer tries3;
         Integer tries4;
         Integer tries5;
 
         tries = shots;
         tries2 = shots;
         tries3 = shots;
         tries4 = shots;
         tries5 = shots;
 
         if (e.getActionCommand().equals("Quit"))
         { // beginning of if
            Object[] options = {"Yes",
                    "Continue Playing"};
 
            int n = JOptionPane.showOptionDialog(frame,
               "Are you sure you want to Quit?",
               "Quit",
               JOptionPane.YES_NO_OPTION,
               JOptionPane.QUESTION_MESSAGE,
               null,        options,     options[0]); 
         // creates Yes and Continue playing butons buttons.
         		// if Yee button is clicked, sends output "You quit." as heading and sends a message "Adiós!" and exits when 
         		// user clicks OK on dialog box
            if (n == JOptionPane.YES_OPTION) 
            { // beginning of if
               JOptionPane.showMessageDialog(null,"Adiós!", outputStr3,  JOptionPane.PLAIN_MESSAGE);
               System.exit(0);
            } // end of if
            // changes the string the standard dialog box for the No button but still uses its predefined return value.  If user clicks on 
            // Continue Playing, sends title "Ok don't quit then." and the message "Whatever." and takes the user back to the grid.
            else if (n == JOptionPane.NO_OPTION)
            { // beginning of else if
               JOptionPane.showMessageDialog(null,"Whatever.",  outputStr4,  JOptionPane.PLAIN_MESSAGE);
            } // end of else if
 
         } // end of if
 
         else if (e.getActionCommand().equals("Surrender"))
         { // beginning of else if
 
            Object[] options2 = {"Yes",
                    "No, I have not yet begun to fight!"};
            int p = JOptionPane.showOptionDialog(frame,
               "Are you sure you want to Surrender?",
               "Surrender?",
               JOptionPane.YES_NO_OPTION,
               JOptionPane.QUESTION_MESSAGE,
               null,        options2,   options2[0]); 
         // creates Yes and No, I have not yet begun to fight! butons .
         		// if Yes button is clicked, sends output "You surrendered." as heading and sends a message "It took you [number of shots]
         		// shots!" and exits when user clicks OK on dialog box
            if (p == JOptionPane.YES_OPTION) 
            { // beginning of if
            // code for showing grid
               arrayOfButtons[i][j].setText("B");
               JOptionPane.showMessageDialog(null, "You took "  + shotsTF.getText() + " shots" , outputStr6, JOptionPane.INFORMATION_MESSAGE);
               System.exit(0);
            } // end of if
            // changes the string the standard dialog box for the No button but still uses its predefined return value.  If user clicks on 
            // "No button", sends output "Thought not." and the title "You didn't surrender." and takes the user back to the grid.
            else if (p == JOptionPane.NO_OPTION)
            { // beginning of else if
               JOptionPane.showMessageDialog(null, outputStr5, "You didn't surrender." , JOptionPane.PLAIN_MESSAGE);
            } // end of else if
         } // end of else if
 
 
         else if (e.getActionCommand().equals("0"))
         { // beginning of else if
 
 
            if (  Fire(charArray, x, y) == 'H')
            { // beginning of if
               String outputStr7;
               arrayOfButtons[i][j].setText("H");  // changes text on button to H
               shots = shots + 1;
               tries = new Integer(shots);
               shotsTF.setText(tries.toString());
 
               outputStr7 = "You sank my battleship. " + "\n" + "You sank my battleship in " + shotsTF.getText() + " tries";
               JOptionPane.showMessageDialog(null, outputStr7 , "You win!", +  JOptionPane.INFORMATION_MESSAGE);
               System.exit(0);
            }// end of if
 
            else 
            { // beginning of else
               JOptionPane.showMessageDialog(null, outputStrM , "You missed!", +  JOptionPane.INFORMATION_MESSAGE);
               arrayOfButtons[i][j].setText("M"); // changes text on button to M
               shots = shots + 1;
               tries2 = new Integer(shots);
               shotsTF.setText(tries2.toString());
               System.out.println(arrayOfButtons[i][j]);
            } // end of else
         } // end of else if 
               // does this if text on button hit is M.
         else if (e.getActionCommand().equals("M"))
         { // beginning of else if
            shots = shots + 1;
            tries3 = new Integer(shots);
            shotsTF.setText(tries3.toString());
 
            JOptionPane.showMessageDialog(null, outputStrA , "Still a miss!", +  JOptionPane.INFORMATION_MESSAGE);
            arrayOfButtons[i][j].setText("A"); // changes text on button to A
         } // end of else if
               // does this if text on button hit is A
         else if (e.getActionCommand().equals("A"))
         { // beginning of else if
            shots = shots + 1;
            tries4 = new Integer(shots);
            shotsTF.setText(tries4.toString());
 
            JOptionPane.showMessageDialog(null, outputStrAA , "Still a miss!", +  JOptionPane.INFORMATION_MESSAGE);
            arrayOfButtons[i][j].setText("A"); // changes text, sorta, on button to A
         } // end of else if
 
      } // end of method
 
      // the method placeBattleship, places the battleship by randomly choosing a
   // row and column coordinate and storing a 'B' there.  The 'B' is not displayed to 
   // the user unless the user hits the surrender button.  It takes the array as a parameter and 
   // should return nothing.  This method sets the location of the battleship.
 
       private static void placeBattleship(char charArray[][])
      { // beginning of method placeBattleship
         int valueOne, valueTwo;
         char B;
         valueOne= (int) ( 1 + (Math.random() * charArray.length -1)); 
         valueTwo = (int) ( 1 + (Math.random() * charArray.length -1 ));
         charArray[valueOne][valueTwo] = 'B';
 
 
      } //end of method placeBattleship
 
       public static char Fire(char charArray[][], int x, int y)
      { // beginning of method Fire
         char A;
         char M;
         char H;
 
         if (charArray[x][y] == 'B')  // if battleship is hit return H and end game
         { // beginning of if statement
            charArray[x][y] = 'H';
 
 
            return ('H');
 
         } // end of if statement
 
         else if (charArray[x][y] == 'M')  // this is else if 
                                          // because it could also 
                                          // be just a miss.
 
         { // beginning of else if statement
 
            charArray[x][y] = 'A';
 
            return ('A');
         } // end of else if statement
 
         else if (charArray[x][y] == 'A') // makes sure it won't set an A to an M again.
         { // beginning of else if  
 
            charArray[x][y] = 'A';
            return ('A');
         } // end of else if
         else
 
         { // beginning of else statement
            charArray[x][y] = 'M'; 
            return ('M');                                          
         } // end of else statement
      } // end of method fire
 
 
   } // end of program

Originally Posted by Norm

Yes, you should move the assignment statements into one set of loops instead of 3.

To determine what button was clicked, you need to store some data with the button that has its x,y location.
Two ways: Look at the put/getClientProperties() methods
Extend the JButton class with a class that saves the location of the button and has a get() method to retrieve it.
In your listener use the Event.getSource() method to get a reference to the JButton object.

.. in the create buttons loop
Point loc = new Point(j, i); // save col and row
arrayBtn[i][j].putClientProperties("loc", loc);  // save location with button
...
// in listener
JButton jb = (JButton)evt.getSource();
Point loc = (Point)jb.getClientProperties("loc");  // retrieve buttons location
...

Talk to the programmer that's writing the code and have him move the call to a better location.

Well, it'll keep calling placeBattleship every time because GUIs are usually executed more than one till some condition is met.

Is there a way to store the coordinates and set them to that so that it'll always be the same no matter how many times it executes?

Calling it in main won't work. Calling it in the constructor never places the battleship. Calling it in the actionPerformed causes it to move. Where should the programmer put it?

JButton jb = (JButton)evt.getSource();

That doesn't compile.

Please post the error messages.

Where do I call placeBattleship() where it won't be called every time I hit a button?

Where do you call placeBattleship()? Is it in the listener that is called every time you hit a button?
Move it somewhere else.

Calling it in the constructor never places the battleship

Add println() statements to your code to show where the battleship is and every place where its location can be changed like when charArray's contents are changed.

Originally Posted by Norm

Please post the error messages.


Where do you call placeBattleship()? Is it in the listener that is called every time you hit a button?
Move it somewhere else.


Add println() statements to your code to show where the battleship is and every place where its location can be changed like when charArray's contents are changed.

I have an idea how to do with the moving battleship, even if I have to put it in the listener.

I can't put it sooner or it won't put it at all.

I haven't tried before the constructor but that probably won't work.

I'm hoping I can use a get text on a text field that exists but was never added to the pane, so the user can't see the coordinates, to store them in so that the first time it'll place it and add up a variable called times2 which'll change the text field times to 1 so that it'll do a different way of placing the batlteship by getting the two coordinates it give the first time from the text field and always reusing them thereafter. I hope this'll work.

Also, it was getProperty, not getProperties.

It doesn't like this:

/* JButton jb = (JButton) evt.getSource());

It doesn't like this:

What happens?

Originally Posted by Norm

What happens?

It doesn't compile. It's syntax.

Also, battleship still moving. Where should I call it?

In the listener?

In the constructor, where it'll never execute?

Somewhere else?

What's going on?

Sounds like you need to debug your system.

Add lots and lots of: System.out.println("var1= " + var1 + ", var2=" + var2);
to your code. Change var1, var2 etc as appropriate.

Yes, evt represents the Event object reference passed to the listener. I didn't look thru your code for correct spelling.
That object is the one the user clicked on. It could contain its x,y location on the nxn grid if you code it.

I never used event object before. I only suspected that as I looked up that method online and it came up in java api as coming from that class, though some classes can have the same method names, though that'll be a problem if they are in an "is a" relationship.

Ok, so what do I call the event object,

i.e.

Event object evt;

How do I put something in evt?

Look at post #57

You don't create an event object. The system passes one to the listener.

Originally Posted by Norm

You don't create an event object. The system passes one to the listener.

I don't?

So I use the actionEvent variable?

Better read up on listeners and the event objects that are passed to them.