Thread: help! messy code

hi, i would just like to ask, if it is possible to make my code looks clean? i suppose to let the user to press any key from the keyboard, determine if it is a vowel,consonant and the rest is unrecognize.. my code works,, but it's annoying to see it like this .. is there any simple and possible way to make it look good?

here's my code..

 
 
package experiment;
import java.io.*;
public class WhatDidIType {
 
    public static void main(String[]args)throws IOException{
        BufferedReader dataIn=new BufferedReader(new InputStreamReader(System.in));
 
        String in,yes;
 
        do{
        System.out.print("press any key from the keyboard:");
        String input=dataIn.readLine();
 
        if(input.equalsIgnoreCase("a") || input.equalsIgnoreCase("e")|| input.equalsIgnoreCase("i")
           || input.equalsIgnoreCase("o") || input.equalsIgnoreCase("u")){
             in="vowel";
               System.out.println(input+" is "+in);
        }
        else if(input.equalsIgnoreCase("b")|| input.equalsIgnoreCase("c")|| input.equalsIgnoreCase("d")||
                input.equalsIgnoreCase("k")|| input.equalsIgnoreCase("f")|| input.equalsIgnoreCase("g")||
                input.equalsIgnoreCase("h")|| input.equalsIgnoreCase("j")|| input.equalsIgnoreCase("l") ||
                input.equalsIgnoreCase("m") || input.equalsIgnoreCase("n")
                || input.equalsIgnoreCase("p") || input.equalsIgnoreCase("q") || input.equalsIgnoreCase("r")
                || input.equalsIgnoreCase("s") || input.equalsIgnoreCase("t") || input.equalsIgnoreCase("v")
                || input.equalsIgnoreCase("w") || input.equalsIgnoreCase("x") || input.equalsIgnoreCase("y")
                || input.equalsIgnoreCase("z")){
 
                  in="consonant";
                    System.out.println(input+" is "+in);}
 
          else{
 
                 System.out.println("Unrecognized");}
 
                 System.out.print("Try again y/n: ");
                 yes=dataIn.readLine();}
 
              while(yes.equalsIgnoreCase("y"));
                  System.out.println("Bye Bye!!"); }
            }

i just want to know how to do it properly,,, any help/suggestions will help ^^,

tnx in advance..

You could maybe have 2 arrays 1 of vowels and 1 of consonants and then check if the key pressed is in either.

Or you could use the Character.isLetter() method:
Character (Java 2 Platform SE v1.4.2)

change input to a character and then say something like

if(input.toLowerCase == 'a'|| etc) //I dont think theres a equalsIgnoreCase but I think this would work
System.out.println("Vowel");
else if(input.isLetter() == true)
System.out.println("Consonant");
else
System.out.println("Unrecognised");

Or something like that maybe use an array of vowels instead of comparing them all.

Is that what you meant?

Considering the semantics of the problem, String#contains(...) is a better choice than String#indexOf(...) and has the added advantage of not requiring a secondary comparison with -1.

db