Thread: Problem in rotating and moving image at the same time

hello every one hope fine
im making a car game in which you have an upper view of car
problem is that i cant make the car rotate and move at the same time
mean if i press up and right arrow key at the same time it just rotate or move forward
can any one know how to do both things at the same time
and also the car speed is very fast how can i make it moderate??
here is the code

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import java.awt.geom.*;
import java.applet.*;
import java.net.URL;
 
public class RaceGame extends JComponent
{
 
static int x=560;
static int  y=410;
 
static int currentAngle=0;
static double hspeed,vspeed;
static int carspeed=0;
 
double hangle,vangle;
 
Image car;
Image finish;
 
 
Image getImage(String filename)
{    	
URL url = getClass().getResource(filename); 
 
ImageIcon  icon = new ImageIcon(url);    
return icon.getImage();
}
 
 
public RaceGame()
{
car=getImage("car1.jpeg");
//finish=getImage("finish.jpg");
 
 
}
 
 
 
public void CreateBase()
{
JFrame frame=new JFrame("Dare2Race");
frame.setBounds(70,30,650,500);
frame.setVisible(true);
frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
 
 
Container c=frame.getContentPane();
c.add(new RaceGame());
 
frame.addKeyListener(new adapter());
c.setBackground(Color.BLACK);
 
 
}
 
 
public void rotate()
{
currentAngle+=1;
 
if(currentAngle>=360)
{
currentAngle=0;
}
repaint();
}
 
 
public void paint(Graphics g)
{
super.paint(g);
 
Graphics2D g2d=(Graphics2D)g;
 
AffineTransform origXform=g2d.getTransform();
AffineTransform newXform=(AffineTransform)(origXform.clone());
 
newXform.rotate(Math.toRadians(currentAngle),x,y);
 
g2d.setTransform(newXform);
 
//g2d.drawImage(finish,12,10,this);
g2d.drawImage(car,x,y,this);
 
g2d.setTransform(origXform);
 
g.setColor(Color.WHITE);
g.drawLine(640,380,420,380);
g.drawLine(640,460,320,460);
g.drawLine(420,380,420,300);
g.drawLine(320,460,320,380);
g.drawLine(420,300,125,300);
g.drawLine(320,380,230,380);
g.drawLine(230,380,230,460);
g.drawLine(230,460,2,460);
g.drawLine(125,300,125,370);
g.drawLine(125,370,105,370);
g.drawLine(2,460,2,180);
g.drawLine(105,370,105,300);
g.drawLine(2,180,450,180);
g.drawLine(105,300,105,250);
g.drawLine(105,250,550,250);
g.drawLine(550,250,550,20);
g.drawLine(550,20,275,20);
g.drawLine(450,180,450,100);
g.drawLine(450,100,360,100);
g.drawLine(360,100,360,160);
g.drawLine(360,160,10,160);
g.drawLine(10,160,10,30);
g.drawLine(275,20,275,90);
g.drawLine(275,90,110,90);
g.drawLine(110,90,110,30);
repaint();
}
 
 
 
 
class adapter extends KeyAdapter
{
 
 
public void keyPressed(KeyEvent e)
{
 
  switch(e.getKeyCode())
  {
    case KeyEvent.VK_LEFT:
 
 
    currentAngle--;
    repaint();
    break;
 
    case KeyEvent.VK_RIGHT:
 
 
    currentAngle++;
    repaint();
    break;
 
    case KeyEvent.VK_UP:
 
    carspeed++;
 
    hangle=Math.toRadians(currentAngle);
    vangle=Math.toRadians(currentAngle);
 
    hspeed=((double)carspeed)*Math.cos(hangle);
    vspeed=((double)carspeed)*Math.sin(vangle);
 
    x = x - (int) hspeed;
    y = y - (int) vspeed;
 
    repaint();
    break;
 
    case KeyEvent.VK_DOWN:
 
    carspeed--;
 
    hangle=Math.toRadians(currentAngle);
    vangle=Math.toRadians(currentAngle);
 
    hspeed=((double)carspeed)*Math.cos(hangle);
    vspeed=((double)carspeed)*Math.sin(vangle);
 
    x = x + (int)hspeed;
    y = y + (int)vspeed;
    repaint();
    break;
  }
 
 
 
}
 
 
} 
 
 
 
 
public static void main(String[]args)
{
 
RaceGame race=new RaceGame();
race.CreateBase();
//race.setDoubleBuffered(true);
}
}

One suggestion so far: do the setVisible() call after everything is ready to be shown.

The problem is that both keys aren't registering in a text field or notepad or something hold down 1 for a while then hold down 2(don't release 1) what happens? I think this is the same problem here you could try something with threads too be honest I'm not sure how you would get that to work so do a bit of searching .

Although one idea does spring to mind say if you had a few booleans say one for each direction and when a key stroke for that direction is detected (pressed) set the boolean as true and when it's released set it to false. And rather then have the commands carry out in the keys themselves have a method that does the work based on what booleans are true and is invoked with each keyPressed.

As for the carSpeed being too fast instead of carSpeed++ change it to a double and say something like carSpeed += .2

You'll most likely need to store which buttons are pressed and deal with the combinations as they present themselves. You can keep an array which corresponds to each key, set their values upon keyPressed and unset upon keyReleased events.
Pseudo-code

boolean[] val = new boolean[4];//0 = left, 1 = up, 2 = right, 3 = down
//initialize the above to false upon construction
 
....
public void keyPressed(KeyEvent e){
 
case VK_LEFT:
 
     val[0] = true;
    if ( val[1] ){//up is pressed as well
       ///VK_LEFT and VK_UP
    }else if ( val[3] ){//down is pressed as well
       //VK_LEFT and VK_DOWN
    }else{
        //only VK_LEFT
    }
}
public void keyReleased(KeyEvent e){
//reset the value for the appropriate key
case VK_LEFT:
   val[0] = false;
///...and so on
}

If you need to deal with button holds, you need to go into either a while loop or spawn a new Timer to deal with the continued event

On Windows: Look at how the keyboard responses are set in the Control panel. It will effect how fast you get events.

Add some println() statements to all the listener methods to display when they are called and with what key. You can see how/when the system sends events to the listeners.

Thanks every one for help bt i dont know how to use timer
and if i use while it goes into infinite loop
any other help any one

What did you see when you added the print statements to the listener? Did the printed output occur in realtime with your key presses or were there delays, batching and some missed presses?

Originally Posted by SlimShady

Thanks every one for help bt i dont know how to use timer
and if i use while it goes into infinite loop
any other help any one

How to Use Swing Timers (The Java™ Tutorials > Creating a GUI With JFC/Swing > Using Other Swing Features)

Working off the code I posted above, and using the array which specifies if a key is held, you can do something like the following (in semi-pseudo-code: you'd need to implement for each direction).

private Timer leftHold = null;
private class LeftTimerListener implements ActionListener{
    public void actionPerformed(ActionEvent e){
        //increment your rotation value
        //repaint your JPanel
       if ( !val[0] ){
            leftHold.stop();
       }
    }
}
....
//in the key listener
case VK_LEFT:
     val[0] = true;
     leftHold = new Timer(60, new LeftTimerListener());//fires every 60ms
     leftHold.start();

I will note that keyTyped events are fired when the key is held, however the method above makes the timing much easier to control which may be necessary in your case (for example, on the systems I know the second keyTyped event is fired only after a long delay)

the second keyTyped event is fired only after a long delay)

On WinXP the delay can be set in the Control panel

Originally Posted by Norm

On WinXP the delay can be set in the Control panel

Perhaps, but in my view this defeats the purpose of write once run anywhere since other systems may not have that option (you would also have to ask the user to change it or potentially effect the performance of other applications by having the app change it directly). If the timing is hardcoded in, this isn't even an issue. Just my .02

Right.
The OP is getting real-time responses to key presses. I don't know if that is possible because of these OS things.