Thread: Incompatible Types

Hello! I'm creating something sort of like a turn-based battle system to sharpen my Java skills, but I'm getting this error on lines 40 and 44, and I'm not exactly sure why. Here's my code:

import javax.swing.*;
import java.io.*;
import java.util.Random;
class TBBS
{
	public static void main(String[]args)
	{
	    int attackbonus, defensebonus, hpbonus, enemyhp, enemyattack, enemydefense, hp, attack, defense, level, s1;
		String select, s;
		enemyhp=5;
		enemyattack=1;
		enemydefense=0;
		hp=10;
		attack=2;
		defense=0;
		level=1;
 
		JOptionPane.showMessageDialog(null, "Welcome to the battle system!", "Welcome!", JOptionPane.INFORMATION_MESSAGE);
		Options(s);
 
	}	
 
	static void Options(String s)
	{
	  Object[] possibility = {"Attack", "Defend"};
		s = (String)JOptionPane.showInputDialog(null, "What do you want to do?", "Action Commands", JOptionPane.PLAIN_MESSAGE,
		null, possibility, "");
 
	}
   static void levelup(String b, int level)
	{
		int attack, defense, hp, s1;
		level=(level+1);
		Object[] levelup = {"Attack", "Defense", "HP"};
		b = (String)JOptionPane.showInputDialog(null, "You've grown to level " + level + "! Which stat do you want to increase?", "Level Up!", JOptionPane.PLAIN_MESSAGE,
		null, levelup, "");
 
		s1=Integer.parseInt(b);
 
		if (s1=1)
		{
			attack=(attack+1);
		}	
		else if (s1=2)
		{
			defense=(defense+1);
		}
		else
		{
			hp=(hp+5);
		}		
	}
}

Any help would be greatly appreciated!

A typical single equals-sign (=) is used for declaring variables. The return-statement of inx x = y (which is basically what s1 = 1 means) isnt a boolean value which is needed for the if-statement.

Try s1 == 1 instead, just add another equals sign and give it a go.

I'm getting this error

Please post full text of the error message here. It helps solving the problem

Originally Posted by Charlie

A typical single equals-sign (=) is used for declaring variables. The return-statement of inx x = y (which is basically what s1 = 1 means) isnt a boolean value which is needed for the if-statement.

Try s1 == 1 instead, just add another equals sign and give it a go.

Oh, wow. I can't believe I forgot that. Thanks!

Also, I'm sorry I didn't put the error message in the post; I put it in the title instead, but I will change this when posting future errors.