Thread: SQL query not working

import java.net.*;
import java.sql.*;
import java.io.*;
import java.util.*;
 
class MakeDB
{
 
     public static void main (String args[])
     {
          try
          {
               Class.forName("sun.jdbc.odbc.JdbcOdbcDriver"); // force loading of driver
               String url = "jdbc:odbc:AMINO";
               String user = "";
               String password = "";
               Connection con = DriverManager.getConnection(url,user,password);
               Statement stmt = con.createStatement();
 
               stmt.executeUpdate("CREATE TABLE AMINO_ABBREV (AMINO_NAME VARCHAR(25), ONE_LTR 
 
VARCHAR(1), THREE_LTR VARCHAR(3))");
 
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Alanine', 'A', 'Ala')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Arginine', 'R', 'Arg')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Asparigine', 'N', 
 
'Asn')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Aspartic Acid', 'D', 
 
'Asp')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Cysteine', 'C', 'Cys')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Glutamine', 'Q', 'Gln')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Glutamic Acid', 'E', 
 
'Glu')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Glcyine', 'G', 'Gly')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Histidine', 'H', 'His')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Isoleucine', 'I', 
 
'Ile')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Leucine', 'L', 'Leu')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Lysine', 'K', 'Lys')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Methionine', 'M', 
 
'Met')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Phenylalanine', 'F', 
 
'Phe')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Proline', 'P', 'Pro')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Serine', 'S', 'Ser')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Threonine', 'T', 'Thr')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Tryptophan', 'W', 
 
'Trp')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Tyrosine', 'Y', 'Tyr')");
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Valine', 'V', 'Val')");
 
               ResultSet aminoRS = stmt.executeQuery("SELECT AMINO_NAME, ONE_LTR, THREE_LTR 
 
FROM AMINO_ABBREV");
               System.out.println("**aminoRS created");
               while(aminoRS.next())
               {
                    String aminoName = aminoRS.getString("AMINO_NAME");
                    String oneLtr = aminoRS.getString("ONE_LTR");
                    String threeLtr = aminoRS.getString("THREE_LTR");
                    String spcr = "          ";
                    System.out.println(aminoName + " " + oneLtr + " " + threeLtr);
               }
 
               System.out.println();
 
               stmt.executeUpdate("INSERT INTO AMINO_ABBREV VALUES('Selenocysteine', 'U', 
 
'Sec')");
 
               aminoRS=stmt.executeQuery("SELECT AMINO_NAME, ONE_LTR, THREE_LTR FROM 
 
AMINO_ABBREV");
               while(aminoRS.next())
               {
                    String aminoName = aminoRS.getString("AMINO_NAME");
                    String oneLtr = aminoRS.getString("ONE_LTR");
                    String threeLtr = aminoRS.getString("THREE_LTR");
                    String spcr = "          ";
                    System.out.println(aminoName + " " + oneLtr + " " + threeLtr);
               }
 
               stmt.executeUpdate("CREATE TABLE AMINO_PROP (AMINO_NAME VARCHAR(25), MOL_WT 
 
FLOAT)");
 
 
               String updateStr = "UPDATE AMINO_PROP SET MOL_WT=? WHERE AMINO_NAME=?";
 
               PreparedStatement ps = con.prepareStatement(updateStr);
               String aminosAry[] = {"Alanine", "Arginine", "Asparigine", "Aspartic Acid", 
 
"Cysteine", "Glutamine", "Glutamic Acid", "Glcyine", "Histidine", "Isoleucine", "Leucine", 
 
"Lysine", "Methionine", "Phenylalanine", "Proline", "Serine", "Threonine", "Tryptophan", 
 
"Tyrosine", "Valine"};
               double molWtAry[] = {89.09, 174.20, 132.12, 133.10, 133.10, 146.15, 147.13, 
 
75.07, 155.16, 155.16, 131.17, 146.19, 149.21, 165.19, 240.30, 105.09, 119.12, 204.23, 181.19, 
 
117.15};
 
               /*for (int stmtRep = 0; stmtRep < molWtAry.length; stmtRep++)
               {
                    ps.setString(2, aminosAry[stmtRep]);
                    ps.setDouble(1, molWtAry[stmtRep]);
                    ps.executeUpdate();
               }*/
 
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Alanine', 89.09)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Arginine', 174.20)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Asparigine', 132.12)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Aspartic Acid', 133.10)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Cysteine', 121.16)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Glutamine', 146.15)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Glutamic Acid', 147.13)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Glcyine', 75.07)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Histidine', 155.16)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Isoleucine', 131.17)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Leucine', 131.17)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Lysine', 146.19)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Methionine', 149.21)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Phenylalanine', 165.19)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Proline', 240.30)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Serine', 105.09)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Threonine', 119.12)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Tryptophan', 204.23)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Tyrosine', 181.19)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Valine', 117.15)");
               stmt.executeUpdate("INSERT INTO AMINO_PROP VALUES('Selenocysteine', 168.05)");
 
               System.out.println();
 
               ResultSet molWtRS = stmt.executeQuery("SELECT AMINO_NAME, MOL_WT FROM 
 
AMINO_PROP");
 
               while(molWtRS.next())
               {
                    String aminoName = molWtRS.getString("AMINO_NAME");
                    double molWt = molWtRS.getDouble("MOL_WT");
                    String spcr = "          ";
                    System.out.println(aminoName + " " + molWt);
               }
 
               String combQ = "SELECT AMINO_ABBREV.AMINO_NAME, AMINO_ABBREV.ONE_LTR, 
 
AMINO_ABBREV.THR_LTR, AMINO_PROP.MOL_WT FROM AMINO_ABBREV, AMINO_PROP  WHERE 
 
AMINO_ABBREV.AMINO_NAME = AMINO_PROP.AMINO_NAME";
 
               System.out.println(combQ);
               ResultSet aminoMolWtRS = stmt.executeQuery(combQ);
               System.out.println("**ResultSet created");
               while(aminoMolWtRS.next())
               {
                    String aminoName = aminoRS.getString("AMINO_ABBREV.AMINO_NAME");
                    String oneLtr = aminoRS.getString("AMINO_ABBREV.ONE_LTR");
                    String threeLtr = aminoRS.getString("AMINO_ABBREV.THR_LTR");
                    double molWt = molWtRS.getDouble("AMINO_PROP.MOL_WT");
                    String spcr = "          ";
                    System.out.println(aminoName + " " + oneLtr + " " + threeLtr + " " + 
 
molWt);
               }
 
 
               stmt.close();
               con.close();
          }
          catch (Exception ex)
          {
               System.out.println ("Exception "+ ex);
          }
     }
}

The last query throws following exception:

Exception java.sql.SQLException: [Microsoft][ODBC Microsoft Access Driver] Too few 
 
parameters. Expected 1.

The code excutes as expected until

               ResultSet aminoMolWtRS = stmt.executeQuery(combQ);

which leads me to believe that there is something wrong with my query statement:

               String combQ = "SELECT AMINO_ABBREV.AMINO_NAME, AMINO_ABBREV.ONE_LTR, 
 
AMINO_ABBREV.THR_LTR, AMINO_PROP.MOL_WT FROM AMINO_ABBREV, AMINO_PROP  WHERE 
 
AMINO_ABBREV.AMINO_NAME = AMINO_PROP.AMINO_NAME";

I tried to follow the syntax that I found on

[url=http://download.oracle.com/javase/tutorial/jdbc/basics/joins.htmlthis page[/url]:

String query = "
SELECT COFFEES.COF_NAME " +
   "FROM COFFEES, SUPPLIERS " +
   "WHERE SUPPLIERS.SUP_NAME LIKE 'Acme, Inc.' " +
   "and SUPPLIERS.SUP_ID = COFFEES.SUP_ID";

but of course I want to do something somewhat different.

Basically, I have two tables, AMINO_ABBREV and AMINO_PROP, and both have as their first column
AMINO_NAME. I want to print all the columns in the AMINO_ABREV table and the MOL_WT column is

the AMINO_PROP table, so that they appear in the following order:

1. AMINO_ABBREV.AMINO_NAME
2. AMINO_ABBREV.ONE_LTR
3. AMINO_ABBREV.THR_LTR
4. AMINO_PROP.MOL_WT

How would I modify my query to do so?

This is more of an SQL and not java...nevertheless:
1) Can you execute the query using a command line interface to the database without a problem? This is always the best way to get a feel for the queries and validate they are working properly.
2) Try modifying the query to explicitly use a JOIN...something like

SELECT * FROM AMINO_ABBREV JOIN AMINO_PROP using (AMINO_NAME)

(I placed a star in there for brevity, typically you want to select only what you need)

Originally Posted by copeg

This is more of an SQL and not java...nevertheless:

Is there a better bioard on which to post JDBC question where the problem is mostly with the SQL?

Originally Posted by copeg

1) Can you execute the query using a command line interface to the database without a problem? This is always the best way to get a feel for the queries and validate they are working properly.

How would you do this?

Originally Posted by copeg

2) Try modifying the query to explicitly use a JOIN...something like

SELECT * FROM AMINO_ABBREV JOIN AMINO_PROP using (AMINO_NAME)

This throws the following exception:

Exception java.sql.SQLException: [Microsoft][ODBC Microsoft Access Driver] Syntax error in FROM clause

However, when I remove the JOIN clause it throws:

Exception java.sql.SQLException: [Microsoft][ODBC Microsoft Access Driver] Result set closed.

which is strange because I think it is identical to:

               ResultSet aminoRS = stmt.executeQuery("SELECT AMINO_NAME, ONE_LTR, THREE_LTR FROM AMINO_ABBREV");

and that prints the AMINO_ABBREV table as expected earlier in the program.

Originally Posted by copeg

As for the command line interface, most databases I've worked with all have some sort of utility that allows access to the database via the command line. I'd suggest trying to a) see if you have one already installed with the database you are using or b) find one which you can install. This is the best way to become familiar with and test SQL queries...with all the exceptions you are getting - especially for the 'select *' query, running that identical query via the command line would probably give you a much more informative error message, and if there isn't an error message this lets you know there is something amiss with your java code and not the SQL code. The join should work, but there may be a specific syntax to the database you are using.

As for other SQL board, not sure as I don't frequent any myself.

I'm just using a standard Microsoft Access DB with a JDBC:ODBC connection. I was under the impression that SQL work under those condition. However, I only know enough SQL to create tables and query columns from individual tables. The course that i am taking right now is a Java programming course and the instructor only covered SQL insofar as it could be used to create tables and query them using the JDBC:ODBC bridge.

I've never used Access, so cannot point you in the direction of a low level interface. Let's step back for a second...your original post, on what line was the exception being thrown?

Originally Posted by copeg

Nevermind...simple solution which I can't believe I overlooked...

Check your ResultSet variables...so this was a java problem after all

               ResultSet aminoMolWtRS = stmt.executeQuery(combQ);
               System.out.println("**ResultSet created");
               while(aminoMolWtRS.next())
               {
                  /** Don't you want to access aminoMolWtRS?***/
                    String aminoName = aminoRS.getString("AMINO_ABBREV.AMINO_NAME");
                    String oneLtr = aminoRS.getString("AMINO_ABBREV.ONE_LTR");
                    String threeLtr = aminoRS.getString("AMINO_ABBREV.THR_LTR");
                    double molWt = molWtRS.getDouble("AMINO_PROP.MOL_WT");
                    String spcr = "          ";
                    System.out.println(aminoName + " " + oneLtr + " " + threeLtr + " " +
 
molWt);
               }

Which version of combQ did you use?

Originally Posted by mjpam

Which version of combQ did you use?

Not sure what combQ is

Did you change the variable names, and did this solve your problem?

Originally Posted by copeg

Not sure what combQ is

Did you change the variable names, and did this solve your problem?

Here is what I have now:

               String combQ = "SELECT AMINO_NAME, ONE_LTR, THREE_LTR FROM AMINO_ABBREV JOIN AMINO_PROP ON AMINO_ABBREV.AMINO_NAME=AMINO_PROP.AMINO_NAME";
 
               System.out.println(combQ);
               ResultSet aminoMolWtRS = stmt.executeQuery(combQ);
               System.out.println("**ResultSet created");
               System.out.println(aminoMolWtRS.next());
               while(aminoMolWtRS.next())
               {
                    String aminoName = aminoMolWtRS.getString("AMINO_ABBREV.AMINO_NAME");
                    String oneLtr = aminoMolWtRS.getString("AMINO_ABBREV.ONE_LTR");
                    String threeLtr = aminoMolWtRS.getString("AMINO_ABBREV.THREE_LTR");
                    double molWt = aminoMolWtRS.getDouble("AMINO_PROP.MOL_WT");
                    String spcr = "          ";
                    System.out.println(aminoName + " " + oneLtr + " " + threeLtr /*+ " " + molWt*/);
               }

This throws:

Exception java.sql.SQLException: [Microsoft][ODBC Microsoft Access Driver] Too few parmeters. Expected 1.

              String combQ = "SELECT AMINO_ABBREV.AMINO_NAME, AMINO_ABBREV.ONE_LTR, AMINO_PROP.THREE_LTR FROM AMINO_ABBREV, AMINO_PROP";
 
               System.out.println(combQ);
               ResultSet aminoMolWtRS = stmt.executeQuery(combQ);
               System.out.println("**ResultSet created");
               System.out.println(aminoMolWtRS.next());
               while(aminoMolWtRS.next())
               {
                    String aminoName = aminoMolWtRS.getString("AMINO_ABBREV.AMINO_NAME");
                    String oneLtr = aminoMolWtRS.getString("AMINO_ABBREV.ONE_LTR");
                    String threeLtr = aminoMolWtRS.getString("AMINO_ABBREV.THREE_LTR");
                    double molWt = aminoMolWtRS.getDouble("AMINO_PROP.MOL_WT");
                    String spcr = "          ";
                    System.out.println(aminoName + " " + oneLtr + " " + threeLtr /*+ " " + molWt*/);
               }

This throws:

Exception java.sql.SQLException: [Microsoft][ODBC Microsoft Access Driver] Syntax error in FROM clause

The second query looks like it needs a WHERE in order to join the tables (see your original query syntax). The first may be an issue with selecting too few parameters (eg you select 3 but try to retrieve 4 from the ResultSet). Posting the lines where the exceptions are thrown would be very helpful