Thread: help im stumped :(

int num;
int i = 2;
int j;
String yn;




do {
System.out.print("Enter number : ");
num = input.nextInt();

do{
while (num % i == 0){
j = num/i;
num = j;
System.out.print(i + " ");

if (num % i != 0)
i++;
}



}
while (num % i == 0);


System.out.println();
System.out.println("\nDo you Wish to enter another? (Y/N) : ");
yn = input.next();

}

while (yn.charAt(0) == 'Y');





}
}


if i enter 120 it only outputs 2 2 2 3,



but it needs to output 2 2 2 3 5


what am i doing wrong?


and also how can i println

The Factors are : 2 2 2 3.... a continous output...

Have you worked thru the algorithm you are using manually?
Does it produce the answers you want?

Do you want to debug your code or are you asking some one else to debug it for you?
If you want to debug it, Add some debugging print outs to show ALL the values of the variables and the computations as the loop progresses.

Also, I think your post may have been answered already in your other thread.

import java.util.Scanner;
 
public class Factor {
 
	public static void main(String[] args){
		Scanner input=new Scanner (System.in);
 
		String yn;
		int number;
		int current;
		String output = "";
		int x;
		int i = 2;
 
		System.out.print("Enter a number to factor : ");
		number = input.nextInt();
 
 
 
 
		while (number % 2 == 0)
		{
			output += 2 +" ";
			number /= 2;
		}
 
		x = number;
 
		while (i <= x)
		{
			if (x % i == 0)
			{
				output += i + " ";
				x /= i;
				//I added from here
				if(x % i == 0){
					i--;
				}
				//to here
			}
			i++;
		}
 
 
 
		System.out.println("Factors are : " + output);
 
	}
}

import java.util.Scanner;
 
public class Factor {
 
	public static void main(String[] args){
		Scanner input=new Scanner (System.in);
 
		int number;
		String output = "";
		int x;
		int i = 2;
 
		System.out.print("Enter a number to factor : ");
		number = input.nextInt();
 
 
 
 
		while (number % 2 == 0)
		{
			output += 2 +" ";
			number /= 2;
		}
 
		x = number;
 
		while (i <= x)
		{
			while(x % i == 0)
			{
				output += i + " ";
				x /= i;
			}
			i++;
		}
 
 
 
		System.out.println("Factors are : " + output);
 
	}
}

I know I posted the solution javapenguin pasted here, but this slightly different solution makes it more obvious what is going on.

makes it more obvious what is going on.

Why don't you comment your code to actually tell anyone what is going on?

Originally Posted by Norm

Why don't you comment your code to actually tell anyone what is going on?

Because it isn't my code..... It is the OP's from his last thread on this same exact topic. Why don't you comment other peoples homework code for them? Go ahead, the code is right there. Might as well turn it in for him too.

And outside of the code snippet in that thread, I did explain what the code I added was doing. Thanks for your insight though, it is really helpful!