Thread: Can't get seven random numbers, only one.

I want my program to show seven random numbers, but it does only display one. I got this in a class:

if (command.equals("Random numbers")) {
			int tal = modell.getTal();
			vy.skrivNyLottorad(tal);
		}

getTal is in the class Model:

public class Model {
	private int tal;
 
	public int getTal() {
		Random randomNr = new Random();
 
		for (int i = 0; i < 7; i++) {
			tal = randomNr.nextInt(35);
		}
		return tal;
	}

The method skrivNyLottorad from the first piece of code is here:

public void skrivNyLottorad(int lottorad) {
		textruta.append(lottorad + "\n");
	}

What is my problem? it should display seven numbers, but it does only display one.

You are correctly generating 7 random numbers. However after you generate each random number, you are storing it in the int variable tal, effectively overwriting the last random number you generated. After you do this 7 times, you are returning the 7th random int you generated.

Here are some more of the code. I thought that was the problem, that the last number is the number that is going to display. So I think, that I have to store all seven numbers in a string? or char? how do I do that?

val1 = new JMenuItem("Random numbers");
		val1.addActionListener(kontroll);

if (command.equals("Random numbers")) {
			int tal = modell.getTal();
			vy.skrivNyLottorad(tal);
		}

import java.util.Random;
 
public class Model {
	private int tal;
 
	public int getTal() {
		Random randomNr = new Random();
 
		for (int i = 0; i < 7; i++) {
			tal = randomNr.nextInt(35);
		}
		return tal;
	}
 
	public static void main(String[] args) {
		Model modell = new Model();
		System.out.println(modell.getTal());
	}
}

public void skrivNyLottorad(int lottorad) {
		textruta.append(lottorad + "\n");
	}

You could always store each value in an array and then you'd have them all.

int [] tal = new int[7];

for (int x =0; x < tal.length; x++)
{
tal[x] = randomNr.nextInt(35);

}