Thread: Code is correct, but incorrect output?

class div
{
public static boolean div(int x, int y)
{
boolean pig;
pig=x%y==0;
if(pig)
return pig; 
else 
return !pig;
}
public static void main(String args[])
{
int a,b;
boolean result;
a=7;
b=3;
result=div(a,b);
System.out.println(result);
}
}

As far as I can see the code is correct.... But i keep getting the output as true instead of false... Why isn't the complement (!) not working?

I don't understand what your trying to accomplish with this code. What do you want the code to do?

It looks like div is suppose to return if an integer x is divisible by y?

Try stepping through the code (i.e. pretend you're the computer).

1. pig = true or false
4. if (pig == true)?
4a. return pig => return true
5. if (pig == false)?
5a. return !pig => return !false => return true

no matter what pig is, you're always returning true.

Generally you want to create variable names that make sense. x,y, and pig give no indication what that variable is used for. Use a variable name such as numerator, divisor, and isDivisible.

or just use return pig;, no if/else required.