Thread: Faster Run Time - Scanner(file) and Arrays

I have a working code right now, it does what I want it to do, which is loading text from a txt file and loading it into an arrayList, line by line. Three of them, to be exact. This is remake of the Pokemon games, Nintendo's ideas, not mine. I just wanted to write it in Java to test myself.

The code runs fine but it takes about three minutes to compile. It isn't my computer, as far as I can tell. Is there a faster way to write my code?

for (int count = 0; count < (pokemonsTypeCheck.size()); count++){
	File typeList1 = new File("C:\\Users\\Jacob\\Desktop\\types1.txt");
	File typeList2 = new File("C:\\Users\\Jacob\\Desktop\\types2.txt");
	final Scanner types1 = new Scanner(typeList1);
	final Scanner types2 = new Scanner(typeList2);
	String currentLine;
	int spareCounter=0;
	while (types1.hasNext()){
		typesList1.ensureCapacity(spareCounter);				
		currentLine = types1.nextLine();
		typesList1.add(spareCounter, currentLine);
		spareCounter++;
	}
	spareCounter=0;
	while (types2.hasNext()){
		typesList2.ensureCapacity(spareCounter);
		currentLine = types2.nextLine();
		typesList2.add(spareCounter, currentLine);
		spareCounter++;
	}
}
System.out.print(pokemonsTypeCheck.get(pokemonNumber)+" is a "+typesList1.get(pokemonNumber));
if (typesList2.get(pokemonNumber).equals(" ")){
	System.out.println(" type.");
}
else{
	System.out.println("/"+typesList2.get(pokemonNumber)+" type.");
}

Sorry, yeah, the run time is what's killing me. I don't see how BufferedReader putting the data in the array would help speed up the process. It would still have the same looping and runtime as Scanner(file) putting the data into an array, wouldn't it?

My problem still hasn't been helped. :/ I tried using a BufferedReader, and a FileReader to gain access to the txt file. The run time is still about the same length. Is there any other possibility that would help me out?

I have the files loaded up this way:

public static void main(String[]args){
	Battler battle = new Battler();
	try {
		battle.loadPokemon("pokemons.txt", "types1.txt", "types2.txt");
	} catch (NoSuchElementException e) {
		e.printStackTrace();
	} catch (FileNotFoundException e){
		e.printStackTrace();
	}
	battle.runner();
}

...

public void loadPokemon(String pokemonList, String typeList1, String typeList2) throws NoSuchElementException, FileNotFoundException{

for (int count = 0; count < (pokemonsTypeCheck.size()); count++){
	//File typeList1 = new File("types1.txt");
	//File typeList2 = new File("types2.txt");
	//final Scanner types1 = new Scanner(typeList1);
	//final Scanner types2 = new Scanner(typeList2);
	BufferedReader types1 = new BufferedReader(new FileReader(typeList1));
	BufferedReader types2 = new BufferedReader(new FileReader(typeList2));
	int spareCounter=0;
	try {
		while ((typesCheck1=types1.readLine()) !=null){
			typesList1.ensureCapacity(spareCounter);				
			typesList1.add(spareCounter, typesCheck1);
			spareCounter++;
		}
	} catch (IOException e1) {
		// TODO Auto-generated catch block
		e1.printStackTrace();
	}
	spareCounter=0;
	try {
		while ((typesCheck2=types2.readLine()) !=null){
			typesList1.ensureCapacity(spareCounter);				
			typesList1.add(spareCounter, typesCheck2);
			spareCounter++;
		}
	} catch (IOException e) {
		// TODO Auto-generated catch block
		e.printStackTrace();
	}
}
 
System.out.print(pokemonsTypeCheck.get(pokemonNumber)+" is a "+typesList1.get(pokemonNumber));
if (typesList2.get(pokemonNumber).equals(" ")){
	System.out.println(" type.");
}
else{
	System.out.println("/"+typesList2.get(pokemonNumber)+" type.");
}

Any help would be appreciated. Right now, the run time is about three to five minutes. I suppose I could always go in and hard code the ArrayLists, but that seems extremely problematic, as all three of the ArrayLists are 600+ strings long.

It's just three text files. 3kb, 5kb, and 6kb. Each have 646 lines with one(or just a space) word on each line.

The idea was using the first text file, comparing that to the user entered string to find a match in the ArrayList, then using the index of the matching string to compare to the other two ArrayLists to get the two types of the Pokemon that the user entered.

i.e. User enters: Blastoise
Output: You have chosen Blastoise!
Blastoise is a water type pokemon!

The type comes from the second and third ArrayLists, because some pokemon have two types.

Originally Posted by helloworld922

This is rather worrying (it's in a few other places, too). You shouldn't manually ensure the capacity each time through the loop (especially if you're only ensuring the capacity to be 1 larger).

If you have an idea of what the ball-park size should be, call ensureCapacity once with this value. Otherwise, let the ArrayList automatically expand the capacity as it sees fit (or use a combination of the two).

I took out the EnsureCapacities and put them at the end of the looping setup. So now it adds them automatically as it sees fit, and then the number of Strings in each array is hardcoded in, because I know the exact number that exists. I got an error, rangeCheck or something.

Output[the initial "Blastoise" is user entered]:
Name of Player 1's Pokemon: Blastoise
You have chosen Blastoise!
Blastoise is a Exception in thread "main" java.lang.IndexOutOfBoundsException: Index: 8, Size: 0
at java.util.ArrayList.RangeCheck(Unknown Source)
at java.util.ArrayList.get(Unknown Source)
at Battler.loadPokemon(Battler.java:157)
at Battler.main(Battler.java:448)

I got it to work. I moved around the EnsureCapacity and messed with it some more. I figured I could do it all in one loop, as far as the last two ArrayLists went, using the size of the first arrayList to ensure the capacity of the others. :3 Thanks for all the help, guys. Sorry for being a bother ;P

typesList1.ensureCapacity(pokemonsTypeCheck.size());
		typesList2.ensureCapacity(pokemonsTypeCheck.size());
		for (int count = 0; count < (pokemonsTypeCheck.size()); count++){
			//File typeList1 = new File("types1.txt"); //Buffered Reader    		//Fix
			//File typeList2 = new File("types2.txt");
			//final Scanner types1 = new Scanner(typeList1);
			//final Scanner types2 = new Scanner(typeList2);
			BufferedReader types1 = new BufferedReader(new FileReader(typeList1));
			BufferedReader types2 = new BufferedReader(new FileReader(typeList2));
 
			//String currentLine;
			int spareCounter=0;
			spareCounter=0;
 
			while (hnnng){
				try {
					typesCheck1 = types1.readLine();
					typesCheck2 = types2.readLine();
				} catch (IOException e) {
					// TODO Auto-generated catch block
					e.printStackTrace();
				}
				typesList1.add(spareCounter, typesCheck1);
				typesList2.add(spareCounter, typesCheck2);
				spareCounter++;
				if ((typesList1.size())==(pokemonsTypeCheck.size())){
					hnnng=false;
				}
			}
		}
 
 
		System.out.print(pokemonsTypeCheck.get(pokemonNumber)+" is a "+typesList1.get(pokemonNumber));
		if (typesList2.get(pokemonNumber).equals(" ")){
			System.out.println(" type.");
		}
		else{
			System.out.println("/"+typesList2.get(pokemonNumber)+" type.");
		}