Thread: need help with array

Originally Posted by wolfrain62

So I am kinda new to java and was given a program to do.

a. Create one or more arrays to hold the names of the months and the number of days in each month. Assume that February always has 28 days.

b. Display the contents of the array(s).

c. Ask the user for a number to represent the month: 1 = Jan, 2 = Feb, etc. Search for the corresponding month and display the name of the month and the number of days. If the number is not found, display an error message.

d. Ask the user for the name of a month. Search for the corresponding month and display the number of the month and the number of days. If the month is not found, display an error message.

I have done a-c but i am having trouble with d.

[CODE]
package array;
import java.util.Scanner;
 
public class Main
{
 
    public static void main(String[] args)
    {
        int [] days = {31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31}; // Array holds number of days in month
        String [] months = {"January", "February", "March", "April", "May", "June", "July", "August", "September", "October", "November", "December"}; // array holds months
 
 
        for (int index = 0; index < months.length; index++) // loop to display number of days in month
        {
         System.out.println(months[index] + " has " + // displays number of days in month
                            days[index] + " days ");
        }
 
        Scanner keyboard = new Scanner(System.in); // creates scanner
        System.out.println("Enter a number to represent the month");
        int search = keyboard.nextInt(); // saves user value into search
 
        search--; // subtracts 1 from user input to account for the index of 0
 
        if(search > months.length)
 
            System.out.println("Can not find number"); // yes if search is more then months display error
        else
 
            System.out.println( months[search] + " has " + days[search] + " days "); // no if search is less then months display contents
 
 
        Scanner string = new Scanner(System.in); //creates new scanner
        System.out.println("Enter the name of the month");
        String input = string.nextLine(); // saves user strin in to input
 
       for (int index = 0; index < months.length; index++) //loop to compare user input to months array
       {
        if(input.equals(months[index])) // yes display month and days
           System.out.println(months[index] + " has " + // displays number of days in month
                              days[index] + " days ");
        else
            if(!(input.equals(months[index]))) // no display error
            System.out.println("can not find month");
       }
    }
 
}
[/CODE]

For future reference, use the CODE tags and the java highlighting tags. Check out the new people thread if you want to know how to do that.

I will take another look at your code now that I have highlighted it (and CODE tagged it) and get back to you.

Ok thanks I noe what the problem is just do not noe how to fix it.

Your problem is that the FOR loop is going through and printing lines for every one of the months. It then prints the correct line only for the matching month (with a bunch of could not find month statements).

I haven't thought of a solution yet (I'm kind of tired). I will try. Maybe in the mean time one of the Java experts here will come along and answer it!

I will let you know if I find something.

import java.util.Scanner;
 
public class Main
{
 
    public static void main(String[] args)
    {
        boolean success = false;
        int [] days = {31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31}; // Array holds number of days in month
        String [] months = {"January", "February", "March", "April", "May", "June", "July", "August", "September", "October", "November", "December"}; // array holds months
 
 
        for (int index = 0; index < months.length; index++) {  // loop to display number of days in month
         System.out.println(months[index] + " has " + // displays number of days in month
                            days[index] + " days ");
        }
 
        Scanner keyboard = new Scanner(System.in); // creates scanner
        System.out.println("Enter a number to represent the month");
        int search = keyboard.nextInt(); // saves user value into search
 
        search--; // subtracts 1 from user input to account for the index of 0
 
        if(search > months.length) {
          System.out.println("Can not find number"); // yes if search is more then months display error
        } else {
          System.out.println( months[search] + " has " + days[search] + " days "); // no if search is less then months display contents
 
        Scanner string = new Scanner(System.in); //creates new scanner
        System.out.println("Enter the name of the month");
        String input = string.nextLine(); // saves user strin in to input
 
       for (int index = 0; index < months.length; index++) { //loop to compare user input to months array
         if(input.equals(months[index])) {   // yes display month and days
           System.out.println(months[index] + " has " + days[index] + " days ");
           success = true;
         } else {
           success=false; //This is unnecessary.  I just hate blank else statements.
         }
       }
       if(success == false) {
         System.out.println("Cannot find month");
       }
    }
  }
}

This is the solution I came up with. Not THE MOST efficient way of doing it (I'm just tired and this was simple ). Oh and the second success=false is unnecessary. I just hate blank else statements

Idk if that is legal in your assignment or not but it works.

All I did was declare a boolean success = false after the opening of the main method.

Then I put true after the if.equals.

I moved the error to outside the FOR loop so it won't keep printing it.

Hope that helps!

Ahh thank you very much it working perfectly. I knew i should have used a Boolean