Thread: Cannot find where extra brace is at causing my errors

The following code i am having trouble with because of multiple errors saying class interface or enum expected. i was told it is extra or mismatched brace but cannot locate it any to help? Sorry if i didnt enclose code correctly still learning how to do that here

import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
 
import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.JTextField;
 
public class BasicCalculator {
	private static final int FRAME_WIDTH = 150;
	private static final int FRAME_HEIGHT = 120;
 
	// Keeps track of the current operation (subtract, add, etc)
	private static final int NO_OPERATION = 0;
	private static final int ADDITION = 1;
	public static int operation = NO_OPERATION;
 
	public static JTextField textFieldDisplay;
	public static double Value1 = 0; // holds the value before the operation
 
	public static void main(String[] args) {
		// Set up the user interface
		JFrame frame = new JFrame();
		JPanel buttonPanel = new JPanel();
		frame.add(buttonPanel);
 
		// create two buttons, plus and equal and a text box for answers
		textFieldDisplay = new JTextField(10);
		buttonPanel.add(textFieldDisplay);
		JButton buttonPlus = new JButton(" + ");
		buttonPanel.add(buttonPlus);
		JButton buttonEqual = new JButton(" = ");
		buttonPanel.add(buttonEqual);
 
		frame.setSize(FRAME_WIDTH, FRAME_HEIGHT);
		frame.setTitle("Basic Calculator");
		frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		frame.setVisible(true);
 
 
		// called when the equal sign '=' is pressed
		class EqualSignListener implements ActionListener {
 
			public void actionPerformed(ActionEvent event)
			{
				double Value2 = Double.parseDouble(textFieldDisplay.getText());
				if (operation == ADDITION) {
					// plus sign pressed before the equal sign
					Value2 += Value1;
				}
				// Convert from a answer to a string
				Double answer = new Double(Value2);
				textFieldDisplay.setText( answer.toString() );
				// Reset the operation to show no current operation
				operation = NO_OPERATION;
			}
		}
 
		// called when a plus sign '+' is pressed
		class PlusSignListener implements ActionListener {
			public void actionPerformed(ActionEvent event)
			{
				Value1 = Double.parseDouble(textFieldDisplay.getText());
				operation = ADDITION;
			}
		}
 
		// Add the methods that will be called when these buttons are pressed
		ActionListener plusSignListener = new PlusSignListener();
		buttonPlus.addActionListener(plusSignListener);
 
		ActionListener equalSignListener = new EqualSignListener();
		buttonEqual.addActionListener(equalSignListener);
 
	}
}
// called when a subtraction sign '-' is pressed
		class SubtractionSignListener implements ActionListener {
			public void actionPerformed(ActionEvent event)
			{
				Value1 = Double.parseDouble(textFieldDisplay.getText());
				operation = Subtraction;
			}
		}
 
		// Add the methods that will be called when these buttons are pressed
		ActionListener subtractionSignListener = new SubtractionSignListener();
		buttonPlus.addActionListener(subtractionSignListener);
 
		ActionListener equalSignListener = new EqualSignListener();
		buttonEqual.addActionListener(equalSignListener);
         }
)
// called when a division sign '/' is pressed
		class DivisionSignListener implements ActionListener {
			public void actionPerformed(ActionEvent event)
			{
				Value1 = Double.parseDouble(textFieldDisplay.getText());
				operation = DIVISION;
			}
		}
 
		// Add the methods that will be called when these buttons are pressed
		ActionListener divisionSignListener = new DivisionSignListener();
		buttonPlus.addActionListener(plusSignListener);
 
		ActionListener equalSignListener = new EqualSignListener();
		buttonEqual.addActionListener(equalSignListener);
          }
) 
// called when a plus sign '*' is pressed
		class MulitplicationSignListener implements ActionListener {
			public void actionPerformed(ActionEvent event)
			{
				Value1 = Double.parseDouble(textFieldDisplay.getText());
				operation = Multiplication;
			}
		}
 
		// Add the methods that will be called when these buttons are pressed
		ActionListener multiplicationSignListener = new MultiplicationSignListener();
		buttonPlus.addActionListener(plusSignListener);
 
		ActionListener equalSignListener = new EqualSignListener();
		buttonEqual.addActionListener(equalSignListener);
 
	}

If your editor does not have the tool to match a { with its paired }, your next option is to print it and use a pen to manually pair the { }s. Start at the middle, circle the { and find the paired } and draw a connecting line.
Continue until the mis-match is found.

someone else said my public static main was not closed,but when I tried to close by adding brace more errors occurred..am i missing brace here?


#public static void main(String[] args) {
// Set up the user interface
JFrame frame = new JFrame();
JPanel buttonPanel = new JPanel();
frame.add(buttonPanel);#

Can you see the 5 lines of code you posted?
Is there a } character there?

Please use code tags when posting your code. See: BB Code List - Java Forums

No..however when i add one to different lines i get errors like crazy..which line does it need to be on?

Where is the } that pairs with the { at the end of this line?

public static void main(String[] args) {

The code within those that pair of {} is what is in the main method. The main method should be fairly short and not include class definitions.

fixed almost all my errors now just getting <identifier> expected error on the third and last lines from the lines of code posted



[code]// Add the methods that will be called when these buttons are pressed
ActionListener divisionSignListener = new DivisionSignListener();
buttonPlus.addActionListener(plusSignListener);

ActionListener equalSignListener = new EqualSignListener();
buttonEqual.addActionListener(equalSignListener);[code]

The compiler is looking for a class but is finding code that should be in a method.

Is the code you posted inside of a method?

You have been AWESOME in your assistance..down to one error. it is a "reached end of file without parsing" error. have added and taken away braces at end..does not help. Currently have two "}" braces at end of code do i need more? or different braces?

You need to pair them up. Start at the middle and pair the {}. Work out to the next pair and continue until you find the unpaired {}.
Either use an editor tool or print it on paper and use a pencil.

ActionListener equalSignListener = new EqualSignListener();
buttonEqual.addActionListener(equalSignListener);
}
)

I'm not sure if this has been resolved or not but what is the round bracket for?

but what is the round bracket for?

Do you mean a paranthesis? You use pairs of them with methods.

each time i take one out that i think is mismatched it compounds the errors. Any willing to look at code to see if they can find the mismatched or extra brace? So i can clear my one error left?

I didn't imagine that finding the paired {} was so hard.
Did you print it out on paper and use a pen to match the {}s?

Or another approach: make a copy of the code. Find an inner most { and label it thus: {1
then find its matching } and label it thus: 1}
Then go out a level and do the same matching but with a different number {2 and 2}
Sometimes there will be some at the same level so: {3a and 3a}
Keep going until you find the mis-matched { or }

Originally Posted by Norm

Do you mean a paranthesis? You use pairs of them with methods.

Gee thanks Norm, I never knew that! [/sarcasm]

What I meant was I could not find a matching bracket in the code. It seemed to me that it should not be there.

Sorry, I didn't notice it was you. I thought it was the OP posting that comment. I have no idea what he knows or doesn't know about Java syntax.