Thread: Merging 2 arrays

i have to merge 2 arrays of size 3,im getting incorrect output plz help

import java.util.*;
class a
{
public static void main(String args[])
{
int i,j;
int []a=new int[3];
int []b=new int[3];
int []c=new int[6];
Scanner sc=new Scanner(System.in);
System.out.println("Enter the elements of the first array");
for(i=0;i<=2;i++)
{
a[i]=sc.nextInt();
}
System.out.println("Enter the elements of the second array");
for(j=0;j<=2;j++)
{
b[j]=sc.nextInt();
}
 
for(i=0;i<=2;i++)
{
c[i]=a[i];
}
for(j=0;j<=2;j++)
{
c[i]=b[j];
i++;
}
for(i=0;i<=5;i++)
{
System.out.println("The merged array");
System.out.println(c[i]);
 
}
}
}

What output are you getting? What output did you expect?

Do you really not indent your code?

Hint: Print out the index you're updating when you populate your c array in both for loops.

I'd recommend you run through this with a debugger, or at least put in a bunch of print statements, to figure out what's going on. I already gave you a hint.

Originally Posted by dlorde

ETA - sorry Kevin, I pre-empted you there...

No problem. He's got enough problems in that code for more than one person. :p

I've ran this through Netbeans IDE and it prints the output correctly. Can you be more specific when you say your not getting output, does this mean your obtaining an error during run time? Or does it mean that it's not printing correctly.

Also, in order to make your code easier to read (so that in the future we can solve your problems easier) you should avoid using cryptic abbreviations and use whole names when declaring variables, you should also use some form of indentation. And spaces when you're using operators and declaring variables.

Also when looping through arrays the Java programming language has what some people call a enhanced for loop, an example of an enhanced for loop (i've posted a tutorial below which explains this in depth) which could of been used in your program is this:

for(int anyNameHere : arrayNameHere)
            b[anyNameHere] = sc.nextInt();

Where anyNameHere is any name you want, and the arrayName is the array you want to loop through.

Tutorials:

http://download.oracle.com/javase/tu...bolts/for.html

Code Conventions for the Java Programming Language

The code you posted compiles and runs OK on ideone.com for me - although I have to wonder why you're using such an awkward way to compile and run your code. Why not use a local IDE that actually allows you to interact with your program directly?

Just put the "System.out.println("The merged array");" statement before the last for loop as:-

import java.util.*;
class a
{
public static void main(String args[])
{
int i,j;
int []a=new int[3];
int []b=new int[3];
int []c=new int[6];
Scanner sc=new Scanner(System.in);
System.out.println("Enter the elements of the first array");
for(i=0;i<=2;i++)
{
a[i]=sc.nextInt();
}
System.out.println("Enter the elements of the second array");
for(j=0;j<=2;j++)
{
b[j]=sc.nextInt();
}
 
for(i=0;i<=2;i++)
{
c[i]=a[i];
}
for(j=0;j<=2;j++)
{
c[i]=b[j];
i++;
}
System.out.println("The merged array");
for(i=0;i<=5;i++)
{
 
System.out.println(c[i]);
 
}
}
}

u will get what u r expecting.