No error, but I want criticism

**JustForLawls** · July 6th, 2011, 11:33 AM

Please take a look at my application, either execute the class from console, or run .bat on windows.

Virus Scan:
virusscan.jpg

Download

Code:

import static java.lang.System.out;
import java.util.Scanner;
 
class ChangeMaker {
 
	public static void main(String args[]) {
		Scanner inputNumber = new Scanner(System.in);
		out.println("Enter amount of cents as a whole number:");
 
		int total = inputNumber.nextInt();
 
		int quarters = total / 25;
		int extra = total % 25;
 
		int dimes = extra / 10;
		extra = extra % 10;
 
		int nickels = extra / 5;
		extra = extra % 5;
 
		int pennies = extra;
 
		out.println("From " + total + " cents, you get:");
        out.println(quarters + " quarters");
		out.println(dimes + " dimes");
		out.println(nickels + " nickels");
		out.println(pennies + " pennies");
	}
}

**Norm** · July 6th, 2011, 11:38 AM

Posting links makes it hard for someone to find your code with a Search.

**copeg** · July 6th, 2011, 12:34 PM

No offense, but very few folks (myself included) will download and run an app when we have no idea what it does or what the code behind it contains. What exact feedback are you looking for? User interface layout? how it operates? Suggestions for developments?

**JustForLawls** · July 6th, 2011, 01:15 PM

well, I'm not sure where to go next with it. You enter an int for amount of cents(I'm from USA), and it will tell you what coins make that amount. So, for $14.62, you would input 1462, and it will say how many quarters, dimes, nickels, and pennies make it up. Once I develop it more, I plan on having a free and paid version for restaurants and stores.

**Norm** · July 6th, 2011, 02:50 PM

One change to the print out, don't print out 0 of a coin, just print when there are coins.

**JustForLawls** · July 6th, 2011, 07:15 PM

oh okay, good idea.

**dlorde** · July 7th, 2011, 07:26 AM

Originally Posted by JustForLawls

Once I develop it more, I plan on having a free and paid version for restaurants and stores.

Good luck with that

**W00tbeer1** · July 10th, 2011, 10:34 PM

Originally Posted by JustForLawls

well, I'm not sure where to go next with it. You enter an int for amount of cents(I'm from USA), and it will tell you what coins make that amount. So, for $14.62, you would input 1462, and it will say how many quarters, dimes, nickels, and pennies make it up. Once I develop it more, I plan on having a free and paid version for restaurants and stores.

Sorry to burst your bubble but anybody can write a simple program to make change. I don't think any restaurant would pay for something like that. If you make a whole POS system for restaurants with dynamic input and networking... then you may be able too.

Thread: No error, but I want criticism

LinkBack

Thread Tools

Display

No error, but I want criticism

Related threads:

Re: No error, but I want criticism

Re: No error, but I want criticism

Re: No error, but I want criticism

Re: No error, but I want criticism

Re: No error, but I want criticism

Re: No error, but I want criticism

Re: No error, but I want criticism