Thread: Having problems with output to console....help!

My output is not printing to the screen, I only get zero's. I ran a dummy out.print in the getCustType and the values of sCustomerType and subtotal were printing right. But when I call the getInvoice method, the values do not follow. Can someone help me figure this out? do I need to use a setter method?
Here is my code:
Main method:

public class InvoiceApp
{
    public static void main(String[] args)
    {
	 	String message;
		double discountPercent=0;
		double discountAmount=0;
		double total=0;
		String customerType="";
		double subtotal=0;
		String sCustomerType="";
 
	 	// display a welcome message
                System.out.println("Welcome to the Invoice Total Calculator");
                System.out.println();  // print a blank line
 
                 Invoice myInvoice = new Invoice;
		//get customer type
		myInvoice.getCustType(sCustomerType, subtotal);
 
 
		//get invoice output
		myInvoice.getInvoice(sCustomerType, customerType, discountPercent, discountAmount, total, subtotal);//get formatted output in a string for printing
	   }
	}

Then the Invoice Class:

public class Invoice{
 
double percent;
double currency;
String sSubtotal;
String sCustomerType;
 
 
	public String getCustType(String sCustomerType, double subtotal){
 
		Scanner sc = new Scanner(System.in);
       		String choice = "y";
       		while(choice.equalsIgnoreCase("y"))
      		 {
         		// get user entries
         		String customerType = Validator.getString(sc,
                         "Enter customer type (r/c):   ");
			 subtotal = Validator.getDouble(sc,
                         "Enter subtotal:              ", 0, 10000);
 
            if (customerType.equalsIgnoreCase("r"))
            	sCustomerType = "Retail";
            else if (customerType.equalsIgnoreCase("c"))
            	sCustomerType = "College";
 
				//dummy line to check output
				System.out.println("Customer Type: " + sCustomerType);	
				System.out.println("subtotal: "+subtotal);
 
 
	    System.out.print("Continue? (y/n): ");
            choice = sc.next();
            System.out.println();
				}
 
	    return sCustomerType;
		}	
 
		public void getInvoice(String sCustomerType, String customerType, double subtotal){	// output formatted invoice	
 
				double discountPercent;
				//double subtotal;
				// customerType;
				double discountAmount;
				//double discountPercent;
				double total;
 
 
		// calculate the discount amount and total
            discountPercent = getDiscountPercent(subtotal, customerType);
            discountAmount = subtotal * discountPercent;
            total = subtotal - discountAmount;
 
		// format the values
            NumberFormat currency = NumberFormat.getCurrencyInstance();
            NumberFormat percent = NumberFormat.getPercentInstance();
 
	    String sDiscountPercent = percent.format(discountPercent);
            String sDiscountAmount = currency.format(discountAmount);
            String sTotal = currency.format(total);
            String sSubtotal = currency.format(subtotal);
 
 
            // format and display the results
            String message = "Subtotal:         " + sSubtotal + "\n"
                           + "Customer type:    " + sCustomerType + "\n"
                           + "Discount percent: " + sDiscountPercent + "\n"
                           + "Discount amount:  " + sDiscountAmount + "\n"
                           + "Total:            " + sTotal + "\n";
            System.out.println();
            System.out.println(message);
 
 
 
	}		
 
	 public double getDiscountPercent(double subtotal, String type)
    {
        double discountPercent = 0.0;
        if (type.equalsIgnoreCase("r"))
        {
            if (subtotal >= 500)
                discountPercent = .2;
            else if (subtotal >= 250 && subtotal < 500)
                discountPercent =.15;
            else if (subtotal >= 100 && subtotal < 500)
                discountPercent =.1;
            else if (subtotal < 100)
                discountPercent =.0;
        }
        else if (type.equalsIgnoreCase("c"))
        {
                discountPercent = .2;
        }
        else
            discountPercent = .05;
 
        return discountPercent;
     }
 
        }

Are there any error messages printed?

when I call the getInvoice method, the values do not follow.

What is printed out by the getInvoice() method?
Add some more printlns to show the values of variables as they are set and as they change.

I placed prinln's along the way to see what was happening, but there was nothing in the variables-blanks were printed. And no errors.

there was nothing in the variables-blanks were printed

Ok. Did the code execute thru the methods the way you expect? Did all the printlns execute?
Next question, why do the variables contain blanks instead of what you want there?

Are all the variables you printed Strings?
If you print any double or int variables, they will NOT print as blanks.

Yes the program executed the way i expected it to.
The string output is the way i have to have it formatted
I'm not sure why blanks are being printed...thats what i'm trying to figure out.

Can you post the output from the program that shows the problem?
And add some comments on the lines that are blanks.
Also can you post the code for the program.

Originally Posted by Norm

Can you post the output from the program that shows the problem?
And add some comments on the lines that are blanks.
Also can you post the code for the program.

My Code:
Main:

public class InvoiceApp
{
    public static void main(String[] args)
    {
	 	String message;
		double discountPercent=0;
		double discountAmount=0;
		double total=0;
		String customerType="";
		double subtotal=0;
		String sCustomerType="";
 
      // display a welcome message
      System.out.println("Welcome to the Invoice Total Calculator");
      System.out.println();  // print a blank line
 
		Invoice myInvoice = new Invoice();
 
		Scanner sc = new Scanner(System.in);
       		String choice = "y";
       		while(choice.equalsIgnoreCase("y"))
      		 {
         		// get user entries
         		 customerType = Validator.getString(sc,
                "Enter customer type (r/c):   ");
					 subtotal = Validator.getDouble(sc,
                "Enter subtotal:              ", 0, 10000);
 
            if (customerType.equalsIgnoreCase("r"))
            	sCustomerType = "Retail";
            else if (customerType.equalsIgnoreCase("c"))
            	sCustomerType = "College";
 
				//dummy line to check output
				System.out.println("Customer Type: " + sCustomerType);	
				System.out.println("subtotal: "+subtotal);
 
 
	    System.out.print("Continue? (y/n): ");
            choice = sc.next();
            System.out.println();
				}

getters and setters:

public class Invoice{
 
double percent;
double currency;
String sSubtotal;
String sCustomerType;
 
 
		public void calculate(String customerType, double subtotal){
           	double discountPercent=0;
				double discountAmount=0;
				double total=0;
 
 
				// calculate the discount amount and total
            discountPercent = getDiscountPercent(subtotal, customerType, discountPercent);
            discountAmount = subtotal * discountPercent;
            total = subtotal - discountAmount;		      
				//return discountPercent;			
				}	
 
		public String getMessege(String sCustomerType, double subtotal, double discountPercent, double discountAmount, double total){	// output formatted invoice	
 
 
			System.out.println("D%: "+discountPercent+"D$: "+discountAmount+"ST: "+subtotal+"T: "+total);
 
				// format the values
            NumberFormat currency = NumberFormat.getCurrencyInstance();
            NumberFormat percent = NumberFormat.getPercentInstance();
 
				String sDiscountPercent = percent.format(discountPercent);
            String sDiscountAmount = currency.format(discountAmount);
            String sTotal = currency.format(total);
            String sSubtotal = currency.format(subtotal);
 
 
            // format and display the results
            String message = "Subtotal:         " + sSubtotal + "\n"
                           + "Customer type:    " + sCustomerType + "\n"
                           + "Discount percent: " + sDiscountPercent + "\n"
                           + "Discount amount:  " + sDiscountAmount + "\n"
                           + "Total:            " + sTotal + "\n";
            System.out.println();
            System.out.println(message);
 
				return message;
 
				}		
 
	 public double getDiscountPercent(double subtotal, String customerType, double discountPercent)
    {
       // double discountPercent;
        if (customerType.equalsIgnoreCase("r"))
        {
            if (subtotal >= 500)
                discountPercent = .2;
            else if (subtotal >= 250 && subtotal < 500)
                discountPercent =.15;
            else if (subtotal >= 100 && subtotal < 500)
                discountPercent =.1;
            else if (subtotal < 100)
                discountPercent =.0;
        }
        else if (customerType.equalsIgnoreCase("c"))
        {
                discountPercent = .2;
        }
        else
            discountPercent = .05;
 
        return discountPercent;
     }
 
        }

Output:

Welcome to the Invoice Total Calculator

Enter customer type (r/c): r
Enter subtotal: 33
Customer Type: Retail <-----------dummy to check output after if/elses
subtotal: 33.0 <-----------dummy to check output after if/elses
Continue? (y/n): n

Customer Type: Retail
Subtotal: 33.0
D%: 0.0D$: 0.0ST: 33.0T: 0.0 <-----------dummy to check output after calculate()

Subtotal: $33.00
Customer type: Retail
Discount percent: 0%
Discount amount: $0.00
Total: $0.00

I got it to stop printing blanks, but it seems like my vars are being "stopped" somewhere.

it seems like my vars are being "stopped" somewhere.

Please explain what "stopped" means.

Where there any lines in the printed output you posted that show variables being "stopped"?
Can you edit the post and write comments next to the output describing what's wrong?

By "stopped" I mean they either are not being passed to getInvoice() or the output is not formatted right. After the calculate setter, the customerType and subtotal are still being passed and even into the getInvoice getter. Everything else is throwing zeros.

This is what I get When I execute the code you posted:

Welcome to the Invoice Total Calculator

Customer Type: Retail
subtotal: 33.0
Continue? (y/n):

right, now hit "n" and look at output.

Can you tell me if I'm using the setter-calculate- right? Usually it's a void with no arguments right?

The code you posted does not call any methods to print out any report.
Its sort of junk. It did not compile without my adding some additional }s

BTW I removed all the console input and hard coded the values into the variables. My IDE does not support console input.

Now type "n" and see what the formatted output does. Can you tell me if the setter method-calculate is right? Aren't setters void but have no parameters?

If you look at my #7 post, you will see what output I get. Also, the copy/paste method here might leave some stuff behind. It compiles and runs on my machine.

My program does not do console I/O. I hardcoded the responses in the program.

Did you see this part of my last post?
The code you posted does not call any methods to print out any report.
Its sort of junk. It did not compile without my adding some additional }s

If I don't have the code you are working with, I can NOT test it.

the copy/paste method here might leave some stuff behind

Fix it so there is a good version of your code to work with.

my code:
Main:

public class InvoiceApp
{
    public static void main(String[] args)
    {
	 	String message;
		double discountPercent=0;
		double discountAmount=0;
		double total=0;
		String customerType="";
		double subtotal=0;
		String sCustomerType="";
 
	 	// display a welcome message
      System.out.println("Welcome to the Invoice Total Calculator");
      System.out.println();  // print a blank line
 
      Invoice myInvoice = new Invoice();
 
		Scanner sc = new Scanner(System.in);
       		String choice = "y";
       		while(choice.equalsIgnoreCase("y"))
      		 {
         		// get user entries
         	 customerType = Validator.getString(sc,
                "Enter customer type (r/c):   ");
		 subtotal = Validator.getDouble(sc,
                "Enter subtotal:              ", 0, 10000);
 
            if (customerType.equalsIgnoreCase("r"))
            	sCustomerType = "Retail";
            else if (customerType.equalsIgnoreCase("c"))
            	sCustomerType = "College";
 
				//dummy line to check output
				System.out.println("Customer Type: " + sCustomerType);	
				System.out.println("subtotal: "+subtotal);
 
 
	    System.out.print("Continue? (y/n): ");
            choice = sc.next();
            System.out.println();
				}
 
 
 
 
 
 
 
		//get customer type
		myInvoice.calculate(sCustomerType, subtotal);
 
		//another check where is vars
		System.out.println("Customer Type: " + sCustomerType);
		System.out.println("Subtotal: " + subtotal);
 
		//get invoice output
		myInvoice.getMessage(sCustomerType, subtotal, discountPercent, discountAmount, total);//get formatted output in a string for printing
 
 
   }
	}//end class

Sorry I didn't realize part of my code didn't make it through.

Ok. I'm done. The code you posted does not compile with the earlier code.
One has:
public String getMessege(
and the latest has:
myInvoice.getMessage(

Notice the spelling differences.

You are wasting my time by posting this mismatched code over and over.

Appreciate your patience.