Thread: Printing an array

Gonna reply to my own post, the print part appears to be inside the wrong bracket set! muppet error
New code looks like this

import java.io.*;
class SortAsc
{
public static void main ( String agrs[] )
	{
 	int A[]={8,9,3,10};
 	int i,k;
 	for(i=0;i<4;i++)
 		{ 
		for(k=0;k<4;k++)
			{
			if (A[k]<A[i])
				{
				int temp;
				temp = A[k];
				A[k] = A[i];
				A[i] = temp;
				}
			}
		}
		int l;
		for(l=0;l<4;l++)
		{
			System.out.print(A[l]);
		}
	}
}

So is it fixed, or do you still get errors?

Incidentally, when looping through arrays, don't use 'magic numbers' to hard-code the length, use array.length. This way, you can't put in the wrong length, and if the length of the array changes, your code doesn't have to.

Hi Dlorde,
Yes it works now! When you say don't use magic numbers instead use array.length what do you mean? Could you possibly show me its use on the above code?
Thanks
native

A magic number is a numeric literal placed directly in your code, and should be avoided. Far better to use a well named variable initialized with that value. In your code, the magic numbers are the hard-coded loop end values (4). The correct way to iterate an array with a 'for' loop is to use the array length property, e.g:

int[] array = { 1, 2, 3, 4 };
...
for(i=0; i < array.length; i++) {
   ...

Incidentally, Java Naming Conventions mandate that class names start with uppercase letters and that method and variable names start with lowercase letters. This means you easily distinguish class names from variable names in source code.

Source code is for people to read, so make it readable.

Oh right I see! Works a treat. Thank you.

Here is full working code for anyone who may stumble across this topic in the future.

import java.io.*;
class SortAscEdit
{
public static void main ( String agrs[] )
	{
 	int array[]={8,9,3,10};
 	int i,k;
 	for(i=0;i<array.length;i++)
 		{ 
		for(k=0;k<array.length;k++)
			{
			if (array[k]<array[i])
				{
				int temp;
				temp = array[k];
				array[k] = array[i];
				array[i] = temp;
				}
			}
		}
		int l;
		for(l=0;l<array.length;l++)
		{
			System.out.println(array[l]);
		}
	}
}

OK, but my use of the variable name 'array' was just a generic example - I wasn't suggesting you use it. Always use descriptive names that tell people what the role of the variable or method or class is. Use noun forms for classes and variables, and verbal forms for methods.

Your array of numbers might be better called 'numbers' or 'numberArray', to make it clear what it contains, so the code is more understandable.

I was having trouble compiling under a different name so I called the array 'array' just to be sure it would compile. Then after I worked out why I was having compile problems so I guess I could change it to anything now.
Thanks